[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: No I guess its fine to leave it closed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: So, issue closed right? Or do you want to keep it bumped down and open for 2.6.6? -- status: open -> closed ___ Python tracker ___ __

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: done in r78935. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: Ok then, I am applying Barry's suggestion right now in release26-maint then -- ___ Python tracker ___ _

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Martin v. Löwis added the comment: The patch in its current form is incomplete: xxmodule.c won't end up on the target system, since msi.py doesn't package it. So that would need to be changed as well. With the current release26-maint branch, test_distutils now passes, both with xxmodule.c pr

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: Hi Martin, Can you just double check that the addition of xxmodule.c won't cause problems with the Windows installer. If it's okay (no problems), please close this bug and we'll keep the fix. Thanks. -- assignee: tarek -> loewis _

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: This will skip the whole test class if srcdir is not found, removing all tests run in test_build_ext. Are you sure you want to skip the whole test class if the srcdir is not there for 2.6.5 final ? (we have important tests in there, related to options like inpl

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: Tarek, r78877 is not the fix I recommended in http://bugs.python.org/issue8107#msg100858 Are you sure you're more comfortable with the one you committed than the one I suggested? -- ___ Python tracker

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: done in r78877 -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: @Ronald, @Barry: Yes that's what I did in trunk, so I can just merge that revision. (r78707, r78709) The only problem I had with it is that in case xxmodule.c changes, I have to change it there too, but it's no big deal. Barry, I'll merge back this as soon as I

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: Adding xxmodule.c to the test directory is more than I want to do for 2.6.5. The actual crash happens because if sysconfig.get_config_var('srcdir') returns None, os.path.join() will traceback. It doesn't know how to handle None arguments. So my suggestion

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Ronald Oussoren added the comment: IMHO stuffing xxmodule.c inside the distutils test tree (see msg100815) is the right solution because the python source tree might not be present during testing (such as when the user does a binary install and then runs the unittests to check if everything w

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Ned Deily added the comment: It's not that "srcdir" is broken - that undoubtedly was the value of the source directory on the *build* machine. The problem is that "srcdir", (and likely some other build related config variables) has no meaning other than on the *build* machine at the time of

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: Also, notice that srcdir can be broken on some platform. For instance, under Mac OS X Framework install: >>> import distutils.sysconfig >>> distutils.sysconfig.get_config_var('srcdir') '/Volumes/Rivendell/Users/ronald/Projects/python/r264' we get the path that w

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: No that won't work because the test tries to find a module that is only in the source dir. So not existing on python installations. The simplest thing to do is to skip the test if srcdir cannot be found. I'll fix this asap -- _

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: Tarek, I guess the fix is as haypo suggests? Just use sysconfig.project_base if sysconfig.get_config_var('srcdir') returns None? If that's the only change, then please do fix this for 2.6.5 final. Thanks! -- ___

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Ned Deily added the comment: I'm guessing this falls into the same category as Issue8102, that is, since the python tests are also installed and run on end-user systems by various installers, it is important that none of the tests depend on files from a python build directory or source tree.

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Tarek Ziadé added the comment: This test just grabs xxmodule.c from Python to try out a compilation. It's a lot of work just to try out a .c file in build_ext. I've already changed this in trunk by having a c file local to distutils tests, as a fallback in case the location cannot be found (d

[issue8107] test_distutils fails on Windows in 2.6.5rc2

STINNER Victor added the comment: The patch replaces sysconfig.project_base by sysconfig.get_config_var('srcdir'). You can maybe use sysconfig.project_base if sysconfig.get_config_var('srcdir') is None? -- ___ Python tracker

[issue8107] test_distutils fails on Windows in 2.6.5rc2

STINNER Victor added the comment: r77955 is a backport of r69304, commit made 12 months before the backport. It's related to issue #4151. -- nosy: +haypo ___ Python tracker ___

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Barry A. Warsaw added the comment: Um, this sucks because I think that that means it was introduced after 2.6.4 final. Since it's a regression, marking as a blocker for 2.6.5 final, but in order to stay a blocker it has to be a really critical bug and I'll want to review the fix before it go

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Changes by Tarek Ziadé : -- priority: normal -> high resolution: -> accepted ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8107] test_distutils fails on Windows in 2.6.5rc2

Ezio Melotti added the comment: This has been introduced in r77955, and affected all the 2.6 Windows buildbots (e.g. http://www.python.org/dev/buildbot/builders/x86%20XP-5%202.6/builds/9/steps/test/logs/stdio). The problem is caused by the fact that "srcdir = sysconfig.get_config_var('srcdir'

[issue8107] test_distutils fails on Windows in 2.6.5rc2

New submission from Martin v. Löwis : test_distutils fails like this: test test_distutils crashed -- : object of type 'NoneType' has no len() Traceback (most recent call last): File "Lib\test\regrtest.py", line 560, in runtest_inner indirect_test() File "c:\Python26\lib\test\test_distut