[issue7826] support caching for 2to3

Éric Araujo added the comment: FTR: https://github.com/pv/lib2to3cache -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-li

[issue7826] support caching for 2to3

Benjamin Peterson added the comment: I'm going to reject this for now. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ _

[issue7826] support caching for 2to3

Benjamin Peterson added the comment: 2010/2/11 Brian Harring : > > Brian Harring added the comment: > > @benjamin: > > Tests can be written; the reason this patch doesn't bundle tests up front is > that I wasn't going to burn the time till I knew they were needed since I > expected the concep

[issue7826] support caching for 2to3

Brian Harring added the comment: @benjamin: Tests can be written; the reason this patch doesn't bundle tests up front is that I wasn't going to burn the time till I knew they were needed since I expected the concept to require some debate. As for the hacks angle, there isn't anything hackish

[issue7826] support caching for 2to3

Benjamin Peterson added the comment: I'm apprehensive about accepting this patch for several reasons. First of all, it has no tests. Secondly, and more importantly, I dislike the hacks that it adds. I would prefer 2to3 to grow a more general plugin API, which people could use to add new fixer

[issue7826] support caching for 2to3

Brian Harring added the comment: Contributor agreement form is enroute via snail mail... kind of wish y'all accepted pdf's via email though ;) As for the print("cache hit"), that should be punted- not very useful in it's current form (doesn't indicate what 'hit') and slipped in accidentally.

[issue7826] support caching for 2to3

Changes by Georg Brandl : -- assignee: -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list maili

[issue7826] support caching for 2to3

Martin v. Löwis added the comment: Please submit a contributor agreement, see http://www.python.org/psf/contrib/ I'm still not clear on what the specific use case is: how *exactly* are you going to run 2to3 when you have that patch integrated? In particular, where do you put the output (3.x)

[issue7826] support caching for 2to3

Changes by Brian Harring : Removed file: http://bugs.python.org/file16080/2to3-caching.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue7826] support caching for 2to3

Changes by Brian Harring : Removed file: http://bugs.python.org/file16078/2to3-caching.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue7826] support caching for 2to3

Brian Harring added the comment: Related note, don't be drunk when posting the missing patch- sorry for the noise, here is the caching version,, daftly presumed the early patch contained lib2to3.caching Now I'm going to go crawl in a corner, if you need me, I'll be there. Doubly pardon. As f

[issue7826] support caching for 2to3

Brian Harring added the comment: *Cough*. Ya, going to blame the bugzie on that one. right, it's at fault rather than me being a complete freaking moron. Patch attached, hopefully with far less idiocy than I've demonstrated thus far Pardon. -- Added file: http://bugs.python.or

[issue7826] support caching for 2to3

Martin v. Löwis added the comment: If you meant to propose a patch that does caching, you should include the actual caching code in the patch. -- ___ Python tracker ___

[issue7826] support caching for 2to3

Changes by Brian Curtin : -- keywords: +needs review priority: -> normal stage: -> test needed ___ Python tracker ___ ___ Python-bugs

[issue7826] support caching for 2to3

Brian Harring added the comment: @martin: Yeah... that's probably the better approach, although seperation of processes (in terms of setup.py triggering conversion) has some benefits. The reason I used process seperation and invocation of main was to protect my distutils extensions against h

[issue7826] support caching for 2to3

Martin v. Löwis added the comment: Not sure what your use case is, but I always call the refactor method of my subclassed RefactoringTool, instead of calling main. See distutils.util.run_2to3 for an example (and distutils.command.build_py.build_py_2to3 for an application of that). --

[issue7826] support caching for 2to3

Brian Harring added the comment: Attached is a derivative of http://pkgcore.org/trac/pkgcore/browser/ferringb/snakeoil-dev/snakeoil/caching_2to3.py As you can see in that function, some nastyness is required right now to slip it in w/out duplicating code (hence the first patch). Patch attach

[issue7826] support caching for 2to3

New submission from Brian Harring : Bit like unittest, right now it's rather hard to extend 2to3 for caching support (and other outputs) w/out duplicating the main function. Attached is a patch that allows the refactoring tool class to be passed in- at the very least, this patch is enough to r