Martin v. Löwis <mar...@v.loewis.de> added the comment:

Please submit a contributor agreement, see http://www.python.org/psf/contrib/

I'm still not clear on what the specific use case is: how *exactly* are you 
going to run 2to3 when you have that patch integrated? In particular, where do 
you put the output (3.x) files? I'd rather recommend to create a --outdir 
option (assuming that would also fit your needs).

I'm -0 on using hashing. The whole point of this caching is speed, so wasting 
time in recomputing hash codes is, well, wasted.

If you do think you need hashing, please read the source file in binary, rather 
than first decoding and then encoding it.

Don't use print(). If you must output progress, use the same approach as the 
rest of 2to3 (i.e. logging).

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7826>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to