[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: > I think one more skip is required in test_socketserver. Fixed: 2.7 (r81543), 3.2 (r81545), 3.1 (r81546). Blocked in 2.6 (r81544). -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue7449] A number tests "crash" if python is compiled --without-threads

Stefan Krah added the comment: Victor, I think one more skip is required in test_socketserver. -- nosy: +skrah resolution: fixed -> status: closed -> open Added file: http://bugs.python.org/file17317/nothreads-socketserver-shutdown.patch ___ Python

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: Ported to py3k (r80600), blocked in 2.6 (r80602) and 3.1 (r80601). -- status: pending -> closed ___ Python tracker ___ _

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: I commited the patch into small parts: 1 (r80552): fix test_support.py for Python compiled without thread 2 (r80553): regrtest.py -j option requires thread support 3 (r80554): test_doctest: import trace module in test_coverage() 4 (r80555): skip test_multiproce

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: > Did someone notice that on Windows, subprocess imports threading, > and use threads for the communicate() method? No, I didn't ran the tests on Windows. I can expect that someone build Python on Linux without threads, but is Python used in embedded systems

[issue7449] A number tests "crash" if python is compiled --without-threads

Amaury Forgeot d'Arc added the comment: Did someone notice that on Windows, subprocess imports threading, and use threads for the communicate() method? -- nosy: +amaury.forgeotdarc ___ Python tracker _

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: Ok, here is my patch "version 4", based on jerry's nothreads_3.patch. Changes between version 3 and 4: - test_support: threading_setup() returns (1,) instead of None; reap_threads() simply returns the function instead of a dummy decorator - regrtest.py: d

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: > I think the latest (v3) patch is in pretty good shape. (...) > I'll break up the patch into multiple files as well. > It will make it easier to deal with if I cause a regression. I'm already doing that (apply the patch file by file). The patch v3 is not perf

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: I'll break up the patch into multiple files as well. It will make it easier to deal with if I cause a regression. -- ___ Python tracker ___ ___

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: I think the latest (v3) patch is in pretty good shape. You and David have been through the changes and the result is a much improved set of changes. If you want (and you're okay with it), I can commit the changes from here and take the beating if it makes th

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: I'm applying fixes one by one in my local git-svn repository. I will commit them (in one huge patch \o/) when I'm done, or maybe post a new version of the patch (if I'm too scared of the patch). -- ___ Python track

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: +1 to setup a buildbot, but only after all bugs are fixed :-) -- ___ Python tracker ___ ___ Python-b

[issue7449] A number tests "crash" if python is compiled --without-threads

R. David Murray added the comment: I think it is a good idea, but someone has to set one up. -- ___ Python tracker ___ ___ Python-bugs

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: I think this issue is going to reoccur every time someone adds a unit test that relies on threading. What do you think about using a buildbot slave to run the tests with a non-multithreaded build of python? -- ___

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: Uploaded a new version of the patch, nothreads_3.patch. @r.david.murray - Good point about unittest.skipUnless, I didn't know about that function. I removed my decorator and used skipUnless() instead. @haypo: test_xmlrpc.py - Modified the URL changes so that

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: > In the test_xmlrpc.py case I changed the value from URL to 'http:' because > the code that sets URL to a valid url relies on threading. When threading > is disabled, URL is set to None and the test will fail. I would prefer something like: if support thread

[issue7449] A number tests "crash" if python is compiled --without-threads

R. David Murray added the comment: I haven't reviewed the whole patch, but I would suggest that instead of making a test_support.skip_if_no (or any other name), you use use @unittest.skipUnless(threading) (note that lack of quotes around threading...you seem to already be getting it defined c

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: In the test_xmlrpc.py case I changed the value from URL to 'http:' because the code that sets URL to a valid url relies on threading. When threading is disabled, URL is set to None and the test will fail. The two ServerProxy test cases that were modified in

[issue7449] A number tests "crash" if python is compiled --without-threads

STINNER Victor added the comment: Comments about nothreads.patch. There are unrelated changes: Lib/test/test_xmlrpc.py: -p = xmlrpclib.ServerProxy(URL, transport=t) +p = xmlrpclib.ServerProxy('http:', transport=t) Lib/test/test_macostools.py (working copy) -try: -

[issue7449] A number tests "crash" if python is compiled --without-threads

Changes by Jerry Seutter : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7449] A number tests "crash" if python is compiled --without-threads

Jerry Seutter added the comment: The patch makes it so that tests that use threading skip rather than generate errors when python is compiled --without-threads. I added a skip_if_no('modulename') decorator to test_support. Let me know if this patch is too big to review and I'll break it up. I

[issue7449] A number tests "crash" if python is compiled --without-threads

Changes by Jerry Seutter : -- assignee: -> jseutter nosy: +jseutter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue7449] A number tests "crash" if python is compiled --without-threads

New submission from R. David Murray : In the past (<= 2.6) regrtest skipped a test if any import failure happened, which masked various real test failures. This was fixed, and tests that should be skipped if certain modules are not available were changed to use (test_)support.import_module, whic