STINNER Victor <victor.stin...@haypocalc.com> added the comment:

Comments about nothreads.patch. There are unrelated changes:

Lib/test/test_xmlrpc.py:
-        p = xmlrpclib.ServerProxy(URL, transport=t)
+        p = xmlrpclib.ServerProxy('http:', transport=t)

Lib/test/test_macostools.py     (working copy)
-        try:
-            os.unlink(TESTFN2)
-        except:
-            pass

Or you should explain me why you changed that :-)

Why not using test_support.import_module('threading') in test_xmlrpc.py, 
test_file2k.py, etc.?

I don't like importing a module in a function: you should use 
test_support.import_module('threading') in test_io.py, test_logging.py, 
test_capi.py, etc.

skip_if_no() function name is a little bit too generic. I don't have any 
suggestion.

----------
nosy: +haypo

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7449>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to