[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

R. David Murray added the comment: Committed to 2.6 in r74085, py3k in r74058 (by alexandre vassalotti), and 3.1 in r74086. -- status: open -> closed ___ Python tracker ___ _

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

R. David Murray added the comment: Drat. I should have uploaded the revised patch first for testing. I'll update it to the tested patch. -- ___ Python tracker ___ __

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: I didn't test ifndef-version, I tested the full version (issue6070.patch) on both Linux and w32. You are right, 'mode' must be defined even on w32. -- ___ Python tracker __

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco Buccini added the comment: @r.david.murray: Does this works on Windows? Are you sure Oleg? :) Since you've done this: #ifndef MS_WINDOWS /* mode = ..*/ #endif but on Windows the compiler "jumps" over this code, so you can get a binding error, since it doesn't find the variable "mode"...

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

R. David Murray added the comment: #ifndef version of the patch applied to trunk in r73870, with tests. Leaving open until I merge it. -- assignee: -> r.david.murray nosy: +brett.cannon resolution: -> fixed stage: test needed -> committed/rejected ___

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: Yes, I think #ifndef MS_WINDOWS is enough. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: I can confirm the patch works on WinXP on NTFS partition and Samba-shared network drive. I have WinXP running in an emulator (VirtualBox) and I compiled Python using MSVC90 Express. -- ___ Python tracker

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

R. David Murray added the comment: So we should just do #ifndef MS_WINDOWS? Do we have any non-windows non-posix platforms? (People on #python-dev don't think so.) -- ___ Python tracker __

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Tim Golden added the comment: Making something executable on Windows has nothing to do with file permissions. You can set them as much as you like, but executability is determined by file associations, possibly in association with PATHEXT settings. AFAICT, the current Python installer does this

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco added the comment: Thank you for your report :P Otherwise I really didn't know how solve it, thank you :P However, on *NIX-like systems it can work well; but can someone try it on Windows? Since I know that only NTFS (and versions >= XP) supports permissions, if a user have a FATfs (or

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: Sorry, found the bug in my process of testing. ./python uses /usr/lib/python26.so instead of ./python26.so. Setting LD_LIBRARY_PATH=. fixes the problem and the test passes. The patch is ok. -- ___ Python tracker <

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco added the comment: Thank you David.. sorry for my errors :) but this is my first patch :P I've recompiled py2.6 and it works fine on my Debian. As you can see: -rwxr-xr-x 1 marco marco81822 30 set 2008 setup.py ./python -c "import setup" -rw-r--r-- 1 marco marco42156 23 giu

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

R. David Murray added the comment: The patch did not apply for me. I modified the code by hand based on the patch file, and on Gentoo linux it worked for me. Patch that applies cleanly to trunk attached. -- nosy: +r.david.murray priority: -> low stage: -> test needed versions: +Pyth

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: I am not on Windows. I am on Linux. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco added the comment: hmm.. the problem is that Windows doesn't support well permissions as all the other POSIX compliant OSs ... I've searched for a solution on the web, and I've found a complete answer on: http://stackoverflow.com/questions/592448/c-how-to-set-file-permissions-cross-platfor

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Oleg Broytmann added the comment: import_patch2.patch doesn't work for me. I patched and compiled Python 2.6.2 and without installing it ran ./python -c "import test" in the build directory. It copied executable bits from test.py to test.pyc. -- ___

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Changes by Marco : Removed file: http://bugs.python.org/file14070/import_patch2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Changes by Marco : Removed file: http://bugs.python.org/file14049/import_patch.c ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco added the comment: TO loewis: this new patch works fine. I've removed the first #endif. thank you ;) -- Added file: http://bugs.python.org/file14072/import_patch2.patch ___ Python tracker __

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Martin v. Löwis added the comment: The patch of file 14070 doesn't compile, but I get the idea. I won't have time to test it in the next few days or weeks, though. -- ___ Python tracker

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Changes by Marco : Added file: http://bugs.python.org/file14070/import_patch2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Changes by Marco : Removed file: http://bugs.python.org/file14069/import_patch2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Marco added the comment: TO georg.brandl: I remembered that Windows wasn't POSIX compliant, but...I thought they used the same sys/stat.h constants. I was wrong :P TO loewis: ok, I've added a new patch. Since I've never written any code for Windows, can you check if it works fine now? I've adde

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Martin v. Löwis added the comment: No, they are not supported on Visual Studio. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Georg Brandl added the comment: Are these S_IX... constants available on every platform we support? -- nosy: +georg.brandl ___ Python tracker ___

[issue6070] Python 2.6 makes .pyc/.pyo bytecode files executable

Changes by Martin v. Löwis : -- title: Pyhon 2.6 makes .pyc/.pyo bytecode files executable -> Python 2.6 makes .pyc/.pyo bytecode files executable ___ Python tracker ___