[issue45512] [sqlite3] simplify "isolation level"

Erlend E. Aasland added the comment: Thanks for reviews and improvements, Dong-hee :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: New changeset 0920b61a0cb30128287ebafab1df8cad3a3dffdb by Erlend Egeberg Aasland in branch 'main': bpo-45512: Use Argument Clinic to set sqlite3 isolation level (GH-29593) https://github.com/python/cpython/commit/0920b61a0cb30128287ebafab1df8cad3a3dffdb --

[issue45512] [sqlite3] simplify "isolation level"

Change by Erlend E. Aasland : -- pull_requests: +27836 pull_request: https://github.com/python/cpython/pull/29593 ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Erlend E. Aasland added the comment: > Now we close this issue right? Not yet ;) I have an AC tweak I'd like to add. Wait for a PR anytime soon. -- ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: @erlendaasland Now we close this issue right? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: New changeset e002bbc6cce637171fb2b1391ffeca8643a13843 by Dong-hee Na in branch 'main': bpo-45512: Simplify manage isolation level (GH-29562) https://github.com/python/cpython/commit/e002bbc6cce637171fb2b1391ffeca8643a13843 --

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: New changeset 5f9247e36a0213b0dcfd43533db5cf6570895cfd by Erlend Egeberg Aasland in branch 'main': bpo-45512: Extend `sqlite3` test suite regarding isolation levels (GH-29576) https://github.com/python/cpython/commit/5f9247e36a0213b0dcfd43533db5cf6570895cfd --

[issue45512] [sqlite3] simplify "isolation level"

Change by Erlend E. Aasland : -- pull_requests: +27820 pull_request: https://github.com/python/cpython/pull/29576 ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Change by Dong-hee Na : -- pull_requests: +27810 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/29562 ___ Python tracker ___ _

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: New changeset 822c3dcce3996e411c1ff5c432c6ac7d2845cfd6 by Erlend Egeberg Aasland in branch 'main': bpo-45512: Raise exception if sqlite3.Connection.__init__ is called with bad isolation level (#29561) https://github.com/python/cpython/commit/822c3dcce3996e411c1

[issue45512] [sqlite3] simplify "isolation level"

Erlend E. Aasland added the comment: Need to amend GH-29053, so I'm opening until the fix is merged. -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Change by Erlend E. Aasland : -- pull_requests: +27809 pull_request: https://github.com/python/cpython/pull/29561 ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: New changeset b567b9d74bd9e476a3027335873bb0508d6e450f by Erlend Egeberg Aasland in branch 'main': bpo-45512: Simplify isolation_level handling in `sqlite3` (GH-29053) https://github.com/python/cpython/commit/b567b9d74bd9e476a3027335873bb0508d6e450f --

[issue45512] [sqlite3] simplify "isolation level"

Erlend E. Aasland added the comment: IMO, GH-29053 improves readability, mainly because of these factors: - Argument Clinic now takes care of the ref count dance, and as a bonus, it is more self-documenting (stating clearly that it accepts str and None) - Begin statement validation has been r

[issue45512] [sqlite3] simplify "isolation level"

Dong-hee Na added the comment: Hmm, now I understood what you intended, The code was hard to read without knowing the condition of the begin_statement. Would this be a trade-off in terms of code readability? -- nosy: +corona10 ___ Python tracker

[issue45512] [sqlite3] simplify "isolation level"

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27325 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29053 ___ Python tracker __

[issue45512] [sqlite3] simplify "isolation level"

New submission from Erlend E. Aasland : While working on bpo-45126 / GH-28227 (and while working on the AC conversion, bpo-40956), I've been slightly frustrated on the implementation of sqlite3 "isolation level". The code is messy, and we've got two connection members that carry pretty much t