[issue44751] crypt.h should be in _cryptmodule.c, not in public header

STINNER Victor added the comment: > See issue #32635, where Victor Stinner backported some commit (with > problematic location of '#include ') to 2.7 and 3.6 branches (which > was released in >=2.7.15 and >=3.6). crypt.h was added to Python.h by: https://github.com/python/cpython/pull/5284/

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Arfrever Frehtes Taifersar Arahesis added the comment: > > This is fix for regression which was previously backported to 2.7 and 3.6 > > branches. > > I'm not sure what you mean. > > In Python 2.7 and Python 3.6, was already included by > Include/Python.h: See issue #32635, where Victor S

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

STINNER Victor added the comment: > Could you backport this fix to at least 3.9 and 3.10 branches? Done. > This is fix for regression which was previously backported to 2.7 and 3.6 > branches. I'm not sure what you mean. In Python 2.7 and Python 3.6, was already included by Include/Pytho

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

STINNER Victor added the comment: New changeset 80285ecc8deaa2b0e7351bf4be863d1a0ad3c188 by Miss Islington (bot) in branch '3.10': closes bpo-44751: Move crypt.h include from public header to _cryptmodule (GH-27394) (GH-28636) https://github.com/python/cpython/commit/80285ecc8deaa2b0e7351bf4

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

miss-islington added the comment: New changeset 9626ac8b7421aa5fc04a30359521d24f40105141 by Miss Islington (bot) in branch '3.9': closes bpo-44751: Move crypt.h include from public header to _cryptmodule (GH-27394) https://github.com/python/cpython/commit/9626ac8b7421aa5fc04a30359521d24f4010

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Change by miss-islington : -- pull_requests: +27007 pull_request: https://github.com/python/cpython/pull/28638 ___ Python tracker ___ __

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Change by miss-islington : -- pull_requests: +27005 pull_request: https://github.com/python/cpython/pull/28636 ___ Python tracker ___ __

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Change by Sam James : -- nosy: +thesamesam ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Arfrever Frehtes Taifersar Arahesis added the comment: Could you backport this fix to at least 3.9 and 3.10 branches? This is fix for regression which was previously backported to 2.7 and 3.6 branches. -- nosy: +Arfrever ___ Python tracker

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

miss-islington added the comment: New changeset 196998e220d6ca030e5a1c8ad63fcaed8e049a98 by Geoffrey Thomas in branch 'main': closes bpo-44751: Move crypt.h include from public header to _cryptmodule (GH-27394) https://github.com/python/cpython/commit/196998e220d6ca030e5a1c8ad63fcaed8e049a98

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

Change by Geoffrey Thomas : -- keywords: +patch pull_requests: +25927 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27394 ___ Python tracker ___

[issue44751] crypt.h should be in _cryptmodule.c, not in public header

New submission from Geoffrey Thomas : In #32635, it was discovered that _cryptmodule.c was missing a dependency on crypt.h, which caused it to segfault when it was missing the proper prototype for crypt. This was fixed by adding an #include to Python.h. This include doesn't need to be in the