New submission from Geoffrey Thomas <geo...@ldpreload.com>:

In #32635, it was discovered that _cryptmodule.c was missing a dependency on 
crypt.h, which caused it to segfault when it was missing the proper prototype 
for crypt. This was fixed by adding an #include <crypt.h> to Python.h.

This include doesn't need to be in the public header; it only needs to be in 
_cryptmodule.c. Removing it from the public header is helpful for packagers, 
because it means that the libpython-dev (or whatever) package doesn't need a 
dependency on libcrypt-dev, only on the libcrypt runtime library.

----------
components: C API
messages: 398321
nosy: geofft
priority: normal
severity: normal
status: open
title: crypt.h should be in _cryptmodule.c, not in public header
versions: Python 3.10, Python 3.11, Python 3.7, Python 3.8, Python 3.9

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue44751>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to