[issue4473] POP3 missing support for starttls

Roundup Robot added the comment: New changeset 75a146a657d9 by Antoine Pitrou in branch 'default': Fix missing import (followup to #4473). http://hg.python.org/cpython/rev/75a146a657d9 -- ___ Python tracker

[issue4473] POP3 missing support for starttls

Antoine Pitrou added the comment: Patches committed. Thank you very much! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue4473] POP3 missing support for starttls

Roundup Robot added the comment: New changeset 79e33578dc05 by Antoine Pitrou in branch 'default': Issue #4473: Ensure the socket is shutdown cleanly in POP3.close(). http://hg.python.org/cpython/rev/79e33578dc05 New changeset d30fd9834cec by Antoine Pitrou in branch 'default': Issue #4473: Add

[issue4473] POP3 missing support for starttls

Antoine Pitrou added the comment: Thank you Lorenzo. Your patch lacks a couple of details, such as "versionadded" and "versionchanged" tags, but I can handle this myself. -- ___ Python tracker _

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff ___ Python tracker ___ ___ Python-bug

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: OK, I'm uploading poplib_03_starttls_v5.diff; I only changed the "caps=self.capa()" into "caps = self.capa()" in the "@@ -352,21 +360,42 @@ class POP3:" hunk. Thank you for pointing at the line; I tried to run pep8.py on poplib.py, but failed to find the

[issue4473] POP3 missing support for starttls

Antoine Pitrou added the comment: > where? In `caps=self.capa()` (you need a space around the assignment operator). > Here I'm following: at :ref:`pop3-objects` in Doc/library/poplib.rst, Ah, ok. Then I agree it makes sense to call it stls(). No need for an alias, IMO. -- _

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: Updated 02 and 03 patches (mostly) in line with Antoine's review comments: > 2) poplib_02_server_capabilities_v3.diff: > - please try to follow PEP 8 (i.e. `capa = {}` not `capa={}`) > - I think the capa() result should be a dict mapping str keys to str > va

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff ___ Python tracker ___ ___ Python-bug

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff ___ Python tracker ___ __

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff ___ Python tracker ___ ___ Python-bugs-

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file28025/poplib_02_server_capabilities_v4.diff ___ Python tracker ___ ___

[issue4473] POP3 missing support for starttls

Antoine Pitrou added the comment: Hello, Here are some comments about the patches: 1) poplib_01_socket_shutdown_v3.diff: looks fine to me 2) poplib_02_server_capabilities_v3.diff: - please try to follow PEP 8 (i.e. `capa = {}` not `capa={}`) - I think the capa() result should be a dict mappin

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26242/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-l

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26240/poplib_02_server_capabilities.diff ___ Python tracker ___ ___ P

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff ___ Python tracker ___ ___ Python

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff ___ Python tracker ___ ___ Python-bugs-

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff ___ Python tracker ___ ___

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26250/poplib_01_socket_shutdown_v3.diff ___ Python tracker ___ ___ Pytho

[issue4473] POP3 missing support for starttls

Jesús Cea Avión added the comment: Lorenzo, 3.3 is in beta mode now. No new features accepted :-(. Please, fulfill a PSF contributor agreement http://www.python.org/psf/contrib/ -- ___ Python tracker _

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: I've refreshed once more the patches, adding the implementation of the stls command in test_poplib.py. IMHO, the changes as they stand now are low risk, and could as well go into 3.3. With many thanks to Giampaolo for implementing the asynchat/asyncore po

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26241/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-l

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26242/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-lis

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26241/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-lis

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26134/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-l

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26133/poplib_02_server_capabilities.diff ___ Python tracker ___ ___ P

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26240/poplib_02_server_capabilities.diff ___ Python tracker ___ ___ Pyth

[issue4473] POP3 missing support for starttls

Changes by Antoine Pitrou : -- versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: I've refreshed the patches to apply on 3.3, and adapted the to the unit-test framework by giampaolo.rodola. -- ___ Python tracker ___ __

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26133/poplib_02_server_capabilities.diff ___ Python tracker ___ ___ Pyth

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12966/test_popnet.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12965/test_popnet.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12192/poplib_01_CAPA.diff ___ Python tracker ___ ___ Python-bugs-list

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26134/poplib_03_starttls.diff ___ Python tracker ___ ___ Python-bugs-lis

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff ___ Python tracker ___ ___ Python-b

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12189/poplib_04_STLS.diff ___ Python tracker ___ ___ Python-bugs-list

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff ___ Python tracker ___ ___ Python-b

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12172/poplib.rst.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff ___ Python tracker ___ ___ Python-bu

[issue4473] POP3 missing support for starttls

Changes by R. David Murray : -- components: +email nosy: +barry, r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue4473] POP3 missing support for starttls

Jesús Cea Avión added the comment: 3.3 beta will be published next Sunday. Any hope? Lorenzo, is your patch applicable to 3.3? -- ___ Python tracker ___

[issue4473] POP3 missing support for starttls

Changes by Jesús Cea Avión : -- versions: +Python 3.3 -Python 2.7, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4473] POP3 missing support for starttls

Changes by Antoine Pitrou : -- nosy: +janssen priority: -> normal stage: -> patch review type: -> feature request versions: +Python 2.7, Python 3.2 ___ Python tracker ___ _

[issue4473] POP3 missing support for starttls

Jesús Cea Avión added the comment: Ping... Any hope for 2.7/3.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue4473] POP3 missing support for starttls

Jesús Cea Avión added the comment: How is going? Any hope for 2.7/3.2? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue4473] POP3 missing support for starttls

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue4473] POP3 missing support for starttls

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: I'm enclosing the expected-failure version of test_popnet. It's much simpler to talk and comment about something you can see! Added file: http://bugs.python.org/file12966/test_popnet.py ___ Python tracker

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci added the comment: There is a problem I forgot to state with test_anonlogin: since I try and test both SSL and starttls, the DoS checker at cmu kicks in and refuse the login attempt in PopSSLTest. Since I'd rather avoid cheating, I'm leaning to try logging in as SomeUser, and

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file12965/test_popnet.py ___ Python tracker ___ ___ Python-bugs-list mailing

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: As for the shutdown/close comment, I think there could be cases where you are going to close but don't want to shutdown: e.g. you might close a dup-ed socket, but the other owner would want to continue working with his copy of the socket.

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12186/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: Changed CAPA as requested: now there is a proper docstring, and the useless if ... else ... is gone. Added file: http://bugs.python.org/file12192/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTE

[issue4473] POP3 missing support for starttls

STINNER Victor <[EMAIL PROTECTED]> added the comment: "lst[1:] if len(lst)>1 else []" is useless, lst[1:] alone does the same :-) So it can be simplify to: def _parsecap(line): lst = line.split() return lst[0], lst[1:] You might add a real example in the capa() docstring. About pop

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: I'm reasonably sure Victor is right about the original socket being unneeded. How does the series look now? ___ Python tracker <[EMAIL PROTECTED]>

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12170/poplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12189/poplib_04_STLS.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4473] POP3 missing support for starttls

Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12186/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue4473] POP3 missing support for starttls

STINNER Victor <[EMAIL PROTECTED]> added the comment: > As for the shutdown before close, it's needed to let the server know > we are leaving, instead of waiting until socket timeout. Extracts of an UNIX FAQ [1]: "Generally the difference between close() and shutdown() is: close() closes the so

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: I understand the need to keep things simple, but this time the split seemed a bit overkill. If needed, I'll redo the patch into a small series. Thinking of it... I was unsure if it really made sense to split out smtp/pop/imap patches inste

[issue4473] POP3 missing support for starttls

STINNER Victor <[EMAIL PROTECTED]> added the comment: You might split your patch into smaller patches, example: * patch 1: implement CAPA method * patch 2: POP3_SSL refatoring * patch 3: stls() method Comments: - Do you really need to keep a reference to the "raw" socket (self._sock) for

[issue4473] POP3 missing support for starttls

Changes by Giampaolo Rodola' <[EMAIL PROTECTED]>: -- nosy: +giampaolo.rodola ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-

[issue4473] POP3 missing support for starttls

Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: The needed changes to documentation if the patch gets accepted Added file: http://bugs.python.org/file12172/poplib.rst.patch ___ Python tracker <[EMAIL PROTECTED]> __

[issue4473] POP3 missing support for starttls

New submission from Lorenzo M. Catucci <[EMAIL PROTECTED]>: In the enclosed patch, there are four changes 1. add support for the optional CAPA pop command, since it is needed for starttls support discovery 2. add support for the STLS pop command 3. replace home-grown file-like methods and rep