STINNER Victor <[EMAIL PROTECTED]> added the comment: You might split your patch into smaller patches, example: * patch 1: implement CAPA method * patch 2: POP3_SSL refatoring * patch 3: stls() method
Comments: - Do you really need to keep a reference to the "raw" socket (self._sock) for a SSL connection? - I don't understand what is sock.shutdown(SHUT_RDWR). When is it needed? Does it change the behaviour? - Could you write a method to parse the capabilities because I hate long lambda function. You may write doctest for the new method :-) ---------- nosy: +haypo _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
