[issue4279] Module 'parser' fails to build

Martin v. Löwis added the comment: I have now committed 2.6.1-parsermodule.patch as r68523, r68524, r68525, and r68526. Thanks for the patch. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue4279] Module 'parser' fails to build

Yaakov (Cygwin Ports) added the comment: Here's the patch I used for the Cygwin Ports 2.6 and 3.0 packages. It's the simplest working solution that I could find. Added file: http://bugs.python.org/file12682/2.6.1-parsermodule.patch ___ Python tracker

[issue4279] Module 'parser' fails to build

Mark Sapiro added the comment: This problem also occurs when building the 2.6.1 parser module on Cygwin 1.5.25. It did not occur with Python 2.6 or 2.5.x. The error from 'make' is building 'parser' extension gcc -shared -Wl,--enable-auto-image-base build/temp.cygwin-1.5.25-i686-2.6/cygdrive/c/

[issue4279] Module 'parser' fails to build

Changes by Yaakov (Cygwin Ports) <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12132/3.0rc3-parsermodule.patch ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4279] Module 'parser' fails to build

Yaakov (Cygwin Ports) <[EMAIL PROTECTED]> added the comment: Attempting to export and use Py_meta_grammar() gives me a broken module, based on the results of test/test_parser.py. This patch, which exports _PyParser_Grammar, is very simple and the test passes. I will gladly take guidance on this

[issue4279] Module 'parser' fails to build

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I think the parser module should call one of the existing functions. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue4279] Module 'parser' fails to build

Yaakov (Cygwin Ports) <[EMAIL PROTECTED]> added the comment: I can confirm this problem in 3.0rc3 on Cygwin. If I could get some direction from the Python devs on which method would be preferred (accessor function vs. exposing data structure), I would be happy to provide a patch. -- nos

[issue4279] Module 'parser' fails to build

Andy <[EMAIL PROTECTED]> added the comment: Martin: Looking at it I agree with you 100% - the patch is too complicated for what it is intending to resolve. It simply does not need another accessor function to muddy the waters when making the symbol public as done in #4288 resolves the issue.

[issue4279] Module 'parser' fails to build

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: As a style guide remark: drop the parentheses around the expression in the return statement (return is a statement, not a function), and prefix all global symbols with Py or _Py. See PEP 7 for further instructions. __

[issue4279] Module 'parser' fails to build

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: That patch is too complicated. We already have meta_grammar and Py_meta_grammar, and now you also add a third function (get_PyParserGrammar) that does the same thing again. I don't see why you can't call one of the existing functions, and I f

[issue4279] Module 'parser' fails to build

Changes by Andy <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11960/parsermodule_fix.diff ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4279] Module 'parser' fails to build

Andy <[EMAIL PROTECTED]> added the comment: a new patch that will use the grammar definition from Python/graminit.c - it is as of yet untested for Cygwin (can't get to that machine right now). It follows the same pattern as the previous, i.e. it makes us of an accessor function to get the grammar

[issue4279] Module 'parser' fails to build

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: As Christian said in #4288: this links in a separate of metagrammar.c, which is undesirable. However, I think you can fix this by exporting Py_meta_grammar from pythonxy.dll. -- nosy: +loewis ___

[issue4279] Module 'parser' fails to build

Andy <[EMAIL PROTECTED]> added the comment: bah I *am* a idiot, #4288 and Christian's comments point out that I can't use 'find' & 'xargs' properly :-( Will modify patch to use the correct grammar file &c. (and maybe one day I might actually say something sensible to do with Python development

[issue4279] Module 'parser' fails to build

Changes by David W. Lambert <[EMAIL PROTECTED]>: -- nosy: +LambertDW ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mai

[issue4279] Module 'parser' fails to build

New submission from Andy <[EMAIL PROTECTED]>: With a clean checkout of the py3k source it fails to build the Parser exension module (based on Modules/parsermodule.c) when building against a cygwin target. This appears to be related to the movement of the symbol _PyParser_Grammar from graminit