[issue42644] logging.disable('WARN') breaks AsyncIO

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.7 ___ Python tracker ___

[issue42644] logging.disable('WARN') breaks AsyncIO

miss-islington added the comment: New changeset db63da7e5d4a98925a04f903a19bf3595b9c2c46 by Miss Islington (bot) in branch '3.9': bpo-42644: Validate values in logging.disable() (GH-23786) https://github.com/python/cpython/commit/db63da7e5d4a98925a04f903a19bf3595b9c2c46 --

[issue42644] logging.disable('WARN') breaks AsyncIO

miss-islington added the comment: New changeset 0a24a57888798905e3b8891c59e61ed4f1bfc5a8 by Miss Islington (bot) in branch '3.8': bpo-42644: Validate values in logging.disable() (GH-23786) https://github.com/python/cpython/commit/0a24a57888798905e3b8891c59e61ed4f1bfc5a8 --

[issue42644] logging.disable('WARN') breaks AsyncIO

Andrew Svetlov added the comment: New changeset b32d8b4f9bcd2e7d11240b6b9de0262cf8f5e09d by Matthias Bussonnier in branch 'master': bpo-42644: Validate values in logging.disable() (#23786) https://github.com/python/cpython/commit/b32d8b4f9bcd2e7d11240b6b9de0262cf8f5e09d --

[issue42644] logging.disable('WARN') breaks AsyncIO

Change by miss-islington : -- pull_requests: +22654 pull_request: https://github.com/python/cpython/pull/23797 ___ Python tracker ___ __

[issue42644] logging.disable('WARN') breaks AsyncIO

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +22653 pull_request: https://github.com/python/cpython/pull/23796 ___ Python tracker _

[issue42644] logging.disable('WARN') breaks AsyncIO

Change by Andrew Svetlov : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue42644] logging.disable('WARN') breaks AsyncIO

Change by Andrew Svetlov : -- components: +Library (Lib) -asyncio ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue42644] logging.disable('WARN') breaks AsyncIO

Xavier Morel added the comment: Oh I now see you've created a PR to do essentially that, nm. -- ___ Python tracker ___ ___ Python-b

[issue42644] logging.disable('WARN') breaks AsyncIO

Xavier Morel added the comment: > I think that patching logging.disable to raise a type error immediately would > be welcome FWIW `logging` has a built-in checker / converter[0] which is already used in a bunch of places (e.g. the aforementioned setLevel), it could just be added inside `dis

[issue42644] logging.disable('WARN') breaks AsyncIO

Change by Matthias Bussonnier : -- keywords: +patch pull_requests: +22643 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23786 ___ Python tracker

[issue42644] logging.disable('WARN') breaks AsyncIO

Matthias Bussonnier added the comment: I should have been more careful in my explanation in the upstream issue to have a complete report in here. I think that patching logging.disable to raise a type error immediately would be welcome; as the effect of storing a wrong type make any asyncio

[issue42644] logging.disable('WARN') breaks AsyncIO

Xavier Morel added the comment: The problem seems to be in the user code? As you were told by "Carreau", loggin.disable takes a logging level (an integer), since you're giving it a string which it dutifully stores, it blows up at the next logging call which happens to be in asyncio. This is

[issue42644] logging.disable('WARN') breaks AsyncIO

OverLordGoldDragon added the comment: Everything's in the linked issue; in summary, the command kills IPython, and an IPython maintainer showed code suggesting the problem's rooted in CPython's improper handling of 'WARN' as alias for logging.WARN. -- ___

[issue42644] logging.disable('WARN') breaks AsyncIO

Andrew Svetlov added the comment: Reporting what? Please elaborate. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue42644] logging.disable('WARN') breaks AsyncIO

New submission from OverLordGoldDragon : import logging with logging.disable('WARN'): pass See: https://github.com/ipython/ipython/issues/12713 I'm not actually sure what's happening here, just reporting. -- components: asyncio messages: 383040 nosy: OverLordGoldDragon, asvetlov, yseli