[issue38892] Audit Hook doc typos and confusion

miss-islington added the comment: New changeset 86d9933cc627c4232f9702ca0766713714ebbc53 by Miss Islington (bot) in branch '3.8': bpo-38892: Improve docs for audit event (GH-17361) https://github.com/python/cpython/commit/86d9933cc627c4232f9702ca0766713714ebbc53 -- nosy: +miss-islin

[issue38892] Audit Hook doc typos and confusion

Steve Dower added the comment: Thanks Terry! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38892] Audit Hook doc typos and confusion

Steve Dower added the comment: New changeset e563a155be60fc0757914f87c8138f10de00bb16 by Steve Dower (Terry Jan Reedy) in branch 'master': bpo-38892: Improve docs for audit event (GH-17361) https://github.com/python/cpython/commit/e563a155be60fc0757914f87c8138f10de00bb16 -- ___

[issue38892] Audit Hook doc typos and confusion

Change by miss-islington : -- pull_requests: +16873 pull_request: https://github.com/python/cpython/pull/17391 ___ Python tracker ___ __

[issue38892] Audit Hook doc typos and confusion

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +16846 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17361 ___ Python tracker __

[issue38892] Audit Hook doc typos and confusion

Terry J. Reedy added the comment: I agree on consistency. I will make a PR for you to review. Do you think a minimal code example might help? Running ... import sys def hook(name, args): if name.startswith('compile'): print(name, args) sys.addaudithook(hook) compile('a = 1', '

[issue38892] Audit Hook doc typos and confusion

Steve Dower added the comment: Thanks Terry, this is great! Agree with everything apart from not liking "raise" - I think "raise an event" is totally fine usage, and certainly better than "triggers an audit call" (since it may not, if nobody's listening). Plus PEP 578 is full of "raise", and

[issue38892] Audit Hook doc typos and confusion

New submission from Terry J. Reedy : Some suggestions for https://docs.python.org/3.9/c-api/sys.html#c.PySys_AddAuditHook https://docs.python.org/3.9/library/sys.html#sys.addaudithook "Adds to the collection of active auditing hooks" "Adds the callable hook to the collection of active auditing h