[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Thanks! ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubscr

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. patches applied in r66126 and r66127. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> __

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Ben, if you get a chance to apply those patches, feel free, otherwise I should be able to get to them this evening (my time - about 10 hours from now). ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Regarding the factory functions that are named as if they were classes, Fredrik noted on python-dev that the ones from the threading module are explicitly documented as being factory functions, and the multiprocessing API really just follows tha

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patches look good to me. Please apply. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Updated the 2.6 threading patch to also remove the warnings from the methods that are being replaced by properties. Added file: http://bugs.python.org/file11329/issue3352_remove_threading_py3k_warnings.diff ___

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Nick Coghlan <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11324/issue3352_remove_threading_py3k_warnings.diff ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: And one last patch to adjust the threading docs in Py3k to reflect the fact that the 2.x API is still supported, even if it is no longer documented. Added file: http://bugs.python.org/file11328/issue3352_update_30_threading_docs.diff

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Patch added to tone down note regarding the PEP 8 compliant aliases that have been added to the threading module. Added file: http://bugs.python.org/file11327/issue3352_tone_down_26_threading_docs.diff ___

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: It turns out threading uses the odd "class-that-is-not-a-class" naming scheme as well: threading.Lock threading.RLock threading.Condition threading.Semaphore threading.BoundedSemaphore threading.Event threading.Timer ___

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Nick Coghlan <[EMAIL PROTECTED]>: -- keywords: +patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Nick Coghlan <[EMAIL PROTECTED]>: -- assignee: jnoller -> ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list ma

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Nick Coghlan <[EMAIL PROTECTED]>: -- keywords: +needs review -patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bug

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Second patch added that removes the deprecation warnings from the Py3k version of the threading module. Added file: http://bugs.python.org/file11326/issue3352_remove_threading_deprecation_warnings.diff ___

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Patch added that removes the incorrect Py3k warnings from the threading module (also restores the methods to the same __name__ attributes as they had in 2.5). Added file: http://bugs.python.org/file11324/issue3352_remove_threading_py3k_warning

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Benjamin's patch was applied in r65982 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: I found further PEP 8 non-compliances in the multiprocessing API while working on a patch for issue 3589, mainly in the area of function names that start with a capital letter, making them look like classes when they definitely are not. After n

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Here's a patch. Added file: http://bugs.python.org/file11221/get_name.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: There are still some instances of get_name() in threading.py itself, which gives errors like the following: Unhandled exception in thread started by > Traceback (most recent call last): File "/home/antoine/cpython/cpickle/Lib/threading.py"

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: deferred blocker -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: committed the v3 patch as-is in r65864 - moving from release blocker to deferred blocker pending the Docs cleanup, and outstanding debate points. -- priority: release blocker -> deferred blocker ___

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: And here is v3 - I fixed all of the Docs/include/mp* scripts to reflect the new API Added file: http://bugs.python.org/file11165/mp_api_cleanup-v3.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: I attached the wrong patch, here is v2 Added file: http://bugs.python.org/file11164/mp_api_cleanup.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Jesse Noller <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11163/mp_nohang_jnoller.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Jesse Noller <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11160/mp_api_cleanup.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: Here is a cleaned up patch (ben was right, I typo'ed a few spots) - I did not clean up the docs from the original patch except to correct the x.x(Foo) accidents. Added file: http://bugs.python.org/file11163/mp_nohang_jnoller.patch __

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > Note regarding those comments - only the exitcode one is something we > should try to get sorted for the beta. Backing out the deprecation > warnings and cleaning up the documentation c

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > Note regarding those comments - only the exitcode one is something we > should try to get sorted for the beta. Backing out the deprecation > warnings and cleaning up the documentation c

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Barry said that is_alive should remain a method following in Guido's footsteps. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Note regarding those comments - only the exitcode one is something we should try to get sorted for the beta. Backing out the deprecation warnings and cleaning up the documentation can wait for the first release candidate. __

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: Just saw a couple of docs checkins go by suggesting that the camelCase names will be unavailable in 3.x. Remember that the intent *isn't* to remove the old names from threading.py - we're just adding the PEP 8 names so that multiprocessing can h

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks pretty good. In a few places, you replaced x.set_x(True) with x.x(True). The docs also will need a few tweaks. Otherwise, if the tests pass, I say go ahead. ___ Python tracker <[EMAIL PRO

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: Nick/Ben - here's a rough draft patch for the attribute changes for mp - could you both take a look and let me know what you think? -- keywords: +patch Added file: http://bugs.python.org/file11160/mp_api_cleanup.patch

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: My preference actually isn't particularly strong either way, so I suggest asking Barry for a casting vote. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: On Tue, Aug 19, 2008 at 11:34 AM, Nick Coghlan <[EMAIL PROTECTED]> wrote: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > is_alive appears to be a potentially expensive check for the > multiprocessing side of things, which is why I'm

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Tue, Aug 19, 2008 at 10:34 AM, Nick Coghlan <[EMAIL PROTECTED]> wrote: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > is_alive appears to be a potentially expensive check for the > multiprocessing side of things, which is wh

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: is_alive appears to be a potentially expensive check for the multiprocessing side of things, which is why I'm inclined to leave it as a method. "if t.is_alive():" actually reads better to me than "if t.alive:" anyway. __

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: On Mon, Aug 18, 2008 at 2:45 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Oh, and by the way, I would start working on multiprocessing by > reverting r65828. > Makes sense. _

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: On Mon, Aug 18, 2008 at 2:44 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Ok. I've done the threading API and patched up multiprocessing so it > actually works. Jesse, can you

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Oh, and by the way, I would start working on multiprocessing by reverting r65828. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I've done the threading API and patched up multiprocessing so it actually works. Jesse, can you do multiprocessing? Also, can we decide about is_alive as a property? -- assignee: benjamin.peterson -> jnoller _

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I think I can get this done before the release now. For starters I changed thread.get_ident() to a property in r65818. -- assignee: -> benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> <

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: I created issue 3589 to cover the problem I mentioned above with the very misleading names for the package level functions in multiprocessing. ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Sorry, I'm not going to be able to work on this soon. -- assignee: benjamin.peterson -> ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: deferred blocker -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: release blocker -> deferred blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: This should not block the release of beta 2 IMHO ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: I don't know, but I am going to ping Antoine and Greg and see if they don't mind me applying it as-is. ___ Python tracker <[EMAIL PROTECTED]> __

[issue3352] Deficiencies in multiprocessing/threading API

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: On Jul 16, 2008, at 9:12 AM, Jesse Noller wrote: > I don't want to change the API or any other code before we get the > change > in for issue874900 which should fix/resolve issue3088 What's the holdup on 874900? _

[issue3352] Deficiencies in multiprocessing/threading API

Jesse Noller <[EMAIL PROTECTED]> added the comment: I don't want to change the API or any other code before we get the change in for issue874900 which should fix/resolve issue3088 ___ Python tracker <[EMAIL PROTECTED]> _

[issue3352] Deficiencies in multiprocessing/threading API

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Is anybody working on a patch for this? Nick, I agree with you about undesirable behavior, however if there is no patch currently under development, I'm inclined to defer blocking until beta3. -- nosy: +barry __

[issue3352] Deficiencies in multiprocessing/threading API

Nick Coghlan <[EMAIL PROTECTED]> added the comment: At this stage I'm still inclined to skip the warnings completely - at the very least, any eventual removals will go through a full deprecation cycle in 2.7/3.1 before being removed in 2.8/3.2. It's also much easier to be sure we aren't adversel

[issue3352] Deficiencies in multiprocessing/threading API

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I think we should still keep the py3k warnings on (I'll change them to PendingDeprecationWarnings if you want.), so the API doesn't abruptly change on people. With your approval, I'll make it so. -- assignee: -> benjamin.peterson

[issue3352] Deficiencies in multiprocessing/threading API

Andrii V. Mishkovskyi <[EMAIL PROTECTED]> added the comment: Actually, 'getx' -> 'fget'. Sorry for the typo. :) ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3352] Deficiencies in multiprocessing/threading API

Andrii V. Mishkovskyi <[EMAIL PROTECTED]> added the comment: Does this mean that all multiprocessing get_*/set_* methods should be changed to be properties? For example, multiprocessing.process.Process class defines not only set_name/get_name and is_daemon/set_daemon methods, but also get/set_aut

[issue3352] Deficiencies in multiprocessing/threading API

New submission from Nick Coghlan <[EMAIL PROTECTED]>: The "PEP 8 compliant" API for multiprocessing and threading needs to be cleaned up before release as per the thread on python-dev. The release manager gave approval for this change during that discussion [1]. Changes needed: - remove Py3k war