[issue3158] Doctest fails to find doctests in extension modules

Roundup Robot added the comment: New changeset 8520e0ff8e36 by R David Murray in branch 'default': whatsnew: doctest finds tests in extension modules (#3158) http://hg.python.org/cpython/rev/8520e0ff8e36 -- ___ Python tracker

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Done. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue3158] Doctest fails to find doctests in extension modules

Roundup Robot added the comment: New changeset c964b6b83720 by Zachary Ware in branch 'default': Issue #3158: Provide a couple of fallbacks for in case a method_descriptor http://hg.python.org/cpython/rev/c964b6b83720 -- ___ Python tracker

[issue3158] Doctest fails to find doctests in extension modules

Julian Taylor added the comment: the patch seems to work for me in ipython. -- nosy: +jtaylor ___ Python tracker ___ ___ Python-bugs-li

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Does this patch fix things for you? -- resolution: fixed -> status: closed -> open Added file: http://bugs.python.org/file33776/issue3158.__objclass__-fix.diff ___ Python tracker ___

[issue3158] Doctest fails to find doctests in extension modules

Thomas Kluyver added the comment: I think there's an issue with this change - ismethoddescriptor() doesn't guarantee that that the object has an __objclass__ attribute. Unbound PyQt4 signals appear to be a case where this goes wrong. This came up testing IPython on Python 3.4 - we subclass Doc

[issue3158] Doctest fails to find doctests in extension modules

Changes by Zachary Ware : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue3158] Doctest fails to find doctests in extension modules

Roundup Robot added the comment: New changeset 30b95368d253 by Zachary Ware in branch 'default': Issue #3158: Relax new doctests a bit. http://hg.python.org/cpython/rev/30b95368d253 -- status: pending -> open ___ Python tracker

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: One-year-olds don't like productivity. Committed, 3 hours after I said I would :). I'll leave this open for a couple days just in case. -- assignee: -> zach.ware resolution: -> fixed stage: -> commit review status: open -> pending __

[issue3158] Doctest fails to find doctests in extension modules

Roundup Robot added the comment: New changeset 95dc3054959b by Zachary Ware in branch 'default': Issue #3158: doctest can now find doctests in functions and methods http://hg.python.org/cpython/rev/95dc3054959b -- nosy: +python-dev ___ Python tracker

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: In the absence of input, I'm going to go ahead and commit this just in case in needs to be in before feature freeze, but I'll leave the issue open at "commit review" stage for a few days in case anyone does have something to say about it. -- ___

[issue3158] Doctest fails to find doctests in extension modules

Eric Snow added the comment: Larry: thoughts? -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Does this qualify as a new feature that needs to be in before beta 1? -- ___ Python tracker ___ ___ Pyt

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Here's a new version of the patch that I think addresses the points in your review (which I've also replied to on Rietveld). And I agree about not backporting. -- Added file: http://bugs.python.org/file32580/issue3158.v2.diff ___

[issue3158] Doctest fails to find doctests in extension modules

R. David Murray added the comment: Added some review comments. Because it could cause possibly buggy doctest fragments to run that previously did not run, I don't think it should be backported as a bug fix. -- nosy: +r.david.murray ___ Python tracke

[issue3158] Doctest fails to find doctests in extension modules

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: Ping! Anyone able to do a review of this patch? It still applies cleanly to default (or even 3.3, if this qualifies as a bug rather than a new feature). -- ___ Python tracker _

[issue3158] Doctest fails to find doctests in extension modules

Zachary Ware added the comment: In looking at test_decimal for issue16748, I discovered that not all of the doctests for _decimal are being tested. So, I fixed it (or at least tried to :). This patch does the following: - Replace most inspect.isfunction checks in DocTestFinder with inspect.i

[issue3158] Doctest fails to find doctests in extension modules

Changes by Terry J. Reedy : -- versions: -Python 2.5, Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3158] Doctest fails to find doctests in extension modules

Alexey Shamrin added the comment: I've added Tim Peters to the nosy list. Is there anyone else who should be considered as doctest maintainer? I've also checked further Python versions - a quick a look at latest doctest source shows that the problem is still there. There are some details (and a

[issue3158] Doctest fails to find doctests in extension modules

Fernando Pérez <[EMAIL PROTECTED]> added the comment: I think there are two issues that need to be separated: 1. The doctest bug. I'm happy with any resolution for it, and I'm not claiming that my patch is the best approach. isroutine() indeed works in my case, and if that approach works well

[issue3158] Doctest fails to find doctests in extension modules

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: For me, a 'function' is written in Python, a 'builtin' is written in C. The fact that it is defined in an extension module is irrelevant, and depends on the implementation: zlib is an extension module on Unix, but is linked inside pyth

[issue3158] Doctest fails to find doctests in extension modules

New submission from Fernando Pérez <[EMAIL PROTECTED]>: Doctest fails to find doctests defined in extension modules. With tools like cython (http://cython.org) it's trivially easy to add docstrings to extension code, a task that is much less pleasant with hand-written extensions. The following