[issue2997] PyNumberMethods has left-over fields in Py3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Applied in r64149. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- assignee: -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-l

[issue2997] PyNumberMethods has left-over fields in Py3

Guido van Rossum <[EMAIL PROTECTED]> added the comment: I say let's go with the cleanup. Extensions that want to be compiled under 2.x and 3.0 will need lots of #ifdef code anyway. -- nosy: +gvanrossum ___ Python tracker <[EMAIL PROTECTED]>

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Georg Brandl <[EMAIL PROTECTED]>: -- priority: -> critical ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list m

[issue2997] PyNumberMethods has left-over fields in Py3

Stefan Behnel <[EMAIL PROTECTED]> added the comment: The change that removed the nb_divide and nb_inplace_divide members is here: http://svn.python.org/view?rev=43285&view=rev http://svn.python.org/view/python/branches/p3yk/Include/object.h?rev=43285&view=diff&r1=43285&r2=43284 It dates back to

[issue2997] PyNumberMethods has left-over fields in Py3

Stefan Behnel <[EMAIL PROTECTED]> added the comment: I would accept that if this had been done in all cases, but as I wrote in my first comment, the previously existing slot "nb_divide", which comes *before* the named ones, has already been removed, so there is no way existing Py2 code can work u

[issue2997] PyNumberMethods has left-over fields in Py3

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Let me quote a comment from GvR about the similar issue1185: """ Can you redo the patch while keeping the slot *position* (though not the name or type)? The wasted space is minimal (4-8 bytes per type or class object) and it means a lo

[issue2997] PyNumberMethods has left-over fields in Py3

Stefan Behnel <[EMAIL PROTECTED]> added the comment: :) sorry, that's the problem when you don't have commit rights and leave the changes in your local copy. So this is still an open issue that should be fixed before beta1, thanks. ___ Python tracker <[EMAIL

[issue2997] PyNumberMethods has left-over fields in Py3

Georg Brandl <[EMAIL PROTECTED]> added the comment: Not to me... -- nosy: +georg.brandl resolution: out of date -> status: closed -> open ___ Python tracker <[EMAIL PROTECTED]> __

[issue2997] PyNumberMethods has left-over fields in Py3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- resolution: -> out of date status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2997] PyNumberMethods has left-over fields in Py3

Stefan Behnel <[EMAIL PROTECTED]> added the comment: This seems to have been applied in current SVN. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2997] PyNumberMethods has left-over fields in Py3

New submission from Stefan Behnel <[EMAIL PROTECTED]>: Here is a patch that removes three unused fields from the PyNumberMethods struct in Py3. Since two fields were already removed (one even before the ones this patch removes), there is no way existing Py2 C code that uses this struct can work i