[issue2504] Add gettext.pgettext() and variants support

Eli Schwartz added the comment: Interestingly enough, the final accepted patch (and the 2010 one) also fixes a bug where gettext.install(..., names='ngettext') would incorrectly work, in violation of the documentation. I think it would also incorrectly install 'gettext', too... It used to j

[issue2504] Add gettext.pgettext() and variants support

Change by Serhiy Storchaka : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ __

[issue2504] Add gettext.pgettext() and variants support

Serhiy Storchaka added the comment: New changeset 637a33b99685fd5d1032670fbe29c7c8a8f0ff63 by Serhiy Storchaka (Cheryl Sabella) in branch 'master': bpo-2504: Add pgettext() and variants to gettext. (GH-7253) https://github.com/python/cpython/commit/637a33b99685fd5d1032670fbe29c7c8a8f0ff63 -

[issue2504] Add gettext.pgettext() and variants support

Serhiy Storchaka added the comment: l*gettext() functions have been just deprecated in issue33710. Please update the PR and remove new l*gettext() functions. -- versions: +Python 3.8 -Python 3.7 ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

Cheryl Sabella added the comment: No, I didn't have a use case for the l* functions. I included them just as a result of applying the entire patch from 2010. I also didn't know if further discussion was needed before excluding them. -- ___ Pytho

[issue2504] Add gettext.pgettext() and variants support

Serhiy Storchaka added the comment: Do you have a use case for lpgettext() and like? -- ___ Python tracker ___ ___ Python-bugs-list

[issue2504] Add gettext.pgettext() and variants support

Cheryl Sabella added the comment: I've created a pull request for this based on Éric's patch in 2010. I attempted to incorporate the changes from #29755 into the new functions and tests. I believe these changes take care of items 1 and 2 from msg122439. I haven't tried to address item 3 in

[issue2504] Add gettext.pgettext() and variants support

Change by Cheryl Sabella : -- pull_requests: +6882 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue2504] Add gettext.pgettext() and variants support

Éric Araujo added the comment: It was an answer to «Is there anything I can do to help get this into the codebase» Feel free to take this on! I’ll try to review. -- ___ Python tracker __

[issue2504] Add gettext.pgettext() and variants support

Cheryl Sabella added the comment: Éric, Was your last comment intended as a todo for yourself or an outline of the steps needed for someone else to move this along (maybe it was a reply to Jonathan Schoonhoven's question)? If the latter, I'd be happy to try to work on the PR. Thanks! -

[issue2504] Add gettext.pgettext() and variants support

Éric Araujo added the comment: The patch would need to be applied on top of the current master to make a pull request. Then, the tasks outlined in that message should be addressed: https://bugs.python.org/issue2504#msg122439 -- assignee: loewis -> __

[issue2504] Add gettext.pgettext() and variants support

Jonathan Schoonhoven added the comment: Is there anything I can do to help get this into the codebase and out issue purgatory? We're not that far off from the 10 year anniversary of this issue. -- nosy: +Jonathan Schoonhoven ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

Serhiy Storchaka added the comment: This looks like a nice feature. Éric, could you please create a PR on GitHub? I think that new l*gettext functions are not needed. They are rather useless in Python 3 (see issue29755). -- nosy: +serhiy.storchaka _

[issue2504] Add gettext.pgettext() and variants support

Changes by Éric Araujo : -- keywords: +needs review versions: +Python 3.7 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mail

[issue2504] Add gettext.pgettext() and variants support

Changes by Tristan Fisher : -- nosy: +Tristan.Fisher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue2504] Add gettext.pgettext() and variants support

Antti Haapala added the comment: *wow* isn't this in Python 3 yet (I've been using Zope translationstrings lately so I didn't know that pgettext is still not supported). -- nosy: +ztane ___ Python tracker _

[issue2504] Add gettext.pgettext() and variants support

Changes by Leonid Suprun : -- nosy: +Leonid Suprun ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue2504] Add gettext.pgettext() and variants support

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue2504] Add gettext.pgettext() and variants support

Hanno Zulla added the comment: Can we please get pgettext for Python? -- nosy: +Hanno.Zulla ___ Python tracker ___ ___ Python-bugs-list

[issue2504] Add gettext.pgettext() and variants support

Changes by Éric Araujo : -- stage: patch review -> needs patch versions: -Python 3.2, Python 3.3, Python 3.4, Python 3.6 ___ Python tracker ___ __

[issue2504] Add gettext.pgettext() and variants support

Wichert Akkerman added the comment: Bump. Python 3 is still not on my radar, but I'll happily do a backport for Py2 and drop that on PyPI once this gets resolved. -- versions: +Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

Neil Hooey added the comment: Can someone review the patch and consider its inclusion? -- nosy: +nhooey ___ Python tracker ___ ___ Pyth

[issue2504] Add gettext.pgettext() and variants support

Changes by Sascha Silbe : -- nosy: +sascha_silbe ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue2504] Add gettext.pgettext() and variants support

Changes by Étienne BERSAC : -- nosy: +Felix Schwarz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue2504] Add gettext.pgettext() and variants support

Changes by Étienne BERSAC : -- nosy: +bersace ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue2504] Add gettext.pgettext() and variants support

Changes by Étienne BERSAC : -- nosy: -Felix Schwarz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue2504] Add gettext.pgettext() and variants support

Changes by Felix Schwarz : -- nosy: +Felix Schwarz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue2504] Add gettext.pgettext() and variants support

Éric Araujo added the comment: New features don’t go into stable branches. The patch is also reviewable at http://codereview.appspot.com/3340041 -- ___ Python tracker ___ __

[issue2504] Add gettext.pgettext() and variants support

Wichert Akkerman added the comment: I can help test changes for python 2.x. The python 3.x ecosystem is at least a year away from becoming interesting for me I'm afraid. -- ___ Python tracker _

[issue2504] Add gettext.pgettext() and variants support

Éric Araujo added the comment: I have ported the patch to py3k, without tests errors but with test failures. What is left to do: 1) Carefully assess bytes/str issues. Decide to change the tests or the code. 2) Re-read over the new docs. 3) Exercise the updated msgfmt.py tool, which has no

[issue2504] Add gettext.pgettext() and variants support

Changes by Éric Araujo : -- resolution: -> accepted stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue2504] Add gettext.pgettext() and variants support

Changes by Nils Philippsen : -- nosy: +nils ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2504] Add gettext.pgettext() and variants support

Éric Araujo added the comment: The patch needs to be updated for the 3.x trunk (py3k branch), since the last 2.x version is already rc. Everyone, thanks for expressing interest for the development of Python, but posting “me too” messages does not further the discussion, and actually takes ti

[issue2504] Add gettext.pgettext() and variants support

Wichert Akkerman added the comment: Martin, is there anything we can do to help get this merged? I can really use this as well. My background here is that currently the complete zope i18n support abuses message ids as a workaround, and the result works but is very painful for translators sin

[issue2504] Add gettext.pgettext() and variants support

Wil Clouser added the comment: Yes. You can see an in-production implementation at http://github.com/clouserw/tower/blob/master/tower/__init__.py#L51 (I'm overriding ugettext to support an optional context). -- ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

Bernie H. Innocenti added the comment: While we're waiting for this patch to be upstreamed, what's the best way to emulate this functionality with the current gettext module? I'm looking at the patch and it seems that code similar to this might work? def pgettext(ctx, msg): return gett

[issue2504] Add gettext.pgettext() and variants support

Changes by Martin v. Löwis : -- versions: +Python 3.2 -Python 2.6, Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2504] Add gettext.pgettext() and variants support

Olivier Berten added the comment: Pleeese ;-) -- nosy: +olivier-berten ___ Python tracker ___ ___ Python-bugs-list mailing

[issue2504] Add gettext.pgettext() and variants support

David D Lowe added the comment: Same here. -- nosy: +Flimm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2504] Add gettext.pgettext() and variants support

Changes by Wil Clouser : -- nosy: +clouserw ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2504] Add gettext.pgettext() and variants support

Changes by Andrew Ziem : -- nosy: +AndrewZiem ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue2504] Add gettext.pgettext() and variants support

Changes by Christoph Zwerschke : -- nosy: +cito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2504] Add gettext.pgettext() and variants support

nh2 added the comment: Me too. This makes developing applications with good localizations in Python really difficult. -- nosy: +nh2 ___ Python tracker ___ ___

[issue2504] Add gettext.pgettext() and variants support

Mitar added the comment: I would just like to add that I am also looking forwards to this feature. -- nosy: +mitar ___ Python tracker ___

[issue2504] Add gettext.pgettext() and variants support

Martin v. Löwis added the comment: Only my lack of time prevents inclusion. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue2504] Add gettext.pgettext() and variants support

David Schnur added the comment: I came across this ticket while looking for alternatives to Python's gettext, since I need msgctx support. It seems a patch was supplied for this a while back. I have never contributed to Python, and am not familiar with your release process, but is there anythi

[issue2504] Add gettext.pgettext() and variants support

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue2504] Add gettext.pgettext() and variants support

Martin v. Löwis added the comment: The gettext module is intentionally written in pure Python; it should stay that way. Whether or not the _locale module should also grow support for pgettext is a different issue. ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

STINNER Victor added the comment: I don't see any change in Modules/_localemodule.c: you reimplemented pgettext() in pure Python. Why no reusing existing pgettext() function (at least when it's present)? -- nosy: +haypo ___ Python tracker

[issue2504] Add gettext.pgettext() and variants support

Changes by Dwayne Bailey : -- nosy: +dwayne ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2504] Add gettext.pgettext() and variants support

Changes by Torsten Bronger <[EMAIL PROTECTED]>: -- nosy: +bronger __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscrib

[issue2504] Add gettext.pgettext() and variants support

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- assignee: -> loewis __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Uns

[issue2504] Add gettext.pgettext() and variants support

Franz Glasner <[EMAIL PROTECTED]> added the comment: I have written a patch against the current Python trunk's gettext to add support for pgettext and friends (upgettext, npgettext, unpgettext, ...). I have also changed Tools/i18n/msgfmt.py to recognize the "msgctxt" keyword. Some new unittests

[issue2504] Add gettext.pgettext() and variants support

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Would you like to work on a patch? -- nosy: +loewis __ Tracker <[EMAIL PROTECTED]> __ ___

[issue2504] Add gettext.pgettext() and variants support

New submission from Pierre Metras <[EMAIL PROTECTED]>: Please add support for pgettext(msgctxt, msgid) and variants (dpgettext, dcpgettext...) in the gettext module. I will not rephrase the justification for these functions and why contexts are essential for good localization: http://www.gnu.org