[issue23326] Remove redundant __ne__ implementations

2015-03-30 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! On Mon, Mar 30, 2015 at 12:26 PM, Roundup Robot wrote: > > Roundup Robot added the comment: > > New changeset e881444f078f by Serhiy Storchaka in branch 'default': > Partially revert 3603bae63c13 (issue23326) for asyncio. > https://hg.python.org/cpyt

[issue23326] Remove redundant __ne__ implementations

2015-03-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset e881444f078f by Serhiy Storchaka in branch 'default': Partially revert 3603bae63c13 (issue23326) for asyncio. https://hg.python.org/cpython/rev/e881444f078f -- ___ Python tracker

[issue23326] Remove redundant __ne__ implementations

2015-03-30 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, I'd like to see it restored in asyncio. It seems to be just one file that's currently out of sync with the tulip "upstream" repo. On Mon, Mar 30, 2015 at 10:38 AM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > Should I restore __n

[issue23326] Remove redundant __ne__ implementations

2015-03-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Should I restore __ne__ in asyncio? The version without __ne__ will work with Python 3.4.3 because issue21408 patch was committed in 3.4 too. Explicit __ne__ implementation is just redundant. -- ___ Python tracker

[issue23326] Remove redundant __ne__ implementations

2015-03-30 Thread Guido van Rossum
Guido van Rossum added the comment: I'm a little surprised you didn't get pushback from asyncio (i.e. Victor). We try to keep the source identical across releases while asyncio is in provisional mode (i.e. until 3.5 is released). -- nosy: +gvanrossum, haypo ___

[issue23326] Remove redundant __ne__ implementations

2015-01-31 Thread Raymond Hettinger
Raymond Hettinger added the comment: Nice work. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue23326] Remove redundant __ne__ implementations

2015-01-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Martin and Georg for your reviews. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue23326] Remove redundant __ne__ implementations

2015-01-31 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3603bae63c13 by Serhiy Storchaka in branch 'default': Issue #23326: Removed __ne__ implementations. Since fixing default __ne__ https://hg.python.org/cpython/rev/3603bae63c13 -- nosy: +python-dev ___ Pyt

[issue23326] Remove redundant __ne__ implementations

2015-01-31 Thread Martin Panter
Martin Panter added the comment: I looked at all the instances of __ne__() identified in the patch, and they all seem redundant with the __eq__() implementations, so I think this patch is good. -- ___ Python tracker

[issue23326] Remove redundant __ne__ implementations

2015-01-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: As far as default __ne__ implementation delegates to __eq__, concrete __ne__ implementations are mostly redundant. They make sens when default __ne__ did not handle non-comparable types correctly, but now it is fixed. Proposed patch removes correct but red