[issue22054] Add os.get_blocking() and os.set_blocking() functions

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22054] Add os.get_blocking() and os.set_blocking() functions

Roundup Robot added the comment: New changeset 8f0b8ddbb66b by Victor Stinner in branch 'default': Issue #22054: Add os.get_blocking() and os.set_blocking() functions to get and http://hg.python.org/cpython/rev/8f0b8ddbb66b -- nosy: +python-dev ___ Py

[issue22054] Add os.get_blocking() and os.set_blocking() functions

STINNER Victor added the comment: Guido van Rossum told me that he's ok for "get": "I'd go with get, since that seems the tradition in the os module." -- ___ Python tracker ___

[issue22054] Add os.get_blocking() and os.set_blocking() functions

Charles-François Natali added the comment: I agree with Akira, although it's probably too late now to rename. -- ___ Python tracker ___ __

[issue22054] Add os.get_blocking() and os.set_blocking() functions

Akira Li added the comment: > os and socket modules already use getxxx() / setxxx() names: > > - os.get_inheritable() / os.set_inheritable() > - os.getuid() / os.setuid() > - os.getgroups() / os.setgroups() > - os.getxattr() os.setxattr() > - socket.gettimeout() / socket.settimeout() > - socket.g

[issue22054] Add os.get_blocking() and os.set_blocking() functions

STINNER Victor added the comment: > Maybe is_something() is a better name than get_something() > if something is a boolean? os and socket modules already use getxxx() / setxxx() names: - os.get_inheritable() / os.set_inheritable() - os.getuid() / os.setuid() - os.getgroups() / os.setgroups() -

[issue22054] Add os.get_blocking() and os.set_blocking() functions

Akira Li added the comment: Maybe is_something() is a better name than get_something() if something is a boolean? -- nosy: +akira ___ Python tracker ___ _

[issue22054] Add os.get_blocking() and os.set_blocking() functions

STINNER Victor added the comment: Can someone please review my patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue22054] Add os.get_blocking() and os.set_blocking() functions

STINNER Victor added the comment: Oops, test_asyncio was failing. Fixed patched. -- Added file: http://bugs.python.org/file36053/os_blocking-2.patch ___ Python tracker ___ __

[issue22054] Add os.get_blocking() and os.set_blocking() functions

New submission from STINNER Victor: Antoine suggested me to add these functions in the issue #22042. Here is a patch to implement these functions and use them in various places. -- files: os_blocking.patch keywords: patch messages: 223782 nosy: haypo, neologix, pitrou priority: normal s