[issue20530] Change the text signature format (again) to be more robust

Larry Hastings added the comment: Actually this is the wrong issue for that observation. You want the issue where yselivanov added emitting the "/" to pydoc. -- ___ Python tracker

[issue20530] Change the text signature format (again) to be more robust

Jesús Cea Avión added the comment: Preparing a presentation about Python Magic methods I found something weird: (Python 3.4) """ >>> help(int.__lt__) Help on wrapper_descriptor: __lt__(self, value, /) <- THIS!! Return self __

[issue20530] Change the text signature format (again) to be more robust

Roundup Robot added the comment: New changeset 28aef6e22736 by Larry Hastings in branch 'default': Issue #20530: The signatures for slot builtins have been updated http://hg.python.org/cpython/rev/28aef6e22736 -- ___ Python tracker

[issue20530] Change the text signature format (again) to be more robust

Larry Hastings added the comment: I made a couple final tweaks to what was essentially Nick's patch: * Argument Clinic wraps parameters in the signature at 72 columns instead of 79 columns. There are a couple extra characters that get emitted, so this ensures that the generated lines are ne

[issue20530] Change the text signature format (again) to be more robust

Roundup Robot added the comment: New changeset 29d9638bf449 by Larry Hastings in branch 'default': Issue #20530: Argument Clinic's signature format has been revised again. http://hg.python.org/cpython/rev/29d9638bf449 -- nosy: +python-dev ___ Python t

[issue20530] Change the text signature format (again) to be more robust

Larry Hastings added the comment: Nick: I made the same fix on the plane, except I also added an assert that end - start >= 2. ;-) I'm going to go through everyone's feedback, and if there are any significant changes I'll post a new patch, otherwise I think this patch is basically ready. ---

[issue20530] Change the text signature format (again) to be more robust

Nick Coghlan added the comment: Updated patch fixes an assertion failure in typeobject.c (end doesn't point at the ")", it points at the newline immediately after it). -- Added file: http://bugs.python.org/file34003/issue20530_fixed_assertion.diff __

[issue20530] Change the text signature format (again) to be more robust

Yury Selivanov added the comment: One more patch (v4) I fixed the commented out 'ThisWorksNow' test. And also 'inspect.signature' now raises a bit more coherent exception for that particular case. -- Added file: http://bugs.python.org/file33966/larry.even.newerer.signature.syntax.4.dif

[issue20530] Change the text signature format (again) to be more robust

Yury Selivanov added the comment: Larry, I'm attaching a revised version of the patch -- larry.even.newerer.signature.syntax.3.diff. Changes: 1. test_signature_on_class_without_init was fixed, inspect.signature was fixed as well. Now, for class Meta(type): pass "inspect.signature(Meta)"

[issue20530] Change the text signature format (again) to be more robust

Zachary Ware added the comment: New patch still gives an assertion failure at line 153 of typeobject.c when trying to get __text_signature__ from anything that should have one (on Windows, at least). Python 3.4.0b3+ (default, Feb 7 2014, 11:43:04) [MSC v.1600 32 bit (Intel)] on win32 Type "h

[issue20530] Change the text signature format (again) to be more robust

Larry Hastings added the comment: Thanks for noticing the "(/)", that's fixed. Yes, the signature for type() was wrong. type() can accept either one parameter or three parameters--in other words, it uses optional groups. And we can't represent optional groups in an inspect.Signature signatur

[issue20530] Change the text signature format (again) to be more robust

Yury Selivanov added the comment: > Whoops, forgot to fix all the breakage in clinic_test.py. It's good now. Ah, you re-uploaded the patch and reset my code review comments. I'll repeat them here, just in case. Reviewed the patch. - In one of the C files I saw this signature: "(/)" -- probabl

[issue20530] Change the text signature format (again) to be more robust

Changes by Larry Hastings : Removed file: http://bugs.python.org/file33941/larry.even.newerer.signature.syntax.1.diff ___ Python tracker ___

[issue20530] Change the text signature format (again) to be more robust

Larry Hastings added the comment: Whoops, forgot to fix all the breakage in clinic_test.py. It's good now. -- Added file: http://bugs.python.org/file33942/larry.even.newerer.signature.syntax.1.diff ___ Python tracker

[issue20530] Change the text signature format (again) to be more robust

New submission from Larry Hastings: Following a new discussion of the format of the text signature, I decided to go with this: (...)\n--\n\n See here for the discussion: https://mail.python.org/pipermail/python-dev/2014-February/132271.html Patch attached implementing this approach. Ca