Yury Selivanov added the comment: > Whoops, forgot to fix all the breakage in clinic_test.py. It's good now. Ah, you re-uploaded the patch and reset my code review comments. I'll repeat them here, just in case.
Reviewed the patch. - In one of the C files I saw this signature: "(/)" -- probably should be just "()" - signature for 'type' builtin was '(object_or_name, bases, dict)', which is a correct signature (minus the groups/optional parameters). In this patch it's a ValueError. Can we restore the prior behaviour? If not, then test_signature_on_class_without_init is incorrect now, as it should throw a ValueError for metaclasses. - and some other minor stuff ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20530> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
