[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Steve, please close this issue when you've confirmed it's now building correctly on Windows. -- ___ Python tracker ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Roundup Robot added the comment: New changeset 7a76c462c7f6 by Larry Hastings in branch 'default': Fix Windows build breakage from checkins on Issues #20148 and #20168. https://hg.python.org/cpython/rev/7a76c462c7f6 -- ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: Sorry, wasn't watching the other issue. :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: (sorry, 6.9.2.3) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: I agree. I looked it up in the C99 standard. 6.9.2.2 says: "If the declaration of an identifier for an object is a tentative definition and has internal linkage, the declared type shall not be an incomplete type." And if you'd hurry up and bless my patch for

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: According to http://compgroups.net/comp.std.c/why-does-the-standard-prohibit-static-int-a/2569729, it's invalid in both C89 and C99, but some compilers accept it as an extension. IMO we should avoid relying on compiler extensions, at least in the code files that

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: It fails on VC10, 11, 12 and 14, so I doubt it's going to be changed. That said, it looks like the non-static forward definition may be some sort of extension, since it causes a redefinition error (mismatched storage class) on all versions when using /Za to disab

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Then the patch LGTM. It is easier to make these changes by hand than make a review for moved code on Rietveld. I'm not sure, but may be forward static declarations of arrays of unspecified size is C99-ism? -- ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Oh, this is only happening on the *beta* compiler? In that case, I genuinely suggest you file a bug. We can still check in the workaround, but I really do think MSVS's behavior is wrong here. (Why is it only for forward static declarations of arrays of unsp

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: AFAIK the only buildbot with a nearly-up-to-date MSVC is still marked as unstable (http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x). I keep meaning to get it promoted, but haven't quite gotten around to it yet... -- ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Yes, it moves the type declaration to the bottom of the file, and adds forward static declarations for the types to the top of the file. -- ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Does your patch just move type definition to the end of the file? I think this is only the way to make happy GCC and MS compiler. Strange that no IRC bot complained about compilation failure. -- ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Sorry--you can simply remove that line, it's no longer needed. -- ___ Python tracker ___ ___ Python-

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: But looks like it's unnecessary and just wasn't removed in the patch. Everything builds fine without it -- ___ Python tracker ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: This line (1429 before patch, 1433 after patch) is still being troublesome: static PyMethodDef pattern_methods[]; -- ___ Python tracker ___ __

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Steve, does this patch fix the build for Windows? By all rights it oughta. -- Added file: http://bugs.python.org/file39281/larry.fix.sre.build.on.windows.diff.1.txt ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Removing "static" breaks GCC on Linux (gcc 4.9.2 on Ubuntu 15.04 x86-64): ./Modules/_sre.c:2780:20: error: static declaration of ‘pattern_methods’ follows non-static declaration static PyMethodDef pattern_methods[] = { ^ ./Modules/_sre.c:14

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Steve Dower added the comment: This broke Windows builds because of unnecessary "static" qualifiers on the forward declarations at lines 1429, 2472 and 2715 (as discussed on #20323). Removing "static" from these lines fixes the build. -- nosy: +steve.dower

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Steve Dower : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Roundup Robot added the comment: New changeset d5f78a855355 by Serhiy Storchaka in branch 'default': Issue #20148: Converted the _sre module to Argument Clinic. https://hg.python.org/cpython/rev/d5f78a855355 -- nosy: +python-dev ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Updated to the tip. -- Added file: http://bugs.python.org/file39092/sre_clinic_5.patch ___ Python tracker ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : -- components: +Argument Clinic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Synchronized with the tip again. -- Added file: http://bugs.python.org/file37335/sre_clinic_4.patch ___ Python tracker ___ ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file35438/sre_clinic_3.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Here is updated patch. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file34529/sre_clinic_2.patch ___ Python tracker ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : -- dependencies: +Wrong keyword parameter name in regex pattern methods ___ Python tracker ___ ___ Pytho

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Now all methods except Match.group() (which needs *args) use Argument Clinic. Most important change is that first parameters of some Pattern methods are renamed from "pattern" or "source" to "string". This was obvious bug (issue20283). "string" conforms to t

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33353/sre_clinic.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33329/sre_clinic.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Serhiy: Assigning to you because you wrote a patch; if you don't want the issue, sorry, please undo it. -- assignee: -> serhiy.storchaka ___ Python tracker __

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Serhiy Storchaka added the comment: Here is refreshed patch. -- Added file: http://bugs.python.org/file33353/sre_clinic.patch ___ Python tracker ___ _

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Can you refresh the patch? I think all the problems you cited are fixed, and also the comments Argument Clinic uses were all changed. I'll review when you have a fresh patch. -- title: Convert the _sre module to use Argument Clinic -> Derby: Convert