[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: Fair enough. :) I may keep a couple of those changes in mind if I ever have a chance to visit this module myself in the future. -- ___ Python tracker

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Oh, I see. I did get the email, it's just that my email filter put it into a different folder from what I was expected. -- ___ Python tracker ___

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Yeah, you make some good points, but I think I may already have spent more time on this that is justified by the amount of usage webbrowser gets :) So I think I'm going to leave it as is, as being 'good enough'. -- __

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: Thanks, David. I wasn't sure if you had seen the comments. They're mostly stylistic, though, so it's not too big of a deal. -- ___ Python tracker ___

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Hmm. For some reason I did not get emailed these review comments, and I did not see your note before I did the checkin. I will take a look. -- ___ Python tracker __

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Thanks, Anton. And thank you Chris for the initial reviews. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker _

[issue15557] Tests for webbrowser module

Roundup Robot added the comment: New changeset 5da3b2df38b3 by R David Murray in branch 'default': #15557,#15447,#15509: webbrowser test suite added. http://hg.python.org/cpython/rev/5da3b2df38b3 -- nosy: +python-dev ___ Python tracker

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: I added some comments on the latest patch on the review tool. -- ___ Python tracker ___ ___ Python-b

[issue15557] Tests for webbrowser module

R. David Murray added the comment: I did indeed. -- Added file: http://bugs.python.org/file27110/test_webbrowser.patch ___ Python tracker ___

[issue15557] Tests for webbrowser module

Anton Barkovsky added the comment: I think you forgot to write `test_open_with_autoraise_false` for Chrome tests. -- ___ Python tracker ___ __

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Thanks, Anton. I took your last patch just a bit further, mostly to make it easy to break up the test methods that test multiple things into test methods that test just one thing. I also made the test insensitive to the order of the options on the command l

[issue15557] Tests for webbrowser module

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: Thanks, Anton. It is looking a lot better now. I still have comments, but because my comments have not been on the substance of the patch and because I am not a core developer, I will defer to others at this point. -- ___

[issue15557] Tests for webbrowser module

Anton Barkovsky added the comment: Updated, added separate helper methods and 'test' and 'http://www.example.com/' are no longer hardcoded. > The helper methods could default to the most common string arguments so that > you will only need to define and pass the string arguments when the brows

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: It still seems like things could be made more DRY. Also, the pattern of having assert_unix_browser() execute various function blocks depending on whether various arguments are not None doesn't seem as clean or scalable as it should be (e.g. if the number of a

[issue15557] Tests for webbrowser module

Anton Barkovsky added the comment: Thanks for the review, I've updated the patch. -- Added file: http://bugs.python.org/file26774/test_webbrowser_v2.patch ___ Python tracker ___

[issue15557] Tests for webbrowser module

R. David Murray added the comment: Regrtest has evolved. For new test files (ie: 3.3 and later) the preferred (at least by me :) idiom now is just: if __name__ == '__main__': unittest.main() Everything else is now automatic, using the unittest machinery. For an example, see test_s

[issue15557] Tests for webbrowser module

Chris Jerdonek added the comment: It seems like these tests can be made more DRY. For example, the line `args = popen.cmd_line` appears in every test. You could make an assert_args() helper method to address this. There also seems to be a lot of overlap between tests for each browser. A DR

[issue15557] Tests for webbrowser module

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue15557] Tests for webbrowser module

Changes by Andrew Svetlov : -- dependencies: +A file is not properly closed by webbrowser._invoke, webbrowser.open sometimes passes zero-length argument to the browser. versions: +Python 3.4 -Python 3.3 ___ Python tracker

[issue15557] Tests for webbrowser module

New submission from Anton Barkovsky: Attaching a patch with some tests for webbrowser module. The tests fail unless #15509 is fixed. They also print lots of warnings unless #15447 is fixed. -- components: Tests files: test_webbrowser.patch keywords: patch messages: 167423 nosy: anton.ba