[issue12296] Minor clarification in devguide

Ezio Melotti added the comment: Fixed, thanks for the patches! -- assignee: eric.araujo -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -3rd party ___ Python tracker

[issue12296] Minor clarification in devguide

Roundup Robot added the comment: New changeset 4ce6bfb27267 by Ezio Melotti in branch 'default': #12296: clarify paragraph about backward-compatibility. Patch by Moritz Neeb, Jyrki Pulliainen, and Éric Araujo. http://hg.python.org/devguide/rev/4ce6bfb27267 -- nosy: +python-dev ___

[issue12296] Minor clarification in devguide

Moritz Neeb added the comment: Tried to summarize the previous discussion and generate a compromise here. Patch attached. -- nosy: +zormit Added file: http://bugs.python.org/file33757/devguide-patch.diff ___ Python tracker

[issue12296] Minor clarification in devguide

Changes by Ezio Melotti : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue12296] Minor clarification in devguide

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue12296] Minor clarification in devguide

Ezio Melotti added the comment: PEP 387 explains the rules about backward compatibility. The paragraph could just link to that. -- ___ Python tracker ___ _

[issue12296] Minor clarification in devguide

Ezio Melotti added the comment: That's a bit heavy in my opinion. I don't think it's necessary to define in detail what "backward-compatibile" means, it's probably enough to say that whatever code might be running before the patch should keep running fine even after. Bug fixes can change th

[issue12296] Minor clarification in devguide

Terry J. Reedy added the comment: Ezio's comment got me to reread the entire paragraph. I do not like it. 'Having you think' is wrong; 'Basically just' is unneeded; 'guaranteed' is hyperbole; and the paragraph is otherwise repetitive, vague, and pretty useless. For most issues "the core devel

[issue12296] Minor clarification in devguide

Éric Araujo added the comment: This is the wording I committed: (This obviously does not apply to new classes or functions; new arguments should be optional and have default values which maintain the existing behavior.) Should I push or should I delete the changeset? -- ___

[issue12296] Minor clarification in devguide

Ezio Melotti added the comment: I don't think we need to mention that. Actually the tone of the whole paragraph could be relaxed a bit, because it first says that "any change **will** break code" (which is not true), except "new semantic, obviously" (which is not true either). The whole sen

[issue12296] Minor clarification in devguide

Terry J. Reedy added the comment: To be more exact, "optional arguments" should be more extended to "optional arguments whose default maintains the existing behavior" -- ___ Python tracker ___

[issue12296] Minor clarification in devguide

Ezio Melotti added the comment: LGTM. (Actually you can still break someone's code by introducing new functions/classes, in case they get imported with 'from mod import *' and override some local function/class with the same name -- but this is such an obscure case that doesn't deserve to be

[issue12296] Minor clarification in devguide

Éric Araujo added the comment: I like it. Terry, objections? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue12296] Minor clarification in devguide

Jyrki Pulliainen added the comment: Updated the existing patch with the new wording -- nosy: +Jyrki.Pulliainen Added file: http://bugs.python.org/file23437/clarify-bwcompat-devguide_v2.diff ___ Python tracker

[issue12296] Minor clarification in devguide

Éric Araujo added the comment: Okay for a new sentence. I think repeating new is clearer: (This obviously does not apply to new classes or functions, or new optional arguments.) -- ___ Python tracker __

[issue12296] Minor clarification in devguide

Terry J. Reedy added the comment: The parenthetical comment is a complete sentence, and no longer trivial. I would separate it and write it more simply as "... their code. (This obviously does not apply to new classes, functions, or optional arguments.)" -- nosy: +terry.reedy ___

[issue12296] Minor clarification in devguide

Éric Araujo added the comment: Good idea. So, any -1 on this: (this obviously does not apply to new classes or functions, or new optional arguments) -- ___ Python tracker ___

[issue12296] Minor clarification in devguide

Sandro Tosi added the comment: (this obviously does not apply to new classes, functions or *optional* arguments) ? -- nosy: +sandro.tosi ___ Python tracker ___

[issue12296] Minor clarification in devguide

Éric Araujo added the comment: What about this: (this obviously does not apply to new classes, functions or arguments) -- ___ Python tracker ___ ___

[issue12296] Minor clarification in devguide

Petri Lehtinen added the comment: New semantics may also be something else than new classes or functions. New optional function arguments exposing new functionality, for example. -- nosy: +petri.lehtinen ___ Python tracker

[issue12296] Minor clarification in devguide

New submission from Éric Araujo : I found the wording of one line of the devguide strange and changed it IMO for the better. Please review. -- assignee: eric.araujo components: Devguide files: clarify-bwcompat-devguide.diff keywords: needs review, patch messages: 137994 nosy: eric.arau