[issue11302] Add more tests to test_ast.py

Roundup Robot added the comment: New changeset 3143cadb2f2d by Benjamin Peterson in branch '2.7': add more ast tests (closes #11302) http://hg.python.org/cpython/rev/3143cadb2f2d New changeset e8d47cbe9b6f by Benjamin Peterson in branch '3.2': add more ast tests (closes #11302) http://hg.python

[issue11302] Add more tests to test_ast.py

Vincent Legoll added the comment: * removed the comments for exc msgs * added explanation to multiline statements * added 2 tests to test_AST_objects() Regarding Éric's comment, I'm starting to wonder if those Exception tests should be added to cpython's testsuite. Maybe that would only be ben

[issue11302] Add more tests to test_ast.py

Benjamin Peterson added the comment: 2011/6/27 Vincent Legoll : > > Vincent Legoll added the comment: > > I was testing exact matches on the strings because I think pypy wants to be > as compliant as possible with cpython, and IMHO that include exception msgs > as far as possible. I don't see

[issue11302] Add more tests to test_ast.py

Éric Araujo added the comment: > I think pypy wants to be as compliant as possible with cpython, and > IMHO that include exception msgs as far as possible. I don't see any > reason to be different just for the sake of it. > > As a user I'd find strange not to get same exc msgs from different > i

[issue11302] Add more tests to test_ast.py

Vincent Legoll added the comment: I was testing exact matches on the strings because I think pypy wants to be as compliant as possible with cpython, and IMHO that include exception msgs as far as possible. I don't see any reason to be different just for the sake of it. As a user I'd find stra

[issue11302] Add more tests to test_ast.py

Benjamin Peterson added the comment: You still haven't explained why including multiline literals is a good idea. Also, the reason we avoid matching exact messages is it can vary across implementations. You can still do an accurate test with something like self.assertIn("foobar", str(e)) ---

[issue11302] Add more tests to test_ast.py

Vincent Legoll added the comment: Here we are, I left the exact messages for raised exceptions as comments so they can easily be checked in case of test failure... Does that look OK ? -- Added file: http://bugs.python.org/file22495/add-more-tests-for-ast_py-2.patch __

[issue11302] Add more tests to test_ast.py

Vincent Legoll added the comment: OK I'll look at it and respin with the comments in mind -- ___ Python tracker ___ ___ Python-bugs-l

[issue11302] Add more tests to test_ast.py

Sandro Tosi added the comment: Hi Benjamin, we know have rietveld directly integrated in the tracker, so it might be time to add you comments? If you still can remember them, given it passed some time :) -- nosy: +sandro.tosi stage: -> patch review __

[issue11302] Add more tests to test_ast.py

Benjamin Peterson added the comment: Please upload to Rietveld. I have a few comments to make. -- nosy: +benjamin.peterson ___ Python tracker ___ ___

[issue11302] Add more tests to test_ast.py

New submission from Vincent Legoll : While working to improve pypy's compliance with cpython2.7 I added more tests to the ast module test suite. They may be of interest here too... -- components: Tests files: add-more-tests-for-ast_py.patch keywords: patch messages: 129225 nosy: vincele