Vincent Legoll <vincent.leg...@gmail.com> added the comment:

I was testing exact matches on the strings because I think pypy wants to be as 
compliant as possible with cpython, and IMHO that include exception msgs as far 
as possible. I don't see any reason to be different just for the sake of it.

As a user I'd find strange not to get same exc msgs from different 
implementations, and it'll make me loose some time digging why those difference 
exist...

Back to the patch:

The multiline (and also differing offsets) are there for testing .lineno & 
.col_offset AST node's attributes. (there was a bug in pypy's implementation of 
those back then...)

Do you want that explained in the comment ?

Do you want me to add "self.assertIn("foobar", str(e))" in the tests, remove 
the comments or let them as in the patch #2 ?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11302>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to