[issue47158] logging.handlers.SysLogHandler doesn't get cleaned up properly on exit if it throws an exception

2022-03-31 Thread Vinay Sajip
Vinay Sajip added the comment: The 3.8 branch is security-fix-only now, I'm afraid. And I'm not sure it's worth backporting this. -- versions: -Python 3.8 ___ Python tracker <https://bugs.pyt

[issue45171] stacklevel handling in logging module is inconsistent

2022-03-27 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset c12ba6b2ff7908c8970b978f149d51ecd3fb195c by Jouke Witteveen in branch 'main': bpo-45171: Remove tests of deprecated logger.warn(). (GH-32139) https://github.com/python/cpython/commit/c12ba6b2ff7908c8970b978f149d51

[issue45171] stacklevel handling in logging module is inconsistent

2022-03-27 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 5ca6d7469be53960843df39bb900e9c3359f127f by Jouke Witteveen in branch 'main': bpo-45171: Fix stacklevel handling in logging. (GH-28287) https://github.com/python/cpython/commit/5ca6d7469be53960843df39bb900e9c3359f127f -

[issue46557] Logging captured warnings with a format string unnecessarily groups warnings together

2022-03-15 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset d8066b420b888591f485d132e62979d07abfc3f4 by Michael P. Nitowski in branch 'main': bpo-46557: Log captured warnings without format string (GH-30975) https://github.com/python/cpython/commit/d8066b420b888591f485d132e62979d07abfc3f4 -

[issue46914] On Osx Monterey(12.x), Logging.handlers.SysLogHandler does not work

2022-03-03 Thread Vinay Sajip
Vinay Sajip added the comment: > If so, then it probably good to adjust ... since it still talks about it > being expected. Do you mean just adding a note to the effect that SysLogHandler won't work on macOS 12.2 because of changes to the syslog daemon on that platform? IIR

[issue46557] Logging captured warnings with a format string unnecessarily groups warnings together

2022-01-28 Thread Vinay Sajip
Change by Vinay Sajip : -- type: behavior -> enhancement versions: -Python 3.10, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issu

[issue41906] logging.config.dictConfig does not work with callable filters

2022-01-24 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.10 ___ Python tracker <https://bugs.python.or

[issue41906] logging.config.dictConfig does not work with callable filters

2022-01-20 Thread Vinay Sajip
Vinay Sajip added the comment: > If you have any preference about the implementation or any pointer Nothing particular, just try to fit in with the existing code conventions even where they don't follow modern idioms (e.g. a lot of the code in this package predates PEP 8 and new s

[issue41906] logging.config.dictConfig does not work with callable filters

2022-01-19 Thread Vinay Sajip
Vinay Sajip added the comment: > Vinay would you consider a patch for logging where dictConfig allows taking > objects directly in addition to the reference id? Sorry I didn't respond to this; it dropped off my radar. Certainly, I would consider s

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

2022-01-14 Thread Vinay Sajip
Vinay Sajip added the comment: Unfortunately, you can't rely on people always doing "the sensible thing", for any number of good reasons. If a particular set of parameter values didn't cause failure, it is probably used somewhere. Anyway, your problem goes away if inte

[issue46377] TimedRotatingFileHandler "midnight" misleading when interval > 1

2022-01-14 Thread Vinay Sajip
Vinay Sajip added the comment: Making a change without considering backward compatibility is premature. I've closed the PR as there appears to be something wrong with it - it references hundreds of changed files. Did you look at the 'atTime' keyword parameter of TimedRota

[issue42378] logging reopens file with same mode, possibly truncating

2022-01-07 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset e35430bec528dfb1a653cd457ea58b5a08543632 by Miss Islington (bot) in branch '3.10': [3.10] bpo-42378: fixed log truncation on logging shutdown (GH-27310) (GH-30468) https://github.com/python/cpython/commit/e35430bec528dfb1a653cd457ea58b

[issue42378] logging reopens file with same mode, possibly truncating

2022-01-07 Thread Vinay Sajip
Vinay Sajip added the comment: I guess it got missed during the 3.10 beta cycle by not being backported - it might have needed to be cherry-picked. I'll see about getting it backported to 3.10. -- ___ Python tracker <https://bugs.py

[issue46292] Add microseconds to logging.LogRecord

2022-01-07 Thread Vinay Sajip
Vinay Sajip added the comment: Thanks for the patch. We're need to get contributors to sign a Contributor License Agreement (CLA) before we can accept their patches. Would you be willing to do this? The process could be smoother, but it's not too bad, and here's where

[issue46292] Add microseconds to logging.LogRecord

2022-01-07 Thread Vinay Sajip
Change by Vinay Sajip : -- versions: +Python 3.11 ___ Python tracker <https://bugs.python.org/issue46292> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41011] [venv] record which executable and command were used to create a virtual environment

2022-01-06 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset f4e325c21d6d9c2bf70224dc69d707b226f87872 by andrei kulakov in branch 'main': bpo-41011: venv -- add more variables to pyvenv.cfg (GH-30382) https://github.com/python/cpython/commit/f4e325c21d6d9c2bf70224dc69d707

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-06 Thread Vinay Sajip
Vinay Sajip added the comment: I'm closing with the assumption that the addition to the documentation covers this. If that needs to be improved, this can be reopened with specific suggestions. -- resolution: -> fixed stage: patch review -> resolved status: ope

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-06 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 188fbdee0d6721a948eabb81cdcacac371614793 by Miss Islington (bot) in branch '3.9': [3.9] bpo-46251: Add 'Security Considerations' section to logging configura… (GH-30411) (GH-30448) https://github.com/p

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-06 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset db60ed1170a02189a4fd4b7574e0722dd22c658b by Miss Islington (bot) in branch '3.10': [3.10] bpo-46251: Add 'Security Considerations' section to logging configura… (GH-30411) (GH-30447) https://github.com/p

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-06 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 46c7a6566bca2e974a89c90c35ed1c498d9d3b02 by Vinay Sajip in branch 'main': bpo-46251: Add 'Security Considerations' section to logging configura… (GH-30411) https://github.com/python/cpython/commit/46c7a6566bca2e974a89

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-05 Thread Vinay Sajip
Vinay Sajip added the comment: I've created a PR to add a "Security Considerations" section in the configuration documentation. Comments on the PR are welcome. -- stage: patch review -> ___ Python tracker <https://bugs.

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-05 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +28617 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30411 ___ Python tracker <https://bugs.python.org/issu

[issue46251] logger.config.configure_formatter executes arbitrary code

2022-01-04 Thread Vinay Sajip
Vinay Sajip added the comment: > "Dont load untrusted config files" is the answer I expected. Yes. It's the usual convenience vs. security trade-off. To make configuration convenient, configurable factories with configurable parameters are provided. Can this be misused? O

[issue46200] Discourage logging f-strings due to security considerations

2021-12-31 Thread Vinay Sajip
Vinay Sajip added the comment: Another (minor) point against using f-strings or .format is that formatting prematurely might be doing unnecessary work - by default, logging formats messages lazily, waiting until a message actually needs to be output. This could perhaps be more prominently

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 17260e44b5ed3508e3c15f1b7ded761879e91d3e by Miss Islington (bot) in branch '3.9': [3.9] bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) (GH-30105) https://github.com/p

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 908fd691f96403a3c30d85c17dd74ed1f26a60fd by Miss Islington (bot) in branch '3.10': [3.10] bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) (GH-30104) https://github.com/p

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 850aefc2c651110a784cd5478af9774b1f6287a3 by Vinay Sajip in branch 'main': bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) https://github.com/python/cpython/commit/850aefc2c651110a784c

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Change by Vinay Sajip : -- pull_requests: +28326 pull_request: https://github.com/python/cpython/pull/30103 ___ Python tracker <https://bugs.python.org/issue46

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Vinay Sajip added the comment: Ah ... forgot to set delay=True for the handlers. Will look at this soon. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46028] 3.11.0a3: sys._base_executable is wrong, breaks venv - it wasn't under 3.11.0a2

2021-12-14 Thread Vinay Sajip
Change by Vinay Sajip : -- title: 3.11.0a3: under tox, sys._base_executable is wrong -> 3.11.0a3: sys._base_executable is wrong, breaks venv - it wasn't under 3.11.0a2 ___ Python tracker <https://bugs.python.org

[issue23010] "unclosed file" warning when defining unused logging FileHandler in dictConfig

2021-12-14 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue23010> ___ ___

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-14 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-13 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 94234228abbb84945a48049a7515dea960bc9834 by Miss Islington (bot) in branch '3.9': [3.9] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30095) https://github.com/python/cpyt

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-13 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset f84e2f6c0aca97c59ec8ce21715ae9bd89893307 by Miss Islington (bot) in branch '3.10': [3.10] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30094) https://github.com/python/cpyt

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-13 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset cb589d1b6bad4b75852c2e2a471a3800d5efdca7 by Vinay Sajip in branch 'main': bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) https://github.com/python/cpython/commit/cb589d1b6bad4b75852c2e2a471a38

[issue46028] 3.11.0a3: under tox, sys._base_executable is wrong

2021-12-13 Thread Vinay Sajip
Vinay Sajip added the comment: > This is the intended behaviour, and yes it's changed from previous versions > ... The previous value was incorrect, hence it was marked as an internal > field. But the value as it's calculated now seems to give a file that doesn't

[issue46063] TimedRotatingFileHandler deletes wrong files

2021-12-13 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +28316 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30093 ___ Python tracker <https://bugs.python.org/issu

[issue43749] venv module does not copy the correct python exe

2021-12-10 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset bad16f0cf71a6b11ef62f86be6b3d3567cd70a16 by Miss Islington (bot) in branch '3.9': [3.9] bpo-43749: Ensure current exe is copied when using venv on windows (GH-25216) (GH-30033) https://github.com/python/cpyt

[issue43749] venv module does not copy the correct python exe

2021-12-10 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset bb8d645f3a09645686cf8f66bd46dcfa4efac713 by Miss Islington (bot) in branch '3.10': [3.10] bpo-43749: Ensure current exe is copied when using venv on windows (GH-25216) (GH-30034) https://github.com/python/cpyt

[issue43749] venv module does not copy the correct python exe

2021-12-10 Thread Vinay Sajip
Vinay Sajip added the comment: *3.8, I meant. -- ___ Python tracker <https://bugs.python.org/issue43749> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43749] venv module does not copy the correct python exe

2021-12-10 Thread Vinay Sajip
Vinay Sajip added the comment: 3.10 and 3.9 - OK, but 3. is security fixes only, I'm afraid. -- ___ Python tracker <https://bugs.python.org/issue43749> ___ ___

[issue35821] Clarify when logging events are propagated when propagate is true

2021-12-07 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35821] Clarify when logging events are propagated when propagate is true

2021-12-07 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset e688568cdfe758a2316ecaf0c8df868d5dde0d83 by Miss Islington (bot) in branch '3.9': [3.9] bpo-35821: Add an example to Logger.propagate documentation. (GH-29841) (GH-29958) https://github.com/python/cpyt

[issue35821] Clarify when logging events are propagated when propagate is true

2021-12-07 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset f78c229b4ec8621a9b15c6396b6c91518e8975d6 by Miss Islington (bot) in branch '3.10': [3.10] bpo-35821: Add an example to Logger.propagate documentation. (GH-29841) (GH-29957) https://github.com/python/cpyt

[issue35821] Clarify when logging events are propagated when propagate is true

2021-12-07 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 2bf551757e0a7e3cc6ce2ebed2178b82438ac6b5 by Vinay Sajip in branch 'main': bpo-35821: Add an example to Logger.propagate documentation. (GH-29841) https://github.com/python/cpython/commit/2bf551757e0a7e3cc6ce2ebed2178b

[issue44391] PC/launcher.c,one more argument than required

2021-11-29 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker <https://bugs.python.or

[issue44391] PC/launcher.c,one more argument than required

2021-11-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset af39cfa6ca1e5dc4e5d28c1f09a875a14354e4ae by Miss Islington (bot) in branch '3.10': [3.10] bpo-44391: Remove unused argument from a varargs call. (GH-29843) (GH-29849) https://github.com/python/cpyt

[issue44391] PC/launcher.c,one more argument than required

2021-11-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 40a57532a5ad5dfd81ab6c72c5fb2e2dc4509199 by Miss Islington (bot) in branch '3.9': [3.9] bpo-44391: Remove unused argument from a varargs call. (GH-29843) (GH-29850) https://github.com/python/cpython/commit/40a57532a5ad5dfd81ab6c72c5fb2e

[issue44391] PC/launcher.c,one more argument than required

2021-11-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 4141d94fa608cdf5c8cd3e62f7ea1c27fd41eb8d by Vinay Sajip in branch 'main': bpo-44391: Remove unused argument from a varargs call. (GH-29843) https://github.com/python/cpython/commit/4141d94fa608cdf5c8cd3e62f7ea1c

[issue44391] PC/launcher.c,one more argument than required

2021-11-29 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +28072 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29843 ___ Python tracker <https://bugs.python.org/issu

[issue35821] Clarify when logging events are propagated when propagate is true

2021-11-29 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +28070 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29841 ___ Python tracker <https://bugs.python.org/issu

[issue28499] Logging module documentation needs a rework.

2021-11-28 Thread Vinay Sajip
Vinay Sajip added the comment: Closing, as no objections raised. -- resolution: -> not a bug stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue23010] "unclosed file" warning when defining unused logging FileHandler in dictConfig

2021-11-27 Thread Vinay Sajip
Vinay Sajip added the comment: This had dropped off my radar completely, but I still can't see where there's an actual bug here. This simplified script: import logging import sys LOGGING = { 'version': 1, 'handlers': { 'logf

[issue45682] Nicer default logging format

2021-10-31 Thread Vinay Sajip
Vinay Sajip added the comment: > They too could pass a format argument themselves rather then relying on the > default format never changing. Changes to the stdlib shouldn't require changing previously working code (sometimes months or years old) to fix breakage caused by new std

[issue45682] Nicer default logging format

2021-10-31 Thread Vinay Sajip
Vinay Sajip added the comment: > However in the case of logging, an argument could be made that changing the > default would have less impact. Except that people may have used the current basic format in, for example, unit tests, and that code could break after a change like t

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Vinay Sajip added the comment: It's possible this crept in during the fix for bpo-44753. -- ___ Python tracker <https://bugs.python.org/issue45628> ___ ___

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Vinay Sajip added the comment: N.B. I was able to reproduce this on recent 3.9 versions as well. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 191a93905a84f272b2232701dc5dcc69987330f5 by Miss Islington (bot) in branch '3.10': [3.10] bpo-45628: Check all parts of the suffix for an extension match. (GH-29310) (GH-29314) https://github.com/python/cpyt

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 317e0c99e3804310f4bee23e497d9d84b717d7f7 by Miss Islington (bot) in branch '3.9': [3.9] bpo-45628: Check all parts of the suffix for an extension match. (GH-29310) (GH-29313) https://github.com/python/cpyt

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 8a77f59de51f1fd6062f0fefe73ee3059d714144 by Vinay Sajip in branch 'main': bpo-45628: Check all parts of the suffix for an extension match. (GH-29310) https://github.com/python/cpython/commit/8a77f59de51f1fd6062f0fefe73ee3

[issue45628] TimedRotatingFileHandler backupCount not working

2021-10-29 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +27578 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29310 ___ Python tracker <https://bugs.python.org/issu

[issue45465] logging messages are needlessly reformatted for every handler

2021-10-15 Thread Vinay Sajip
Vinay Sajip added the comment: Oh, I see what you mean now - I was thinking of the overall message formatted using a formatter. However, filters can still change a record's attributes and getMessage() could behave differently on different calls because of this. Changing things in this

[issue45465] logging messages are needlessly reformatted for every handler

2021-10-15 Thread Vinay Sajip
Vinay Sajip added the comment: A developer may wish to format messages differently for different audiences (i.e. different handlers) - for example, omit stack traces. This behaviour is by design. -- resolution: -> not a bug stage: -> resolved status: open -&g

[issue45401] logging TimedRotatingFileHandler must not rename devices like /dev/null

2021-10-10 Thread Vinay Sajip
Vinay Sajip added the comment: Where did you see the warnings? I didn't spot anything in the GitHub Actions logs. -- ___ Python tracker <https://bugs.python.org/is

[issue45401] logging TimedRotatingFileHandler must not rename devices like /dev/null

2021-10-10 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45401] logging TimedRotatingFileHandler must not rename devices like /dev/null

2021-10-08 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +27140 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28822 ___ Python tracker <https://bugs.python.org/issu

[issue45401] logging TimedRotatingFileHandler must not rename devices like /dev/null

2021-10-07 Thread Vinay Sajip
Vinay Sajip added the comment: RotatingFileHandler is also affected by the same issue. Both RotatingFileHandler and TimedRotatingFileHandler have a shouldRollover method which, if it returns False, should prevent rollover. I would think that putting something like if not os.path.isfile

[issue45027] Allow basicConfig to configure any logger, not just root

2021-09-20 Thread Vinay Sajip
Vinay Sajip added the comment: > This selectively _disables_ a logger. That isn't the same thing as > selectively _enabling_ only the loggers you want to enable. Your earlier comment referred to getting unwanted messages from third-party loggers. Suppressing the messages implie

[issue45027] Allow basicConfig to configure any logger, not just root

2021-09-16 Thread Vinay Sajip
Vinay Sajip added the comment: > This change serves the purpose of making it easier to configure non-root > loggers. My point was, they don't need to configure non-root loggers (in terms of adding handlers) because the root logger's handlers will normally be used

[issue44489] _handle_existing_loggers should respect loggers that were manually disabled

2021-09-02 Thread Vinay Sajip
Vinay Sajip added the comment: Closing, as no further feedback received on this issue. You can reopen if you have an answer to my question. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracke

[issue45027] Allow basicConfig to configure any logger, not just root

2021-09-02 Thread Vinay Sajip
Vinay Sajip added the comment: Thanks, but ... > I observe that many Python users tend to use basicConfig() even when they > would be better served by configuring only the logger(s) needed for their own > app/library. First of all, library developers should not be configuring l

[issue44924] logging.handlers.QueueHandler does not maintain the exc_text

2021-08-17 Thread Vinay Sajip
Vinay Sajip added the comment: It might be inadvisable to make your suggested change because of backward compatibility and breakage of existing code. However, I don't mind updating the logging cookbook to mention your suggested method of resolving the issue for this use case. I'll

[issue44924] logging.handlers.QueueHandler does not maintain the exc_text

2021-08-16 Thread Vinay Sajip
Vinay Sajip added the comment: Why can you not subclass QueueHandler and override the prepare method to do what you want/need? -- ___ Python tracker <https://bugs.python.org/issue44

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-08-13 Thread Vinay Sajip
Vinay Sajip added the comment: > You are far better and more experienced in maintaining widely used opensource > codebases so I wouldn't argue with you, but... :) Well, if a change introduces a problem, it will be my lookout, won't it? Just as the original patch for bpo-81

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-08-13 Thread Vinay Sajip
Vinay Sajip added the comment: I just checked - the relevant code (using MTIME) was added in 2010, as a fix for bpo-8117 - around the time that Python 2.6 was released. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-08-13 Thread Vinay Sajip
Vinay Sajip added the comment: > Well, there is nothing in the documentation that would say the logrotation > can be only performed by continously running scripts, thats why. :) Well, what's the need to rotate based on time when you just run scripts sporadically or they're

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-08-12 Thread Vinay Sajip
Vinay Sajip added the comment: > The assumed behaviour of TimedRotatingFileHandler is to rotate log files > older than configured. Even when the script is executed multiple times. Ah, but is it? The purpose of TimedRotatingFileHandler is to rotate files based on time intervals,

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

2021-08-05 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

2021-08-05 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 3d315c311676888201f4a3576e4ee3698684a3a2 by Kirill Pinchuk in branch 'main': bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490) https://github.com/python/cpython/commit/3d315c311676888201f4a3576e4ee3

[issue44186] TimedRotatingFileHandler overwrite log

2021-08-02 Thread Vinay Sajip
Vinay Sajip added the comment: OK, I get it now :-) See my comments on the PR - I think the renaming strategy might need rethinking in the presence of a "namer" routine being set. See bpo-43344, bpo-44753. This area (TimedRotatingFileHandler) is unfortunately not yet well teste

[issue43749] venv module does not copy the correct python exe

2021-07-31 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44489] _handle_existing_loggers should respect loggers that were manually disabled

2021-07-31 Thread Vinay Sajip
Vinay Sajip added the comment: Why couldn't you just do the logging configuration first, then disable any loggers you need to after that? You can pass a custom configuration dict when instantiating a Sanic app. That could contain a setting for the ddtrace logger, e.g. to set its lev

[issue37880] For argparse add_argument with action='store_const', const should default to None.

2021-07-31 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-07-31 Thread Vinay Sajip
Vinay Sajip added the comment: With this slightly modified test script and the JSON configuration based on the YAML, I got the following results after running for a while: $ more info.log* :: info.log :: 2021-08-01 07:13:45 INFO Message no. 9 2021-08-01 07:14:15 INFO

[issue40469] TimedRotatingFileHandler rotating on use not time

2021-07-31 Thread Vinay Sajip
Change by Vinay Sajip : Added file: https://bugs.python.org/file50196/config.json ___ Python tracker <https://bugs.python.org/issue40469> ___ ___ Python-bugs-list mailin

[issue44186] TimedRotatingFileHandler overwrite log

2021-07-31 Thread Vinay Sajip
Vinay Sajip added the comment: I modified the provided test script (-> test_44186.py) and added a test shell script which runs it twice in succession. What it printed was: 6 51 43 TEST > [INFO] [2021-08-01 06:51:43] : foo 2021-08-01T06:51:43.091681 6 51 43 TEST > [INFO] [2021-08-01

[issue44186] TimedRotatingFileHandler overwrite log

2021-07-31 Thread Vinay Sajip
Change by Vinay Sajip : Added file: https://bugs.python.org/file50194/log_44186.py ___ Python tracker <https://bugs.python.org/issue44186> ___ ___ Python-bugs-list mailin

[issue43758] dict.config TimedRotatingFileHandler filename .suffix does not function

2021-07-31 Thread Vinay Sajip
Vinay Sajip added the comment: This is not the place for asking questions like this - please use Stack Overflow or the python-users mailing list. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracke

[issue37880] For argparse add_argument with action='store_const', const should default to None.

2021-07-31 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 0ad173249d287794d53e6a1fe2d58bb2adee2276 by Jack DeVries in branch 'main': bpo-37880: for argparse add_argument with action='store_const', const now defaults to None. (GH-26707) https://github.com/p

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Vinay Sajip added the comment: Thanks for the bug report. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 6e6dc2517379289932c68fc986ee3994468374fc by Miss Islington (bot) in branch '3.10': bpo-44753: Don't use logfile extension when determining old files to be deleted (GH-27475) (GH-27487) https://github.com/python

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 882e4761c63ae76d994b57bbcd7e5adbf2aa7b4f by Miss Islington (bot) in branch '3.9': bpo-44753: Don't use logfile extension when determining old files to be deleted (GH-27475) (GH-27486) https://github.com/python

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Vinay Sajip added the comment: Should be fixed in main, leaving open until backports are done. -- versions: +Python 3.10, Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue44

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 6ff890380971752299325bd28eab80ec936975cf by Vinay Sajip in branch 'main': bpo-44753: Don't use logfile extension when determining old files to be deleted (GH-27475) https://github.com/python/cpython/commit/6ff890380971752299325bd28

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-30 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +25994 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27475 ___ Python tracker <https://bugs.python.org/issu

[issue43344] RotatingFileHandler breaks file type associations

2021-07-29 Thread Vinay Sajip
Vinay Sajip added the comment: > Could you please share best practices, looks like this documentation is > missing. I don't think so, because the implementation of the namer is up to the user. Note that this specific issue relates to RotatingFileHandler, not TimedRotatingFil

[issue44753] backupCount is not respected in TimedRotatingFileHandler when namer is specified

2021-07-29 Thread Vinay Sajip
Change by Vinay Sajip : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue44753> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44388] venv API Docs for EnvBuilder.ensure_directories incorrectly describe behavior

2021-07-28 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43184] Missing docs for LoggerAdapter manager and name property

2021-07-28 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44399] log rotator cookbook example might waste disk space

2021-07-28 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

  1   2   3   4   5   6   7   8   9   10   >