Skyler Leigh Amador added the comment:
You're welcome, happy to help :)
On Mon, Jun 9, 2014 at 8:31 AM, Erik Bray wrote:
>
> Erik Bray added the comment:
>
> Thanks Skyler for finishing the job. I got busy/distracted.
>
> --
>
> ___
Skyler Leigh Amador added the comment:
Addressed review comments
--
Added file: http://bugs.python.org/file35529/urllib-request-ftpcache-test.patch
___
Python tracker
<http://bugs.python.org/issue21
Skyler Leigh Amador added the comment:
The patch still applies cleanly, so I've just updated the comment. test passes,
make patchcheck passes.
--
nosy: +shiinee
Added file: http://bugs.python.org/file35525/pydoc-self.patch
___
Python tracker
Skyler Leigh Amador added the comment:
I've made a test for this patch with a very minimal mock ftpwrapper. We can see
it fails on dictionary size change without Erik's fix:
==
ERROR: test_ftp_cac