Skyler Leigh Amador added the comment:
I've made a test for this patch with a very minimal mock ftpwrapper. We can see
it fails on dictionary size change without Erik's fix:
======================================================================
ERROR: test_ftp_cache_pruning (test.test_urllib.urlopen_HttpTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/skyler/cpython/Lib/test/test_urllib.py", line 336, in
test_ftp_cache_pruning
urlopen('ftp://localhost')
File "/home/skyler/cpython/Lib/test/test_urllib.py", line 45, in urlopen
return opener.open(url)
File "/home/skyler/cpython/Lib/urllib/request.py", line 1631, in open
return getattr(self, name)(url)
File "/home/skyler/cpython/Lib/urllib/request.py", line 1914, in open_ftp
for k in self.ftpcache.keys():
RuntimeError: dictionary changed size during iteration
----------
nosy: +shiinee
Added file: http://bugs.python.org/file35522/urllib-request-ftpcache-test.patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue21463>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
