[issue4263] BufferedWriter non-blocking overage

2009-03-05 Thread Sever Băneșiu
Sever Băneșiu added the comment: Looks like the test covering the pre-flush condition is missing. ___ Python tracker <http://bugs.python.org/issue4263> ___ ___ Python-bug

[issue4263] BufferedWriter non-blocking overage

2009-01-07 Thread Sever Băneșiu
Sever Băneșiu added the comment: > Anyway :) Practically, the test does work on both py3k and another > implementation, so I don't see any urgency to remove anything from it. Indeed, it doesn't hurt keeping it. For completeness' sake I've updated your tests to cov

[issue4263] BufferedWriter non-blocking overage

2008-12-31 Thread Sever Băneșiu
Sever Băneșiu added the comment: >> The comment is misleading because in fact no byte is written at raw >> level. That's because the data size is smaller than the buffer size and >> the buffer is empty (was emptied by the last write call). > It depends on the i

[issue4263] BufferedWriter non-blocking overage

2008-12-31 Thread Sever Băneșiu
Sever Băneșiu added the comment: Thanks for the new implementation of MockNonBlockWriterIO class. It makes tests so much easier to read. There are some minor things in your patch that I would change. For example: # 1 byte will be written, the rest will be buffered raw.block_on(b&q

[issue4263] BufferedWriter non-blocking overage

2008-12-07 Thread Sever Băneșiu
Sever Băneșiu <[EMAIL PROTECTED]> added the comment: Christian, if the patch looks good to you I think now it's a good time to commit it. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.