[issue28595] shlex.shlex should not augment wordchars

2016-11-23 Thread Evan
Evan added the comment: I've created issue28784 to capture the documentation fixes. When I have more spare time, I'll work on a more complete patch. -- ___ Python tracker ___ __

[issue28784] shlex.shlex punctuation_chars documentation should use posix=True

2016-11-23 Thread Evan
New submission from Evan: (This discussion started on issue28595.) The new punctuation_chars keyword argument is intended to provide "compatibility with the parsing performed by common Unix shells like bash, dash, and sh", however the documentation and examples do not mention that the user sh

[issue28728] test_host_resolution in test_socket fails

2016-11-23 Thread Martin Panter
Martin Panter added the comment: Maybe worth looking at what name resolution stuff is enabled in /etc/nsswitch.conf. On the hosts line, my current computer (v basic setup) has hosts: files dns myhostname My guess is you have a plugin which is resolving these ip-address lookalikes. --

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

2016-11-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Since the patch is simple and fixes a regression introduced > just before releasing beta 4, I'm fine with fixing it. We are > trying to support tests warnings-free. Some buildbots can run > tests with -We. +1 -- __

[issue28728] test_host_resolution in test_socket fails

2016-11-23 Thread Xiang Zhang
Xiang Zhang added the comment: Hi SilentGhost. I'm also using Ubuntu 16.10 but the test case doesn't fail. cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.10 DISTRIB_CODENAME=yakkety DISTRIB_DESCRIPTION="Ubuntu 16.10" ./python -Wa -m test -v test_socket | grep test_host_resolution te

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I prefer pygen_yf.patch (with addressing Yury's suggestions). It is much simpler, and in any case I want to change f_lasti to count words rather than bytes (issue27129). It would be again -1 at the start. -- ___ P

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please do this yourself. This is mainly your patch. -- ___ Python tracker ___ ___ Python-bugs-list

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, how I missed this? I usually run tests with -Wa. Since the patch is simple and fixes a regression introduced just before releasing beta 4, I'm fine with fixing it. We are trying to support tests warnings-free. Some buildbots can run tests with -We.

[issue27172] Undeprecate inspect.getfullargspec()

2016-11-23 Thread Ned Deily
Ned Deily added the comment: Nick, that seems like the right thing to do. Thanks for following up on it. -- nosy: +larry priority: normal -> release blocker versions: +Python 3.7 ___ Python tracker ___

[issue27172] Undeprecate inspect.getfullargspec()

2016-11-23 Thread Nick Coghlan
Nick Coghlan added the comment: When we undeprecate this, we should remove and reword the deprecation warnings in the next 3.5 maintenance release as well. I'll need to decide on a way to indicate in the docs that some versions of 3.x.y will report a deprecation warning for getfullargspec() th

[issue27172] Undeprecate inspect.getfullargspec()

2016-11-23 Thread Nick Coghlan
Nick Coghlan added the comment: This just came up in a discussion on a urllib3 patch, so I'd like to fix it for 3.6.0rc1. Ned, given that the code change here is just deleting the deprecation warning from getfullargspec() and rewording the one for getargspec(), does that seem OK for 3.6.0? -

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

2016-11-23 Thread Martin Panter
Martin Panter added the comment: The tests changes also produce a DeprecationWarning: == ERROR: testEnterAttributeError1 (test.test_with.FailureTestCase) -- Tra

[issue10721] Remove HTTP 0.9 server support

2016-11-23 Thread Martin Panter
Martin Panter added the comment: V4 patch adjusting to recent code change. Raymond: Given the problems caused by the current code, would you reconsider your opposition? Otherwise, what do you think should be the future of the code? Should we fix it so that it handles real HTTP 0.9 requests, o

[issue28771] Update documented signatures of tp_get/setattr

2016-11-23 Thread Martin Panter
Martin Panter added the comment: Python 2 patch is on top of the patch for Issue 25701 -- dependencies: +Document that tp_setattro and tp_setattr are used for deleting attributes ___ Python tracker ___

[issue28771] Update documented signatures of tp_get/setattr

2016-11-23 Thread Martin Panter
Martin Panter added the comment: In Python 2, charbufferproc was changed to use non-const char ** in revision dba6494735d0 (perhaps by accident). Otherwise, this patch is the same as for Python 3. I have added a sentence about using NULL for deletion in the patch. -- Added file: http:/

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Yury Selivanov
Yury Selivanov added the comment: > f_lasti being -2 has always been my preference, lasti.patch lgtm How about we commit pygen_yf.patch to 3.6 and whatever else in 3.7? lasti.patch is too invasive for 3.6 at this point, -1 for it in 3.6. -- ___ Py

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Demur Rumed
Demur Rumed added the comment: I had considered this, for some reason I didn't realize code[1] could be equal to YIELD_FROM, felt it'd always be false f_lasti being -2 has always been my preference, lasti.patch lgtm -- ___ Python tracker

[issue28773] typing.FrozenSet missing in documentation.

2016-11-23 Thread Ned Deily
Ned Deily added the comment: Guido, doc fixes are welcome! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2016-11-23 Thread Martin Panter
Martin Panter added the comment: The 2.7 patch looks okay to me. I confirmed that sq_ass_slice gets called to delete slices, and I presume the other stuff is similar to Python 3. Do you want to commit this to 2.7 Serhiy? -- stage: patch review -> commit review

[issue28773] typing.FrozenSet missing in documentation.

2016-11-23 Thread Guido van Rossum
Guido van Rossum added the comment: Ned: does the ban on non-critical commits to the 3.6 branch also apply to doc patches? -- nosy: +ned.deily ___ Python tracker ___ ___

[issue10379] locale.format() input regression

2016-11-23 Thread Eric V. Smith
Changes by Eric V. Smith : -- assignee: docs@python -> keywords: +easy stage: -> needs patch type: -> behavior ___ Python tracker ___ _

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: > Another much larger change would be to change f_lasti to -2... Attached lasti.patch implements this idea. I consider that it makes the C code simpler because getting the next instruction (f_lasti + 2) doesn't require a special case anymore. My patch keeps f

[issue27153] Default value shown by argparse.ArgumentDefaultsHelpFormatter is backwards for action='store_false'

2016-11-23 Thread paul j3
Changes by paul j3 : -- nosy: +paul.j3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: It would be nice if Demur Rumed and/or Serhiy Storchaka can review pygen_yf.patch since Demur wrote the wordcode patch and Serhiy reviewed the wordcode patch. -- nosy: +Demur Rumed ___ Python tracker

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread STINNER Victor
Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file45614/pygen_yf.patch ___ Python tracker ___ ___

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: Oh wow, the bug is tricky. _PyGen_yf() checks if the next instruction is YIELD_FROM using code[f_lasti+2]. The problem is that WORDCODE kept f_lasti == -1 for a frame not executed yet: f_lasti+2 is 1 in this case. Problem: code[1] is not an operation code, bu

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

2016-11-23 Thread paul j3
paul j3 added the comment: I might accept a patch that tweaks the ArgumentDefaultsHelpFormatter class, but adding a parameter that must propagate through all the Action classes in just plain wrong. Users are confused by the many Action parameters as it is. And based on StackOverFlow questi

[issue10379] locale.format() input regression

2016-11-23 Thread Eric V. Smith
Changes by Eric V. Smith : -- versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list ma

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: An optimization must not change the behaviour of Python. -- ___ Python tracker ___ ___ Python-bugs-l

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: > I don't like it because it adds a cumbersome code for guarding against a case > that doesn't happen in practice. Hum, sorry, I don't understand what is the issue with adding a few addition checks in the constructor? Is it a matter of speed? > This is just

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Yury Selivanov
Yury Selivanov added the comment: Wow, Martin, this is a very interesting one. Thanks so much for tracking this down and reducing the test case. So far this doesn't seem to be related to async/await: the interpreter stack seems to enter some strange state under some conditions, and async/awai

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue28682] Bytes support in os.fwalk()

2016-11-23 Thread Zac Medico
Changes by Zac Medico : -- nosy: +zmedico ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue28532] Show sys.version when -V option is supplied twice.

2016-11-23 Thread Martin Panter
Martin Panter added the comment: Looks good to me -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue10379] locale.format() input regression

2016-11-23 Thread Wolfgang Maier
Changes by Wolfgang Maier : -- nosy: +wolma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Steve Dower
Steve Dower added the comment: Thanks. For reference, the setuptools issue is https://github.com/pypa/setuptools/issues/857 A setuptools install from source should be fixed by this change, though an install from a wheel (which is now typical, unfortunately) requires a separate fix. But we've

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset f7aa200bed8d by Steve Dower in branch '3.5': Issue #28783: Embedded and nuget packages incorrect reference missing bdist_wininst command. https://hg.python.org/cpython/rev/f7aa200bed8d New changeset a3755890545c by Steve Dower in branch '3.6': Issu

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Steve Dower
Steve Dower added the comment: A convenient test is: python.exe -c "import distutils.core; distutils.core.setup()" --help-comm ands Without the fix, it raises "distutils.errors.DistutilsModuleError: invalid command 'bdist_wininst'". But yes, unfortunately the fix is not particularly direc

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Ned Deily
Ned Deily added the comment: FWIW, hg bisect finds: changeset 103444:a77756e480c2: bad The first bad revision is: changeset: 103444:a77756e480c2 parent: 103442:914a81781291 user:Victor Stinner date:Fri Sep 09 10:17:08 2016 -0700 summary: Rework CALL_FUNCTION* opcodes

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Paul Moore
Paul Moore added the comment: I've had a look. I agree in principle with the change, and the code looks OK on inspection, although I can't really test it. As it's only a change to one of the scripts in tools/msi, this seems like a low-risk change to me, so I'm OK with it. --

[issue28781] On Installation of 3.5 Python get error message

2016-11-23 Thread Steve Dower
Steve Dower added the comment: Do you see a "Repair" option when running the installer again? If not, open Programs and Features and find Python there, double-click it and select "Repair". Otherwise, you should have a set of log files in your %TEMP% directory (sort by date and they all start

[issue28673] pyro4 with more than 15 threads often crashes 2.7.12

2016-11-23 Thread Irmen de Jong
Irmen de Jong added the comment: Due to lack of example code to reproduce the issue, and because I'm mildly interested in this bug because it mentions Pyro4 (because I'm the author of that) I've tried to crash my system myself using Pyro4 and a simple torture test but it trucked on just fine.

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Ned Deily
Ned Deily added the comment: I'd like one of the other Windows folks to review it but, in principle, LGTM. -- ___ Python tracker ___ _

[issue28781] On Installation of 3.5 Python get error message

2016-11-23 Thread Ned Deily
Changes by Ned Deily : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___ Python

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Steve Dower
Steve Dower added the comment: The full fix may also require updating setuptools, which I'm pursuing, but we also should stop referring to a module that isn't there. -- ___ Python tracker _

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

2016-11-23 Thread Steve Dower
New submission from Steve Dower: For the embedded zip and nuget releases, I've omitted bdist_wininst. However, I forgot to remove the reference to it from distutils.command.__init__.__all__, and so setuptools will occasionally crash trying to import it. This patch updates Tools/msi/make_zip.py

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread R. David Murray
R. David Murray added the comment: I'm marking this as a release blocker since it is a (new) segfault. -- nosy: +ned.deily, r.david.murray priority: normal -> release blocker ___ Python tracker

[issue28722] doctest example exit status

2016-11-23 Thread R. David Murray
R. David Murray added the comment: Rajiv is suggesting an improvement to the documentation. I think it is a reasonable thought, but probably not a good idea on closer examination. The example introduces the basic doctest concepts, and goes on to say that this is not the mostly likely way to

[issue28782] SEGFAULT when running a given coroutine

2016-11-23 Thread Martin Richard
New submission from Martin Richard: Hi, I stumbled upon a SEGFAULT while trying Python 3.6.0 on a project using asyncio. I can't really figure out what's happening, so I reduced the original code triggering the bug down to a reproducible case (which looks a bit clunky, sorry). The case has been

[issue9216] FIPS support for hashlib

2016-11-23 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: -gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue9216] FIPS support for hashlib

2016-11-23 Thread Doug Hellmann
Changes by Doug Hellmann : -- nosy: +doughellmann ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue22298] Lib/warnings.py _show_warning does not protect against being called with a file like object which is closed

2016-11-23 Thread Wolfgang Maier
Wolfgang Maier added the comment: Issue23016 fixed the "AttributeError: 'NoneType' object has no attribute 'write'" problem when sys.stderr is None. With that it's now possible and good practice to set sys.stderr = None when closing it, just as Antoine suggested. Should this issue be closed the

[issue28722] doctest example exit status

2016-11-23 Thread Berker Peksag
Berker Peksag added the comment: Hi Rajiv, thanks for the report, but this is already possible by default. I will use the factorial example from https://docs.python.org/3.5/library/doctest.html to demonstrate it: $ python -m doctest example.py $ echo $? 0 Now change the following

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : Added file: http://bugs.python.org/file45611/forkserver_preload.patch ___ Python tracker ___ ___ Python-bugs-list

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file45610/forkserver_preload.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch. -- keywords: +patch Added file: http://bugs.python.org/file45610/forkserver_preload.patch ___ Python tracker ___ __

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28781] On Installation of 3.5 Python get error message

2016-11-23 Thread Mark Harris
New submission from Mark Harris: While I am installing python when it gets towards the end of the installation the message appears "The program can't start because python35.dll is missing from your computer. Try reinstalling the program to fix this problem". Apart from this message the install

[issue28714] Addition to Documentation of configparser.ConfigParser.write()

2016-11-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, George. Using 'r+' means that you don't have to reopen the same file if you want to both read and write to it but it's up to you to check where the cursor is before writing anything to it. Since the ConfigParser.write() method doesn't ha

[issue28780] netrc throws NetrcParseError for record without 'password'

2016-11-23 Thread Mark Wood
New submission from Mark Wood: netrc.netrc() throws a NetrcParseError if ~/.netrc contains an entry witout a 'password' field. Other users of .netrc do not do this. In my case, I have entries for sftp hosts which will use public-key authentication instead of a password. What I would suggest

[issue27761] Private _nth_root function loses accuracy

2016-11-23 Thread Wolfgang Maier
Changes by Wolfgang Maier : -- nosy: +wolma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: The example above works if you comment out either the "Lock()" line or the "set_forkserver_preload()" line. -- ___ Python tracker ___ _

[issue28779] set_forkserver_preload() can crash the forkserver if preloaded module instantiate multiprocessing classes

2016-11-23 Thread Antoine Pitrou
New submission from Antoine Pitrou: The following script: import multiprocessing import os def f(): pass multiprocessing.Lock() if __name__ == "__main__": ctx = multiprocessing.get_context('forkserver') # modname is the script's importable name (not "__main__") modname = os.p

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I don't like it because it adds a cumbersome code for guarding against a case that doesn't happen in practice. This is just unpythonic. _sre.compile() is a private function and it is called only with exact types. Even if it would called with subtypes, most s

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-23 Thread Julien Palard
Julien Palard added the comment: Reopening to remind @Victor we have a question about METH_FASTCALL. -- status: closed -> open ___ Python tracker ___

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

2016-11-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

2016-11-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3addf93f4111 by Serhiy Storchaka in branch 'default': Issue #28774: Simplified encoding a str result of an error handler in ASCII https://hg.python.org/cpython/rev/3addf93f4111 -- ___ Python tracker

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: > It is too. But I meant the code parameter. Oh ok. It seems like we use PyList_xxx() functions, so yeah, it seems safer (to respect the Python semantics) to only accept exactly the list type. > Updated patch restricts _sre.compile() to accepting only exact c

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Congratulations, Xiang! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch restricts _sre.compile() to accepting only exact collection types. I don't like this patch. -- Added file: http://bugs.python.org/file45609/sre-concrete-2.patch ___ Python tracker

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

2016-11-23 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Serhiy and Victor. Finished my first commit. :-) Now assign back to Serhiy and pos2 LGTM. -- assignee: xiang.zhang -> serhiy.storchaka ___ Python tracker _

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

2016-11-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3d660ed2a60e by Xiang Zhang in branch 'default': Issue #28774: Fix start/end pos in unicode_encode_ucs1(). https://hg.python.org/cpython/rev/3d660ed2a60e -- nosy: +python-dev ___ Python tracker

[issue10049] Add a "no-op" (null) context manager to contextlib (Rejected: use contextlib.ExitStack())

2016-11-23 Thread Nick Coghlan
Nick Coghlan added the comment: It turns out that there's a variant on the "null context manager" idea that may *not* be redundant with ExitStack(), and hence could potentially counter the current rationale for not adding one. Specifically, it relates to context managers like click.progressbar

[issue28532] Show sys.version when -V option is supplied twice.

2016-11-23 Thread INADA Naoki
INADA Naoki added the comment: Elvis agreed to add "Other Improvements" section. (http://bugs.python.org/issue28635#msg281486) Here is new patch. -- Added file: http://bugs.python.org/file45608/vervose-version-doc2.patch ___ Python tracker

[issue28775] Option to set startup directory in IDLE

2016-11-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree. I have had in mind (but cannot find an issue) to change the default to a user's home directory, as the best general default. But even that is not really the proper place that many would want. I can adapt and reuse the code used to browse and valida

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is too. But I meant the code parameter. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16026] csv.DictReader argument names documented incorrectly

2016-11-23 Thread Berker Peksag
Berker Peksag added the comment: James Salt's patch looks good to me, but it doesn't apply cleanly anymore. For the record, PyPy uses the same parameter name as Lib/csv.py: https://bitbucket.org/pypy/pypy/src/55a9404c80d6557854cac092addd92a6e0b683cc/lib-python/2.7/csv.py?at=default&fileviewer=f

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: > Should we check that code is exact list? Do you mean a tuple for indexgroup? Yeah, it also seems worth it. I just checked: --- class Tuple(tuple): def __getitem__(self, index): return 9 a = Tuple([1, 2, 3]) print(a[0]) --- Output: --- 9 --- ---

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Should we check that code is exact list? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: Sorry, my comment is unclear: I'm only asking your to add PyDict_CheckExact check in _sre.compile() for sre-concrete.patch. -- ___ Python tracker _

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: 1addc5d2c246 broke support of non-dict mappings, this patch brakes support of dict subclasses with overridden __getitem__. I think we can ignore this as well. -- ___ Python tracker

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread STINNER Victor
STINNER Victor added the comment: sre-concrete.patch is wrong: if groupindex is a subtype of dict, you should use PyObject_GetItem. I like the idea of using PyDict_GetItem, you should just implement stricter checks in _sre.compile(). Maybe using PyDict_CheckExact? Since it's a private module,

[issue28778] wsgiref HTTP Response Header Injection: CRLF Injection

2016-11-23 Thread RAUSHAN RAJ
New submission from RAUSHAN RAJ: https://www.owasp.org/index.php/CRLF_Injection Issue is in wsgiref.headers – WSGI response header tools This module provides a single class, Headers, for convenient manipulation of WSGI response headers using a mapping-like interface. class wsgiref.headers.Head

[issue28778] wsgiref HTTP Response Header Injection: CRLF Injection

2016-11-23 Thread RAUSHAN RAJ
Changes by RAUSHAN RAJ : -- components: Library (Lib) nosy: RAUSHAN RAJ priority: normal severity: normal status: open title: wsgiref HTTP Response Header Injection: CRLF Injection type: security versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5 __

[issue3687] Popen() object stdout attribute reassignment behaviour

2016-11-23 Thread Mohammad Maaz Khan
Mohammad Maaz Khan added the comment: Hi, I want to update the doc for this. This will be my first attempt to update the documentation. -- nosy: +maaz92 ___ Python tracker ___ __

[issue28773] typing.FrozenSet missing in documentation.

2016-11-23 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Thank you Manuel! LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue16026] csv.DictReader argument names documented incorrectly

2016-11-23 Thread Mohammad Maaz Khan
Mohammad Maaz Khan added the comment: Hi Éric, I think the documentation should be changed to match the arguments' names. -- nosy: +maaz92 ___ Python tracker ___ ___

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

2016-11-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Following patch replaces abstract types API with concrete types API and makes the memory consumption of the pattern object smaller if there are no named groups. $ ./python -m perf timeit -s "import re; m = re.match('(?Pfirst) (?Psecond)', 'first second')" -