New submission from Steve Dower: For the embedded zip and nuget releases, I've omitted bdist_wininst. However, I forgot to remove the reference to it from distutils.command.__init__.__all__, and so setuptools will occasionally crash trying to import it.
This patch updates Tools/msi/make_zip.py to exclude the default distutils.command.__init__ and substitute a copy that does not have the added reference in it. Doing something "smarter" in the actual Lib/distutils/command/__init__.py isn't really an option. The only reliable option is to import the module eagerly, which I don't want to do. Including bdist_wininst in these packages is also a bad option (I considered completely removing distutils from them, but it has *some* uses - can't say the same for bdist_wininst though). Ned - I'd like to apply this change to 3.6. The patch is against 3.5, and there may be some subtle differences when I merge it forward (not every change to make_zip.py has been backported), but the intent is well captured here. If this is not applied to 3.6, then the packages will not be reliably usable with pip/setuptools, which is one of the intended uses (particularly for the nuget package). ---------- assignee: steve.dower components: Windows files: no_bdist_wininst.patch keywords: patch messages: 281576 nosy: ned.deily, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal stage: patch review status: open title: Embedded/nuget packages incorrectly reference bdist_wininst type: behavior versions: Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45613/no_bdist_wininst.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28783> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
