[issue28740] Add sys.getandroidapilevel()

2016-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: Patch tested with success on the android-24 emulator. -- ___ Python tracker ___ ___ Python-bugs-list

[issue26865] Meta-issue: support of the android platform

2016-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: issue #28740: Add sys.getandroidapilevel() -- dependencies: +Add sys.getandroidapilevel() ___ Python tracker ___ ___

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread woo yoo
woo yoo added the comment: Thanks for your advice. -- nosy: -docs@python, steven.daprano ___ Python tracker ___ ___ Python-bugs-list

[issue28740] Add sys.getandroidapilevel()

2016-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: > I proposed to add a new function to the sys module: sys.getandroidapilevel() This would also help fixing the long standing issue 16255, and possibly also issue 16353. -- ___ Python tracker

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread Josh Rosenberg
Josh Rosenberg added the comment: Why is this unexpected? Per the docs, the process is: find the module specified in the from clause, loading and initializing it if necessary; for each of the identifiers specified in the import clauses: check if the imported module has an attrib

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread woo yoo
woo yoo added the comment: The link associated with the documentation is https://docs.python.org/3/reference/simple_stmts.html#import. My package layout is : --l007 --l009.py My code is : >from l007 import l009 The excution was ok, which was not the case i had expected. -- ___

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread Steven D'Aprano
Steven D'Aprano added the comment: If you're quoting from the docs, its a good idea to give the URL to *which* documentation you are reading, not just a copy of the text. -- ___ Python tracker

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread Steven D'Aprano
Steven D'Aprano added the comment: Please don't post screen shots of text. Copy and paste the text into the bug report. Some people (those who are blind, visually impaired or using a screen-reader for some other reason) cannot see the screen shot, and even those who can prefer to deal with tex

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

2016-11-18 Thread woo yoo
New submission from woo yoo: I've experiment with the statement,however the result did not match the official description. I created a namespace package named l007, within which submodule named l009 was placed.I typed "from l007 import l009" in the interpreter, the execution was ok, while in

[issue28743] test_choices_algorithms() in test_random uses lots of memory

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a problem to me too. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-lis

[issue10049] Add a "no-op" (null) context manager to contextlib (Rejected: use contextlib.ExitStack())

2016-11-18 Thread Martin Blais
Martin Blais added the comment: Adding nullcontext = ExitStack in the source file would solve this problem in a single line of code. -- nosy: +blais ___ Python tracker ___ _

[issue28681] About function renaming in the tutorial

2016-11-18 Thread Vedran Čačić
Vedran Čačić added the comment: Obligatory link: https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ :-P Yes, Python objects are simpler than people, but still not completely trivial. The core issue is "who does the calling". Even one's native language might subtl

[issue28710] Sphinx incompatible markup in configparser.ConfigParser.

2016-11-18 Thread Patrick Lehmann
Patrick Lehmann added the comment: I signed the CLA. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue28710] Sphinx incompatible markup in configparser.ConfigParser.

2016-11-18 Thread Patrick Lehmann
Patrick Lehmann added the comment: Hello, I used this regexp on all files: -- match pattern: `([A-Za-z0-9_]+)' replace pattern ``\1`` -- I assumed that only identifiers where quoted in such way. I think my editor found arou

[issue10656] "Out of tree" build fails on AIX

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Okay I will assume that $(srcdir) reference was just due to a mistake or bad cargo-culting then. Will commit this soon unless anyone has a good idea to avoid embedding @abs_srcdir@. -- stage: patch review -> commit review _

[issue10049] Add a "no-op" (null) context manager to contextlib (Rejected: use contextlib.ExitStack())

2016-11-18 Thread Nick Coghlan
Nick Coghlan added the comment: The problem Martin is referring to is the SEO one, which is that the top link when searching for either "null context manager python" or "no-op context manager python" is this thread, rather than the "Use ExitStack for that" recipe in the docs: https://docs.pyt

[issue28548] http.server parse_request() bug and error reporting

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Okay committed to 3.7 for the moment. I think that is all we can reasonably do unless we drop the pseudo-HTTP-0.9 support. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tra

[issue20572] subprocess.Popen.wait() undocumented "endtime" parameter

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Thanks Mariatta. Some people like to use the warn(stacklevel=2) parameter, then the warning message is potentially more useful. Also, I think it would be good to write a brief test case for the warning. There are probably lots of examples in the test suite, e.g

[issue20572] subprocess.Popen.wait() undocumented "endtime" parameter

2016-11-18 Thread Martin Panter
Changes by Martin Panter : -- stage: -> patch review versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list ma

[issue28744] Basic precision calc error

2016-11-18 Thread Zachary Ware
Zachary Ware added the comment: https://docs.python.org/3/tutorial/floatingpoint.html -- nosy: +zach.ware resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue28744] Basic precision calc error

2016-11-18 Thread Renner
New submission from Renner: Simple code: print('%.55f' %(1.1 + 2.2 - 3.3)) print('%.55f' %(1.1 + 2.2)) is supposed to produce 0.000 3.300 But when I run it, Actually it produces 0.000

[issue28548] http.server parse_request() bug and error reporting

2016-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c98768368cb by Martin Panter in branch 'default': Issue #28548: Parse HTTP request version even if too many words received https://hg.python.org/cpython/rev/7c98768368cb -- nosy: +python-dev ___ Python t

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

2016-11-18 Thread Peter Eckersley
Peter Eckersley added the comment: Patch is now against the latest Python development tree, and includes test cases: https://gist.github.com/pde/daec08cadc21bca0d62852020887ee13 -- ___ Python tracker

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Ned Deily
Ned Deily added the comment: Since this was previously discussed and rejected (in Issue25179), I don't think we should revisit this now for 3.6, other than potentially a documentation tweak. -- nosy: +ned.deily versions: -Python 3.6 ___ Python trac

[issue25659] ctypes.Array.from_buffer segmentation fault when trying to create from array.array

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Here is a patch implementing Eryk’s suggestion, for both from_buffer() and from_buffer_copy() methods. This is exactly how it is already handled for Array.from_address(). The two buffer methods were added more recently than from_address(). -- keywords:

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Guido van Rossum
Guido van Rossum added the comment: Might I point out the precedent of b-strings? Those also don't contribute to __doc__. -- ___ Python tracker ___ __

[issue28743] test_choices_algorithms() in test_random uses lots of memory

2016-11-18 Thread Martin Panter
New submission from Martin Panter: Revision 32bfc8b6 added test.test_random.MersenneTwister_TestBasicOps.test_choices_algorithms(), which runs the following code: n = 13132817 # 13 million self.gen.choices(range(n), [1]*n, k=1) When I build Python with the “--with-pydebug” configure

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

2016-11-18 Thread Peter Eckersley
Peter Eckersley added the comment: One thing I noticed when testing my patch by vendorizing it into the Certbot tree was that if a developer had somehow inherited from a version of argparse.Action that *doesn't* have this patch applied to it, and then passes in instances of those inheriting cl

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

2016-11-18 Thread Peter Eckersley
New submission from Peter Eckersley: When argparse lists the default values for cli flags and arguments, it shows argparse's view of the internal Pythonic default, not the default behaviour of the program as a whole. This can be wrong in many cases, as documented at https://bugs.python.org/iss

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Eric V. Smith
Eric V. Smith added the comment: It's Ned's call, but I wouldn't recommend changing this in 3.6, at least not 3.6.0. As Martin points out, the reason f'foo' is a "normal" string has to do with how strings and f-strings are assembled and concatenated. Similarly: 'foo' f'bar' 'baz' is a normal

[issue28732] spawnl crash on windows7

2016-11-18 Thread Steve Dower
Steve Dower added the comment: Looks like a few functions in os module need this. os_execve_impl also doesn't release the GIL at any point, but I don't see why it shouldn't. I'll try and get to this over the weekend if nobody else comes up with a patch first. -- _

[issue10049] Add a "no-op" (null) context manager to contextlib

2016-11-18 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: ExitStack() already covers the "null ctx mgr" use case described in the first message. Original example: with transaction or contextlib.null(): ... By using ExitStack: with transaction or ExitStack(): ... You can push this further and do this,

[issue28688] Warning -- warnings.filters was modified by test_warnings

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Here is another way to remember that the filter list has already been initialized. I made a new immortal _warnings.filters_initialized flag at the C level. It is actually a list so that it can be mutated and remembered across module reloads, but it is either em

[issue28688] Warning -- warnings.filters was modified by test_warnings

2016-11-18 Thread Martin Panter
Changes by Martin Panter : Added file: http://bugs.python.org/file45542/immortal-filters.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: New approach: patch 5 now compares indexgroup, groupindex and code instead of comparing pattern, to handle correctly two equal pattern strings compiled with the re.LOCALE flag and two different locales. The patch also converts indexgroup list to a tuple to be

[issue10049] Add a "no-op" (null) context manager to contextlib

2016-11-18 Thread Martin Blais
Martin Blais added the comment: I've been looking for this today; I would have used it. Instead of an obvious (and explicit) null context manager, I had to read through this entire thread to eventually find out that I can use something called ExitStack(), which is designed for another use case

[issue28729] Exception from sqlite3 adapter masked by sqlite3.InterfaceError

2016-11-18 Thread Julien Palard
Julien Palard added the comment: By moving: ``` /* else set the right exception and return NULL */ PyErr_SetString(pysqlite_ProgrammingError, "can't adapt"); ``` from `pysqlite_microprotocols_adapt` to `pysqlite_adapt` (to avoid changing the semantics from the outside) make the `pysqlite_micro

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Having an unassigned f-string as the first statement is still valid syntax, so could at most be a warning, not a SyntaxError. -- ___ Python tracker

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Martin Panter
Martin Panter added the comment: Actually, testing your code fragment, it seems you do get a doc string when the f-string has no substitutions in curly brackets, otherwise you don’t get any doc string. Maybe this is due to how different forms of string are compiled. >>> class Foo: ...f'spa

[issue28741] PEP 498: single '}' is not allowed

2016-11-18 Thread Yury Selivanov
New submission from Yury Selivanov: The PEP should document the "single '}' is not allowed" error. -- assignee: docs@python components: Documentation messages: 281173 nosy: docs@python, eric.smith, yselivanov priority: normal severity: normal status: open title: PEP 498: single '}' is no

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Yury Selivanov
Yury Selivanov added the comment: > IMO it would be simpler do disallow all f-strings as docstrings. How exactly you want to disallow them? Raise SyntaxError? If you don't raise anything, then the behaviour is just confusing -- the interpreter parses them, but __doc__ is None. I think this

[issue28740] Add sys.getandroidapilevel()

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: Ah, I wrote a patch to implement the function. I used ANDROID_API_LEVEL from pyconfig.h. I chose to simply return an integer. I don't know if it's the most future-proof API :-) -- keywords: +patch Added file: http://bugs.python.org/file45539/getandroid

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: I created the issue #28740: Add sys.getandroidapilevel(). -- ___ Python tracker ___ ___ Python-bugs-

[issue28740] Add sys.getandroidapilevel()

2016-11-18 Thread STINNER Victor
New submission from STINNER Victor: Android slowly becomes a first-citizen class platform in CPython thanks to Xavier de Gaye and other motivated developers, thanks to all of them :-) To fix the issue #28596, we need a function to check if we are running Android. Chi Hsuan Yen proposed to use

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Martin Panter
Martin Panter added the comment: There was a bit of discussion at the top of . IMO it would be simpler do disallow all f-strings as docstrings. Otherwise, what would the result of this be: name = "module level" class C: name = "class level"

[issue28735] Mock is equal to ANY but MagicMock is not

2016-11-18 Thread SilentGhost
Changes by SilentGhost : -- nosy: +michael.foord versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Eric V. Smith
Eric V. Smith added the comment: As you've seen, the answer is "no"! We'd need to add logic to evaluate them at function definition time. That would be a slight noticeable change, if the expressions had side effects. -- ___ Python tracker

[issue28739] PEP 498: docstrings as f-strings

2016-11-18 Thread Yury Selivanov
New submission from Yury Selivanov: Can f-strings be used as docstrings? Right now: class Foo: f'spam' Foo.__doc__ is None I couldn't find that f-strings cannot be used as docstrings in neither PEP 498 not in the 3.6 documentation, so I suppose this is a bug. -- compon

[issue28710] Sphinx incompatible markup in configparser.ConfigParser.

2016-11-18 Thread R. David Murray
R. David Murray added the comment: I think that we do not generally use ReST markup in our docstrings. So replacing `x' with 'x' would be more correct, I think. In many cases the quotes could just be omitted entirely. The patch command says: patch unexpectedly ends in middle of line pat

[issue28687] Python 2.7.12 windows x64 installer fails after previous bad uninstall

2016-11-18 Thread Steve Dower
Steve Dower added the comment: > ...is to Repair first and then reinstall Repair and then *un*install (obviously). -- ___ Python tracker ___

[issue28687] Python 2.7.12 windows x64 installer fails after previous bad uninstall

2016-11-18 Thread Steve Dower
Steve Dower added the comment: So the fix for pre-2.7.13 here is to Repair first and then reinstall. But we've actually fixed this for 2.7.13 by making the pip uninstall step non-vital (the work was sponsored by Microsoft because it affects the Visual Studio installer). See issue27888 for the

[issue28710] Sphinx incompatible markup in configparser.ConfigParser.

2016-11-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: As far as I looked, the patch changes `xyz' in docstrings and quotes to ``xyz``. A rst expert should verify that this is correct. In printed strings, `zyz' is changed to 'xyz', which I consider to be correct. Before applying this, I would want to review in R

[issue28159] Deprecate isdst argument in email.utils.localtime

2016-11-18 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Keeping localtime as a convenience function in email.util is fine, but isdst argument should be eliminated at some point. There is a fundamental problem with disambiguating fold times with isdst: some folds do not involve the change in dst or happen in

[issue28702] Confusing error message when None used in expressions, eg. "'NoneType' object has no attribute 'foo'"

2016-11-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have doubts also. The issue is the same for NotImplemented, though the occurrence is much rarer, and similar for Ellipsis. >>> NotImplemented.foo Traceback (most recent call last): File "", line 1, in NotImplemented.foo AttributeError: 'NotImplemented

[issue28738] Document SIGBREAK as argument for signal() under Windows.

2016-11-18 Thread Wojtek Ruszczewski
New submission from Wojtek Ruszczewski: SIGBREAK should be listed as acceptable for signal.signal() under Windows. Some context. Registering a handler for SIGBREAK may be useful as this is the signal that generating CTRL_BREAK_EVENT results in (and the latter combined with the CREATE_NEW_PROCE

[issue28736] multiprocessing.Lock() no longer has .acquire()

2016-11-18 Thread Zachary Ware
Changes by Zachary Ware : -- resolution: -> not a bug stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue28693] No HKSCS support in Windows cp950

2016-11-18 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28687] Python 2.7.12 windows x64 installer fails after previous bad uninstall

2016-11-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I had something like this happen with early 3.y.z. I believe I re-downloaded and re-installed the old version before either uninstalling or upgrading. I now keep the installer for x.y.z around until it is deleted or replaced. (I don't now if this is still n

[issue28736] multiprocessing.Lock() no longer has .acquire()

2016-11-18 Thread Eric Leadbetter
Eric Leadbetter added the comment: It was a typographical error on my part. My mistake. -- status: open -> closed ___ Python tracker ___ _

[issue28705] Clean up design FAQ question about compiling to C

2016-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset a0a3dab4ed66 by Brett Cannon in branch '3.6': Issue #28705: greatly simplify the FAQ entry on transpiling. https://hg.python.org/cpython/rev/a0a3dab4ed66 New changeset 89e2201142f9 by Brett Cannon in branch 'default': Merge for issue #28705 https://

[issue28705] Clean up design FAQ question about compiling to C

2016-11-18 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue28681] About function renaming in the tutorial

2016-11-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: It took me a moment to realize that 'value of the function name' meant 'the function object associated with the name'. I think David's rewrite is a substantial improvement. I would just change the end 'can be used as a function' to 'can be used to access the

[issue24452] Make webbrowser support Chrome on Mac OS X

2016-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0c8270cbdc62 by Brett Cannon in branch 'default': Issue #24452: add attribution https://hg.python.org/cpython/rev/0c8270cbdc62 -- ___ Python tracker __

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-11-18 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue28736] multiprocessing.Lock() no longer has .acquire()

2016-11-18 Thread R. David Murray
R. David Murray added the comment: What gives you the idea that the multiprocessing Lock implementation has been changed? Are you confusing the asyncio Lock with the threading Lock? Is there a documentation crosslink somewhere that is going to the wrong place? -- nosy: +r.david.murra

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-11-18 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Version 2 - use sys.implementation._multiarch to determine whether it's Android or not -- Added file: http://bugs.python.org/file45537/android-locale-utf8.patch ___ Python tracker

[issue28677] difficult to parse sentence structure in "When an instance attribute is referenced that isn't a data attribute"

2016-11-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: David's wording looks good. -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailin

[issue28673] pyro4 with more than 15 threads often crashes 2.7.12

2016-11-18 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: -> test needed title: When using pyro4 with more than 15 threads, python 2.7.12 cores frequently -> pyro4 with more than 15 threads often crashes 2.7.12 ___ Python tracker __

[issue28694] tkinter interface to fontchooser

2016-11-18 Thread Zachary Ware
Zachary Ware added the comment: I would recommend backing out your commit (hg rollback if you haven't pulled or otherwise changed your checkout since you made your commit), and just do 'hg diff' at the point where you would commit. In this particular case, if there are no changes other than t

[issue28728] test_host_resolution in test_socket fails

2016-11-18 Thread SilentGhost
SilentGhost added the comment: Of course, you're right, that was my mistake. The last three addresses fail to raise, namely: '::1q', '::1::2' and '1:1:1:1:1:1:1:1:1'. -- stage: patch review -> title: test_host_resolution in test_socket fails on duplicate assert -> test_host_resolution

[issue28728] test_host_resolution in test_socket fails on duplicate assert

2016-11-18 Thread SilentGhost
Changes by SilentGhost : Removed file: http://bugs.python.org/file45524/test_socket.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue28398] Return singleton empty string in _PyUnicode_FromASCII

2016-11-18 Thread Xiang Zhang
Xiang Zhang added the comment: > My question is simple: in what circumstances the patch has an effect? My original intention is that there is no need for the caller to check for the empty string. Even there is no use case now, it could be in future. But Serhiy, I am actually very glad to get a

[issue28398] Return singleton empty string in _PyUnicode_FromASCII

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: My question is simple: in what circumstances the patch has an effect? -- ___ Python tracker ___ __

[issue28737] Document that tp_dealloc handler must call PyObject_GC_UnTrack if Py_TPFLAGS_HAVE_GC is set

2016-11-18 Thread Sam Gross
New submission from Sam Gross: In general, an a PyTypeObject that has Py_TPFLAGS_HAVE_GC set must call PyObject_GC_UnTrack() before it frees any PyObject* references it owns. The only reference to this requirement I found is in https://docs.python.org/3/c-api/gcsupport.html#c._PyObject_GC_TRAC

[issue28531] Improve utf7 encoder memory usage

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: > I remember that we fixed bugs introduced by using _PyUnicodeWriter or > _PyBytesWriter many months after changing the code. Yeah, now I recall it (vaguely), that's why I closed the bug :-) -- ___ Python tracker <

[issue28531] Improve utf7 encoder memory usage

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: Oh no, now I'm afraid of breaking something :-D I don't trust anymore our test suite for the UTF-7 codec, so I close the issue :-) Sorry Xiang, but as we said, this rarely used codec is not important enough to require optimization. -- resolution: ->

[issue28531] Improve utf7 encoder memory usage

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I fixed many long living bugs in the UTF-7 codec in the past, and I remember that we fixed bugs introduced by using _PyUnicodeWriter or _PyBytesWriter many months after changing the code. Since the UTF-7 codec is rarely used, there is a risk of introducing n

[issue28398] Return singleton empty string in _PyUnicode_FromASCII

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: > We should know what is the benefit of the patch before committing it. The purpose of the patch is to use the empty string singleton to reduce the memory footprint, instead of creating multiple empty (Unicode) string objects. -- _

[issue28736] multiprocessing.Lock() no longer has .acquire()

2016-11-18 Thread Eric Leadbetter
New submission from Eric Leadbetter: The documentation on the multiprocessing library in Python 3 uses Lock.acquire()/Lock.release() in the example for primitive synchronization (https://docs.python.org/3/library/multiprocessing.html#synchronization-between-processes). Lock() has been changed

[issue28398] Return singleton empty string in _PyUnicode_FromASCII

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I know that _PyUnicode_FromASCII() is called with size=0. But most callers call it only with size!=0. I didn't investigate further. We should know what is the benefit of the patch before committing it. Just "for consistency" is a weak argument itself. -

[issue28159] Deprecate isdst argument in email.utils.localtime

2016-11-18 Thread R. David Murray
R. David Murray added the comment: No, localtime does something subtly different, in that it will accept a naive datetime add the local timezone to it. Calling localtime() is also more convenient/readable than calling datetime.now().astimezone(). -- __

[issue28734] argparse: successive parsing wipes out nargs=? values

2016-11-18 Thread Adam Stewart
Adam Stewart added the comment: Works for me, thanks Wolfgang! -- resolution: -> not a bug status: open -> closed ___ Python tracker ___

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

2016-11-18 Thread Carl Dunham
Changes by Carl Dunham : -- nosy: +Carl Dunham ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue28734] argparse: successive parsing wipes out nargs=? values

2016-11-18 Thread Wolfgang Maier
Wolfgang Maier added the comment: try this: parser.add_argument('file', nargs='?', default = argparse.SUPPRESS) I don't think this is a bug. The default for the default parameter is None so the behavior is consistent with the documentation. -- nosy: +wolma

[issue28731] _PyDict_NewPresized() creates too small dict

2016-11-18 Thread INADA Naoki
INADA Naoki added the comment: > This optimization affects only 6-element (and perhaps to less extend > 11-element) dicts. But in any case this is good enhancement. This affects when minused = (n*2/3)+1 .. n-1 (n=8, 16, ...) n=8: 6, 7 n=16: 11, 12, ..15 > Naoki, could you please make microben

[issue28735] Mock is equal to ANY but MagicMock is not

2016-11-18 Thread Rafael Jacinto Caricio da Fonseca
New submission from Rafael Jacinto Caricio da Fonseca: On Python 3.5.2 mock.Mock() is equal to mock.ANY, but mock.MagicMock() is not. Minimal example: In Python 3.5.2: >>> from unittest import mock >>> mock.Mock() == mock.ANY True >>> mock.ANY == mock.Mock() True >>> mock.MagicMock() == mock.AN

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-11-18 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Here's my try: force UTF-8 on Android as explained in msg281110. sys.getfilesystemencoding() is already UTF-8 since issue22747. Testing: 1. Starting up time 0.18~0.19s => 0.11~0.12s, on Android 6.0, ASUS ZE500KL (Qualcomm MSM8916 QuadCore 1.2GHz) 2. test_site p

[issue26928] _bootlocale imports locale at startup on Android, causing test_site to fail

2016-11-18 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Submitted a patch to issue28596 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue28531] Improve utf7 encoder memory usage

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "The performance of the UTF-7 codec is not important." Right. "Actually I'm going to propose replacing it with Python implementation." Oh. Sadly, PyUnicode_DecodeUTF7() is part of the stable ABI. Do you want to call the Python codec from th

[issue28694] tkinter interface to fontchooser

2016-11-18 Thread Lance Ware
Lance Ware added the comment: Not having any luck creating a patch. I have retrieved source, built python, put my fontchooser.py file (attached) in cpython\Lib\tkinter, done hg add and hg commit, but when I try to do hg diff it gives me nothing. -- Added file: http://bugs.python.org/fi

[issue26936] android: test_socket fails

2016-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: New patch using support.less_than_android_api(level). -- stage: patch review -> commit review Added file: http://bugs.python.org/file45534/test_socket_2.patch ___ Python tracker __

[issue28398] Return singleton empty string in _PyUnicode_FromASCII

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: To reduce the memory footprint, it's important that we reuse internal Unicode singletons. For the empty string singleton, you have two choices: * if length is equal to zero, return the singleton * create a string and then call unicode_result() unicode_result()

[issue28734] argparse: successive parsing wipes out nargs=? values

2016-11-18 Thread Adam Stewart
New submission from Adam Stewart: I'm writing a wrapper that optionally accepts a file and reads more options from that file. The wrapper then needs to pass all of these options and the file to another program (qsub). Here is a minimal example to reproduce the behavior I'm seeing: >>> import

[issue28159] Deprecate isdst argument in email.utils.localtime

2016-11-18 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks David :) So, I found that isdst was never added as method signature in the docs, but it is mentioned in the paragraph. https://docs.python.org/3.7/library/email.util.html?#email.utils.localtime The intention is still just to deprecate isdst argument, ri

[issue28730] __reduce__ not being called in dervied extension class from datetime.datetime

2016-11-18 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > On Nov 18, 2016, at 8:49 AM, Serhiy Storchaka wrote: > > But there are two drawbacks. It is not too late to make improvements. If you have specific proposals - please bring them up on the mailing list. -- __

[issue28159] Deprecate isdst argument in email.utils.localtime

2016-11-18 Thread R. David Murray
R. David Murray added the comment: At this point I think the deprecation warning will go into 3.7, but we should be able to remove it in 3.8. I think I'll probably keep the 'localtime' method and have it delegate it to astimezone, because frankly I would never be able to remember that that wa

[issue28731] _PyDict_NewPresized() creates too small dict

2016-11-18 Thread STINNER Victor
STINNER Victor added the comment: > Can I assume PY_SSIZE_T_MAX is 2**n-1? I think so. Add an assertion just to be sure :-) -- ___ Python tracker ___ ___

[issue28731] _PyDict_NewPresized() creates too small dict

2016-11-18 Thread INADA Naoki
INADA Naoki added the comment: Can I assume PY_SSIZE_T_MAX is 2**n-1? If so, I can define like: #define PyDict_MAXSIZE (PY_SSIZE_T/8+1) -- ___ Python tracker ___ ___

[issue28731] _PyDict_NewPresized() creates too small dict

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This optimization affects only 6-element (and perhaps to less extend 11-element) dicts. But in any case this is good enhancement. Naoki, could you please make microbenchmarks for 5- and 7-element dicts with your next patch? -- _

[issue28731] _PyDict_NewPresized() creates too small dict

2016-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > So how about more small, maximum presize? I don't know what is the benefit of this, but this change looks correct. The benefit of preresizing is vanishingly small for very large dicts. -- ___ Python tracker

  1   2   >