[issue24913] deque.index() overruns deque boundary

Raymond Hettinger added the comment: Larry, this may need to go into 3.5 if there is still an opportunity. -- assignee: rhettinger -> larry nosy: +larry priority: low -> high title: newblock() Uninitialized Variable -> deque.index() overruns deque boundary versions: +Python 3.6 ___

[issue24913] newblock() Uninitialized Variable

Changes by Raymond Hettinger : Added file: http://bugs.python.org/file40258/fix_deque_overrun.diff ___ Python tracker ___ ___ Python-bugs-list

[issue24912] The type of cached objects is mutable

Larry Hastings added the comment: As Python 3.5 Release Manager, my official statement is: Eek! -- priority: high -> release blocker ___ Python tracker ___ __

[issue18383] test_warnings modifies warnings.filters when running with "-W default"

Martin Panter added the comment: Florent’s manual reproducer is fixed by issue18383_34_2.diff, as is test___all__. And I think the new logic for changing the priority of the filter entries might be sound now. But it does seem like we are adding unnecessary complexity to the implementation just

[issue2786] Names in traceback should have class names, if they're methods

Ben Longbons added the comment: I made a minimal gist of my motivating code: https://gist.github.com/o11c/ce0c2ff74b87ea71ad46 -- ___ Python tracker ___ _

[issue24940] RotatingFileHandler uses tell in non-binary mode to determine size of the file in bytes

New submission from Ilya Kulakov: According to the most recent documentation: Return the current stream position as an opaque number. The number does not usually represent a number of bytes in the underlying binary storage. Therefore stream should be opened as 'ab' by using value of the en

[issue24912] The type of cached objects is mutable

Changes by Ned Deily : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue2786] Names in traceback should have class names, if they're methods

Ben Longbons added the comment: Code objects currently have no mutable fields. So what are you planning to do about things like: Foo = namedtuple('Foo', 'x y') def frob(self): return self.x + self.y # probably actually done via a @member(Foo) decorator # so adding more code here is not a pr

[issue2786] Names in traceback should have class names, if they're methods

Nick Coghlan added the comment: Moving this back to patch review while we consider the alternative approach of moving qualname storage into code objects, rather than continuing to transport qualnames separately. -- stage: commit review -> patch review _

[issue2786] Names in traceback should have class names, if they're methods

Nick Coghlan added the comment: Moving target version to 3.6 (since we're discussing adding a new public C API). This is an interesting problem, as seeing an expanding API like this (PyEval_EvalCode -> PyEval_EvalCodeEx -> PyEval_EvalCodeEx2) suggests to me that we actually have a missing abst

[issue24790] Idle: improve stack viewer

Terry J. Reedy added the comment: Please post a 'checkpoint' patch with all changes so far, even though it has the 'other globals' problem. Then look at the UI parts of Debugger.py. It has a Stackviewer class that subclasses ScrolledLIst instead of TreeWidget and a Namespaceviewer class curre

[issue24911] Context manager of socket.socket is not documented

Martin Panter added the comment: IMO the change notice for create_connection() should be moved to apply to the “socket” class, perhaps the “Socket Objects” section. Issue 9794 looks like context manager support was added specifically for create_connection(), however any socket object, no matte

[issue24920] shutil.get_terminal_size throws AttributeError

Isaac Levy added the comment: I guess users need to check standard streams for None. There's not many uses of stream attributes in core libs. Maybe catch should be Exception -- since it's documented to return a fallback on error. -- ___ Python trac

[issue21112] 3.4 regression: unittest.expectedFailure no longer works on TestCase subclasses

Changes by Robert Collins : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue23183] timeit CLI best of 3: undocumented output format

Changes by Robert Collins : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue23552] Have timeit warn about runs that are not independent of each other

Changes by Robert Collins : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 3.5 ___ Python tracker ___ _

[issue23552] Have timeit warn about runs that are not independent of each other

Roundup Robot added the comment: New changeset 2e9cf58c891d by Robert Collins in branch 'default': Issue #23552: Timeit now warns when there is substantial (4x) variance https://hg.python.org/cpython/rev/2e9cf58c891d -- nosy: +python-dev ___ Python tr

[issue23597] Allow easy display of local variables in log messages?

Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22936] traceback module has no way to show locals

Robert Collins added the comment: This itself is fixed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24788] HTTPException is derived from Exception instead of IOError

Martin Panter added the comment: Regarding CannotSendRequest: HTTPConnection will connect again with a new socket if a previous response will close the old connection. See a few lines below where you linked: “If point (2) is true, then we . . . will open a new [socket] when a new request is ma

[issue24788] HTTPException is derived from Exception instead of IOError

Pastafarianist added the comment: I agree that the five exception types you mentioned (UnknownProtocol, UnknownTransferEncoding, IncompleteRead, BadStatusLine, LineTooLong) should be derived from IOError. EOFError is probably not a good choice here. It's not something I would expect to see in

[issue24829] Use interactive input even if stdout is redirected

Martin Panter added the comment: In Linux, the original stdin, stdout, stderr file descriptors refer to the same console by default, and you use normal file reads and writes on them. In Linux when Python uses Gnu Readline, the displayed input characters are indeed written to the original stdou

[issue23144] html.parser.HTMLParser: setting 'convert_charrefs = True' leads to dropped text

Robert Collins added the comment: @ezio - you seem busy, so I'll commit this next week if its still pending. -- ___ Python tracker ___ ___

[issue24939] Remove unicode_format.h from stringlib

Changes by Eric V. Smith : -- title: Remove unicode_fornat.h from stringlib -> Remove unicode_format.h from stringlib ___ Python tracker ___

[issue21167] float('nan') returns 0.0 on Python compiled with icc

Roundup Robot added the comment: New changeset d93bb3d636cf by R David Murray in branch '3.5': #21167: Fix definition of NAN when ICC used without -fp-model strict. https://hg.python.org/cpython/rev/d93bb3d636cf New changeset c1523d5dee3c by Larry Hastings in branch '3.5': Merged in bitdancer/cp

[issue24867] Asyncio Task.get_stack fails with native coroutines

Roundup Robot added the comment: New changeset 595614c08eeb by Yury Selivanov in branch '3.5': Issue #24867: Fix asyncio.Task.get_stack() for 'async def' coroutines https://hg.python.org/cpython/rev/595614c08eeb New changeset 9b28f41f1353 by Larry Hastings in branch '3.5': Merged in 1st1/cpython

[issue24847] Can't import tkinter in Python 3.5.0rc1

Roundup Robot added the comment: New changeset dc9bdddca59b by Steve Dower in branch '3.5': Issue #24847: Removes vcruntime140.dll dependency from Tcl/Tk. https://hg.python.org/cpython/rev/dc9bdddca59b New changeset b77ceefc34ff by Larry Hastings in branch '3.5': Merged in stevedower/cpython350

[issue24769] Interpreter doesn't start when dynamic loading is disabled

Roundup Robot added the comment: New changeset 931593401e3e by Larry Hastings in branch '3.5': Issue #24769: Interpreter now starts properly when dynamic loading https://hg.python.org/cpython/rev/931593401e3e -- nosy: +python-dev ___ Python tracker <

[issue24939] Remove unicode_fornat.h from stringlib

New submission from Eric V. Smith: Objects/stringlib/unicode_format.h does not belong in stringlib. Back when it was originally written for 2.x, it used stringlib to provide the str and unicode versions of str.format, str.__format__, int.__format__, etc. However, in 3.x, and especially with PE

[issue24769] Interpreter doesn't start when dynamic loading is disabled

Larry Hastings added the comment: I have merged it forward into 3.5.1 and 3.6. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24934] django_v2 benchmark not working in Python 3.6

Florin Papa added the comment: Thank you all for your feedback on this matter. According to the docs, starting from version 3.4, getfullargspec() is based on signature(), therefore the performance impact would not differ from the proposed implementation. I will check if a newer version of dja

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: Thanks! I'll take good care of it :) Give me a few days to prepare the docs change; this isn't very high priority. -- ___ Python tracker ___

[issue24829] Use interactive input even if stdout is redirected

R. David Murray added the comment: It's the one we started with, and the one in most common use. I don't even know if there would be a problem. The thing to do would be to try it and find out (on both linux and windows). -- ___ Python tracker

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Alecsandru Patrascu added the comment: Thank you for the clarifications! Your point make sense, we don't want to exclude clang environments. I will analyze this and post some patches once I'm done with it. -- ___ Python tracker

[issue24829] Use interactive input even if stdout is redirected

Adam Bartoš added the comment: Behavior of which readline? GNU readline? Note that it is only one particular implmentation on one particular platform while Python should be as multiplatform as possible / viable. And what behavior it is? More precisely, what incorrect behavior in Linux would i

[issue24934] django_v2 benchmark not working in Python 3.6

Antoine Pitrou added the comment: According to the docs, getargspec() should be replaced with getfullargspec(), which returns a compatible named tuple. This would probably also minimize the performance impact of the patch (I'm not sure getargspec() is in the critical path, but let's be careful

[issue24938] Measure if _warnings.c is still worth having

Brett Cannon added the comment: I should also mention the other motivating factor was providing C access to the warnings system, but once again importlib blazed that trail already by providing a C API which simply uses the Python code. -- ___ Python

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Brett Cannon added the comment: So there are two approaches I see to solving this whole thing. One is for there to be a slight divergence between the C code and the Python code. For _warnings.warn(), nothing changes. For warnings.warn(), though, it does the expected frame skipping. This would

[issue24938] Measure if _warnings.c is still worth having

New submission from Brett Cannon: _warnings.c was initially created to help with startup performance. It turned out to be a tricky bit of code to get right to continue to support the Python version of the module. But now that we live in a world where we have startup benchmarks instead of hunc

[issue24938] Measure if _warnings.c is still worth having

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue24829] Use interactive input even if stdout is redirected

R. David Murray added the comment: Well, I think we're constrained by the behavior of readline here. -- ___ Python tracker ___ ___ Pyt

[issue24829] Use interactive input even if stdout is redirected

Adam Bartoš added the comment: R. David Murray: I understand that the behavior of programs differ if stdout is redirected. I just claim that at least in Windows, stdin and stdout are completely independent, so redirecting *stdout* shouldn't affect how data are read from *stdin*. I know that U

[issue24927] multiprocessing.Pool hangs forever on segfault

Jonas Obrist added the comment: I've added a patch that would simply warn the user if a worker exits prematurely. -- keywords: +patch Added file: http://bugs.python.org/file40257/patch.diff ___ Python tracker

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Brett Cannon added the comment: I'm asking if that's possible. For instance I set $CC to clang explicitly on OS X as I install the latest version of LLVM through Homebrew to get better compiler warnings for Python. It would be great if we could avoid leaving all clang users out unless they hap

[issue24829] Use interactive input even if stdout is redirected

R. David Murray added the comment: The behavior of programs definitely differs if stdout is redirected. For example on linux a program might output color codes to stdout normally, but if it is redirected to a non-tty, no color codes would be output. Windows console handling of unicode is an e

[issue24829] Use interactive input even if stdout is redirected

Adam Bartoš added the comment: I really don't know how stdio in console in Linux works. In my package https://github.com/Drekin/win-unicode-console I set custom sys.std* streams and a custom readline hook to support Unicode in Python run in Windows console. If I run `py` with my fixes enabled,

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Alecsandru Patrascu added the comment: Sorry, it was a typo. I made a correction to it. I will also modify to -m flag, instead of the explicit file execution. Regarding the clang/gcc support, in v03 version of patches, GCC is supported. On Linux is straightforward. On Mac I see that the defau

[issue24934] django_v2 benchmark not working in Python 3.6

R. David Murray added the comment: Florin is covered by the Intel corporate agreement. I've updated his user record accordingly. -- nosy: +r.david.murray stage: patch review -> type: -> crash ___ Python tracker

[issue24929] _strptime.TimeRE should not enforce range in regex

R. David Murray added the comment: And it does not make sense for time, since time.strptime does no additional validation, it just returns the result returned by _strptime. -- nosy: +r.david.murray ___ Python tracker

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Larry Hastings added the comment: Given that capsulethunk is only needed for 2.6 (and previous), and those versions are no longer maintained by the Python core community, yes I'd be happy for you to take over maintainership and host it externally. I'm sure we could change the documentation in

[issue24937] Multiple problems in getters & setters in capsulethunk.h

Petr Viktorin added the comment: Note: I'm including a tested (+fixed, now) copy of capsulethunk.h in my set of Python3 C extension porting helpers, http://py3c.readthedocs.org Unfortunately the tests can't be added to CPython, because they need to run on Python 2.6 to be useful. That makes me

[issue24936] Idle: handle 'raise' properly when running with subprocess (2.7)

New submission from Terry J. Reedy: With one process (installed 2.7.10, -n option): >>> raise Traceback (most recent call last): File "", line 2, in TypeError: exceptions must be old-style classes or derived from BaseException, not NoneType With subprocess (default option): >>> raise Traceb

[issue24937] Multiple problems in getters & setters in capsulethunk.h

New submission from Petr Viktorin: In https://docs.python.org/3/howto/cporting.html#cobject-replaced-with-capsule (added in issue13053): 1) __PyCapsule_GetField is defined as:: #define __PyCapsule_GetField(capsule, field, default_value) ... but called as:: __PyCapsule_GetField(capsul

[issue24935] LDSHARED is not set according when CC is set.

Mike Frysinger added the comment: looks like the patch was reversed, but otherwise should be clear what we're going for -- ___ Python tracker ___ ___

[issue24934] django_v2 benchmark not working in Python 3.6

Brett Cannon added the comment: The proposed patch directly modifies the copy of Django in the benchmark suite which isn't acceptable; we purposefully don't modify the project code we pull in for benchmark consistency and ease of maintenance. It would be better to make sure a newer version of

[issue24935] LDSHARED is not set according when CC is set.

Changes by Mike Frysinger : -- nosy: +vapier ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24932] Migrate _testembed to a C unit testing library

Brett Cannon added the comment: Someone is going to think of [googletest] (https://github.com/google/googletest) and then realize that it is a C++ test suite and thus won't work unless you explicitly compile Python for C++. -- nosy: +brett.cannon __

[issue24929] _strptime.TimeRE should not enforce range in regex

Brett Cannon added the comment: Do realize that the strptime code is shared with time.strptime() and so this change would have to make sense in both contexts. This change can also only happen in Python 3.6 because it is backwards-incompatible due to people potentially already catching the prev

[issue24913] newblock() Uninitialized Variable

Stefan Krah added the comment: I guess that in the test case the stop parameter is set to 4 in deque_index(), but it should be clamped to 3. -- nosy: +skrah ___ Python tracker __

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Brett Cannon added the comment: Any specific reason the v3 patch, Alecsandru, is listed as against 3.5 in the filename? Or is that just a typo? P.S.: I did another review asking about explicit Clang support and also supporting Greg's request to use `-m test` instead of the explicit file execu

[issue24913] newblock() Uninitialized Variable

John Leitch added the comment: The "exception analysis" is output from the WinDbg !analyze command run on a crash where access to the uninitialized memory ultimately corrupted the instruction pointer, leading to a data execution prevention crash. That's why the disassembly is junk--the IP is n

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40254/python2.7-pgo-v03.patch ___ Python tracker ___ ___ Python-bugs-l

[issue24935] LDSHARED is not set according when CC is set.

New submission from yunlian: On linux, when CC is set, we expect that the LDSHARED is set accordingly. Currently, only on OS X, the LDSHARED is set properly. Below is the proposed patch --- a/Lib/distutils/sysconfig.py2015-08-24 11:58:37.265683872 -0700 +++ b/Lib/distutils/sysconfig.py

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Alecsandru Patrascu added the comment: I modified the patches to be compatible with both environments. The new versions modify the configure.ac file also, therefore you will need to run "autoconf" by hand. Also, in case of MaOS you will need to have llvm-profdata installed and in your path. I

[issue24915] Profile Guided Optimization improvements (better training, llvm support, etc)

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40255/python3.5-pgo-v03.patch ___ Python tracker ___ ___ Python-bugs-l

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

Benjamin Peterson added the comment: Evidently, the recv code doesn't know anything about MSG_TRUNC, which causes it to do incorrect things when the output length is greater than the buffer length. -- nosy: +benjamin.peterson ___ Python tracker

[issue24913] newblock() Uninitialized Variable

Raymond Hettinger added the comment: I'm find the "exception analysis" to be unreadable. Have you found any place in the deque code where the uninitialized memory actually gets accessed? -- priority: normal -> low ___ Python tracker

[issue24913] newblock() Uninitialized Variable

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

Matthias Bussonnier added the comment: # unittest (Pending)DeprecationWarning are already enabled if no -W flags are given. # doctest We enable the DW in REPL only if originate from `__main__`, this seem to be painful to do in doctest, as each doctest execute in a module that have the name

[issue3548] subprocess.pipe function

R. David Murray added the comment: Thanks for being willing to work on it. If what is wanted is a way to pipeline shell commands, Python already has that functionality in the pipes module. So the interesting thing here would be pipelining *non* shell commands, to avoid the shell exploits that

[issue24769] Interpreter doesn't start when dynamic loading is disabled

Larry Hastings added the comment: That's correct, it's just in 3.5.0 at the moment. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue24769] Interpreter doesn't start when dynamic loading is disabled

Jeffrey Armstrong added the comment: I pulled the 3.5 branch a few minutes ago, and the patch isn't present. Has it not been pushed to hg.python.org? -- ___ Python tracker ___

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

Andrey Wagin added the comment: sendto(4, "asdfasdfsadfasdfsdfsadfsdfasdfsd"..., 42, 0, NULL, 0) = 42 recvfrom(3, "a\0n\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\5\0\0\0\0\0\0\0\2\0\0\0"..., 1, MSG_TRUNC, NULL, NULL) = 42 I think the exit code is interpreted incorrectly. In this case it isn't equal t

[issue3548] subprocess.pipe function

Matheus Vieira Portela added the comment: I just found this open issue and I can work on it. What is left to do before closing it? -- nosy: +matheus.v.portela ___ Python tracker

[issue10466] locale.py resetlocale throws exception on Windows (getdefaultlocale returns value not usable in setlocale)

Changes by Gabi Davar : -- nosy: +Gabi.Davar ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24934] django_v2 benchmark not working in Python 3.6

New submission from Florin Papa: Hi All, My name is Florin Papa and I work in the Server Languages Optimizations Team at Intel Corporation. I would like to submit a patch that solves compatibility issues of the django_v2 benchmark in the Grand Unified Python Benchmark. The django_v2 benchmar

[issue24808] PyTypeObject fields have incorrectly documented types

R. David Murray added the comment: Congratulation on your first commit, Martin :) Dropping the python2 reference was the right call: the python3 docs are supposed to be a "fresh start" and there are very few places where they mention python2. -- nosy: +r.david.murray

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

R. David Murray added the comment: I'm not sure that is acceptable. "Just changing it to a file" could break an application's structure that is depending on being able to use stdin to run scripts. As one example, vim scripts can embed python code...now, what VIM does behind the scenes with t

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

Changes by R. David Murray : -- keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 2.7 ___ Python tracker ___ __

[issue24850] syslog.syslog() does not return error when unable to send the log

R. David Murray added the comment: Ah, in that case there aren't any errors for us to return, so this is moot. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue24790] Idle: improve stack viewer

Can İbanoğlu added the comment: First of all, sorry for the late reply. I did try the solution you have proposed which removes the need to click to expand the items under globals/locals but as I understand it, you have something more in mind for the whole stackviewer UI. Should I still submit

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

New submission from Andrey Wagin: In [1]: import socket In [2]: sks = socket.socketpair(socket.AF_UNIX, socket.SOCK_DGRAM) In [3]: sks[1].send("asdfasdfsadfasdfsdfsadfsdfasdfsdfasdfsadfa") Out[3]: 42 In [4]: sks[0].recv(1, socket.MSG_PEEK | socket.MSG_TRUNC) Out[4]: 'a\x00\x00\x00\xc0\xbf8\x0

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

Matthias Bussonnier added the comment: ok, thanks. I'll remove the is tty ans push docs changes on a new patch. I'll see if I can figure out how to enable DW by default in unittest and doctest. Thanks ! -- ___ Python tracker

[issue22680] Blacklist FunctionTestCase from test discovery

Changes by Martin Panter : -- dependencies: +Add means to mark unittest.TestCases as "do not load". ___ Python tracker ___ ___ Python-

[issue14534] Add means to mark unittest.TestCases as "do not load".

Martin Panter added the comment: Issue 22680, about blacklisting FunctionTestCase, was closed as a duplicate of this. However the patch there has a useful test case for FunctionTestCase that could be merged with any future work here. -- stage: patch review -> needs patch versions: +Pyt

[issue24902] http.server: on startup, show host/port as URL

Changes by Martin Panter : -- nosy: +martin.panter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

Aymeric Augustin added the comment: Since a better solution seems to be around the corner, I'm withdrawing my proposal. I'm attaching the current state of my patch. It isn't functional. Mostly it proves that my API proposal is very inconvenient to implement in C. That's why I kept it around f