Brett Cannon added the comment: The proposed patch directly modifies the copy of Django in the benchmark suite which isn't acceptable; we purposefully don't modify the project code we pull in for benchmark consistency and ease of maintenance.
It would be better to make sure a newer version of Django is fixed upstream, pull in the newer version to the benchmark suite, and then create a django_v3 benchmark using that newer version while removing the django_v2 benchmark from the default set of benchmarks (if not fully remove it). And can you sign the contributor agreement, Florin? ---------- nosy: +brett.cannon, pitrou stage: -> patch review type: crash -> _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24934> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
