[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-15 Thread Peter McCormick
Peter McCormick added the comment: This definitely works for the _socket.listen use case! In terms of generating such a signature using Argument Clinic, currently this is required: backlog: int(py_default="builtins.min(SOMAXCONN, 128)", c_default="Py_MIN(SOMAXCONN, 128)") = 000 The atta

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread paul j3
paul j3 added the comment: It'll take me a while to work through this proposed patch. My first reaction is that I am uncomfortable with adding an attribute to all parsers just to implement this help feature. For one thing it seems to cross functionality boundaries. I need to review how subp

[issue23970] Update distutils.msvccompiler for VC14

2015-04-15 Thread Tim Golden
Tim Golden added the comment: Adding Paul Moore as he's essentially the intersection between distutils & Windows -- nosy: +paul.moore ___ Python tracker ___

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Christian Heimes
Christian Heimes added the comment: Around PyCon it might take a little longer than a week. IIRC Ewa does the paper work. She is also on the organizing committee of PyCon. -- ___ Python tracker

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-15 Thread Martin Panter
Martin Panter added the comment: New patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: Put HeaderError back in and removed the extra XHDTYPE. We can get more input on the type constants as well as the undocumented but exported items. Could just be cleared up with some edits to documentation. -- Added file: http://bugs.python.org/file39065/

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Changes by Joel Taddei : Removed file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch ___ Python tracker ___ ___ Python-bugs-li

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Oh I see, TarIter is listed underneath a comment saying “Exported Classes”, and main() is listed underneath “exported functions”. If they are indeed meant to be exported, they should probably also be documented. Otherwise, maybe we can just add another comment

[issue23354] Loading 2 GiLOC file which raises exception causes wrong traceback

2015-04-15 Thread Ethan Furman
Ethan Furman added the comment: Considering how rare (hopefully!) files of that size are, I wouldn't be adverse to a "won't fix" resolution. -- priority: normal -> low ___ Python tracker __

[issue23354] Loading 2 GiLOC file which raises exception causes wrong traceback

2015-04-15 Thread Ethan Furman
Ethan Furman added the comment: Considering how rare (hopefully!) files of that size are, I wouldn't be adverse to a "won't fix" resolution. -- ___ Python tracker ___ __

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: Thanks for the feedback. I was unsure how to proceed with the undocumented items that seemed to be categorized as exported. Thanks for catching ENCODING & *_FORMAT. -- Added file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch __

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-15 Thread Larry Hastings
Larry Hastings added the comment: While cleaning this up I noticed that es# and et# should both require "nullable". Fixed that too. I sure hope it's all correct now! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed __

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4f74452a11e5 by Larry Hastings in branch 'default': Issue #23935: Argument Clinic's understanding of format units https://hg.python.org/cpython/rev/4f74452a11e5 -- nosy: +python-dev ___ Python tracker

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Dave Sawyer
Dave Sawyer added the comment: I can add some more tests to bring up the coverage, but wanted to get reviewer opinion on the direction of this before doing more work. -- hgrepos: +305 Added file: http://bugs.python.org/file39063/zipfile_filter.patch

[issue5038] urrlib2/httplib doesn't reset file position between requests

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Actually, I do not think any “Expect: 100-continue” headers are explicitly sent by the Python standard library. The Python client does not support waiting for a “100 Continue” response; see Issue 1346874. There is Issue 23740 opened about fixing or clarifying t

[issue23740] http.client request and send method have some datatype issues

2015-04-15 Thread Martin Panter
Martin Panter added the comment: The priority of file-like objects versus bytes-like and iterable objects should be well defined. See Issue 5038: mmap objects seem to satisfy all three interfaces, but the result may be different depending on the file position. -- _

[issue23670] Modifications to support iOS as a cross-compilation target

2015-04-15 Thread Russell Keith-Magee
Russell Keith-Magee added the comment: Hi Matthias: * The libffi situation on iOS is much the same as it is on OS/X - it needs to be pre-generated. This can't be driven by the existing build system - libffi's Makefile requires a separate pre-generation step. There's certainly potential for r

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Changes by Joel Taddei : Removed file: http://bugs.python.org/file39051/Issue23883_tarfile_all.patch ___ Python tracker ___ ___ Python-bugs-li

[issue1346874] httplib simply ignores CONTINUE

2015-04-15 Thread Martin Panter
Martin Panter added the comment: This seems more like a new feature than a bug fix to me. Currently the behaviour is the same whether “Expect: 100-continue” is requested or not. According to , the client does not have to wait any specific length of

[issue23670] Modifications to support iOS as a cross-compilation target

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: not reviewing everything, but - libffi_ios* will be bitrot. I understand that you'll need an unreleased version, however I would much prefer that any additional patches are added in the repo, and maybe then patching libffi from the iOS build system

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Christie
Christie added the comment: @r.david.murray and @flipmcf: I've audited all test modules using sys.executable for a starting point, and these tests look like they could benefit from helper methods to invoke python (probably the ones in script_helper, but we may want to create others if the use

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Ned Deily
Ned Deily added the comment: "what about iOS? isn't __APPLE__ there defined too?" It is but we currently don't have any iOS-specific checks snywhere in CPython. I have an additional patch to handle iOS here but I didn't want to break builds until adding full support for iOS as part of Issue23

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: what about iOS? isn't __APPLE__ there defined too? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue23903] Generate PC/python3.def by scraping headers

2015-04-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 32c24eec035f by Ned Deily in branch 'default': Issues #22980, 23969: For OS X, use PEP 3149-style file names for extension https://hg.python.org/cpython/rev/32c24eec035f -- ___ Python tracker

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +rhettinger type: behavior -> performance ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread Akshit Khurana
Akshit Khurana added the comment: Updated patch with review changes -- Added file: http://bugs.python.org/file39062/auth10.patch ___ Python tracker ___ ___

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Dave Sawyer
Dave Sawyer added the comment: The zipfile way to delete or rename would be to just change the index. It really doesn't want to be re-written as it is designed to span disks. Many old versions of files can be scattered within the zip. In addition self-extracting zip files will have executable

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz : Added file: http://bugs.python.org/file39060/indexerror_all.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Added some review comments. I think the urllib documentation does not really explain how to *use* these classes, and it should, but that is a separate issue. -- ___ Python tracker

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Larry Hastings
New submission from Larry Hastings: Matt Mackall brought this over to me today. If list "l" has one million pairs and you do dict(l) it creates the dict, then resizes it to a million elements, then starts adding name/value pairs. But since it's sized to a million elements, it gets beyond it

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc0e79387a3a by Berker Peksag in branch 'default': Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a. https://hg.python.org/cpython/rev/fc0e79387a3a -- nosy: +python-dev ___ Python tr

[issue22278] urljoin duplicate slashes

2015-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Regarding tarfile: Two of the extra errors are documented, so I agree they should be added: * tarfile.StreamError * tarfile.ExtractError However I’m not so sure about main(), TarIter, and the HeaderError subclasses. They aren’t mentioned in the documentation.

[issue2292] Missing *-unpacking generalizations

2015-04-15 Thread Neil Girdhar
Changes by Neil Girdhar : Added file: http://bugs.python.org/file39059/starunpack41.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now the review button appears for the big patch. Lets see if another submission makes it appear for the smaller version. -- ___ Python tracker ___

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Augie Fackler
Augie Fackler added the comment: Changes to 3.4 aren't going to help Mercurial. Given that bytes formatting is new in 3.5, I won't be attempting a port that supports a version of Python 3 any older than 3.5. At this point, just a difflib.diff_bytes method in 3.5 would be sufficient to satisfy

[issue23970] Update distutils.msvccompiler for VC14

2015-04-15 Thread Steve Dower
New submission from Steve Dower: Because of the compiler change, we need to rework the detection of MSVC for Python 3.5. I took the opportunity to clean up the entire module and remove msvc9compiler, and updated the tests. -- assignee: steve.dower components: Windows files: msvccompile

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: I tried the [Create Patch] button. Two problems: the result is about 90% concerned with other issues; it is not reviewable on Rietveld. I will unlink it and upload a cut-down version. Wtiht the test changes suggested by Berker, I agree that it is time to app

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz : -- keywords: +patch Added file: http://bugs.python.org/file39055/indexerror.patch ___ Python tracker ___ ___

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz : Added file: http://bugs.python.org/file39056/indexerror.tests ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Arnon has signed the CLA at PyCon, it just hasn't been processed yet. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 132b5376bf34 by Steve Dower in branch 'default': Issue #4254: Adds _curses.update_lines_cols() Patch by Arnon Yaari https://hg.python.org/cpython/rev/132b5376bf34 -- nosy: +python-dev ___ Python tracker

[issue22137] Test imaplib API on all methods specified in RFC 3501

2015-04-15 Thread Maciej Szulik
Maciej Szulik added the comment: Milan one more thing to change in your patch, in all your TCs you're modifying client state, I mean this part: # lets cheat a bit here: client.state = 'SELECTED' It's OK to do that on the mocked server, but this is not acceptable doing on the tested library. I

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: @rdm: I'm pretty sure you're right about nobody noticing. :) Make it so! -- ___ Python tracker ___ ___

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 948745d0d9cf by doko in branch 'default': #22980: fix triplet configure test for powerpc-linux-gnu https://hg.python.org/cpython/rev/948745d0d9cf -- ___ Python tracker

[issue22189] collections.UserString missing some str methods

2015-04-15 Thread Joe Jevnik
Joe Jevnik added the comment: I have added a patch to add these to UserString. I also wrote a test case that would check the UserString, UserList, and UserDict's methods to make sure that new methods to str, list, or dict (or the removal of one of those methods from the User* version) will cau

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Changes by Terry J. Reedy : Added file: http://bugs.python.org/file39053/13161c1d9c5f.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: namespaces are a honkin' great idea I don't have enough information to say that 'script_helper' is the right name for the namespace, tho. -- ___ Python tracker _

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Arnon - we'll need you to fill out https://www.python.org/psf/contrib/contrib-form/ before we can merge this patch in. (The dev guide isn't clear on whether trivial patches are okay, but the advice I was given is that we should have a CLA for everything.) --

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Oh, I forgot to say that the patch looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Barry, would you be OK with just applying this to 3.5? We can add a porting note to whatsnew. My guess, though, is that no one is going to notice. -- nosy: +r.david.murray ___ Python tracker

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset e55cc0834e9c by R David Murray in branch 'default': #23949: Improve tuple unpacking error messages. https://hg.python.org/cpython/rev/e55cc0834e9c -- nosy: +python-dev ___ Python tracker

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

2015-04-15 Thread Alex Lord
Changes by Alex Lord : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

2015-04-15 Thread Alex Lord
Alex Lord added the comment: I've added a set of tests which test the insert or [algorithm] branch of sqlite. It took some getting used to python.sqlite3's transaction model but I think I have a much better understanding now. -- keywords: +patch Added file: http://bugs.python.org/file3

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: now fixed on the trunk. opened a new issue #23969 for setting the SOABI on MacOSX. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread John Ehresman
John Ehresman added the comment: Interesting -- I didn't know about removing the ignore flag in the child process. The question is whether this is close enough to the kill w/ SIGINT behavior on unix to use the same name. I think that there are enough differences to warrant a Windows specific

[issue1284316] Win32: Security problem with default installation directory

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Closing this as fixed, as the discussions I've had at PyCon have largely suggested that the fix I've implemented is good. In short: * the default (obvious) install will be per-user only into %LocalAppData%\Programs\Python\Python35 - fully modifiable by whoever in

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread eryksun
eryksun added the comment: > Which python level signal handler will CTRL_BREAK_EVENT > trigger? The CRT maps it to a non-standard signal, SIGBREAK (21). It's defined in the signal module. > GenerateConsoleCtrlEvent has different limitations for > CTRL_BREAK_EVENT and CTRL_C_EVENT according t

[issue22411] Embedding Python on Windows

2015-04-15 Thread Steve Dower
Steve Dower added the comment: The 3.5 installer contains the option to install the debug binaries, so that side is solved and I'm closing this as fixed. In the video at https://www.youtube.com/watch?v=D9RlT06a1EI I demonstrate how you can build a debug EXE against a release python34.dll witho

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-15 Thread Ryan Gonzalez
Ryan Gonzalez added the comment: Can you try to see exactly *which* line of the function is segfaulting? -- ___ Python tracker ___ ___

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ram Rachum
Ram Rachum added the comment: Looking forward to your patch Ofer! Thanks for working on this! -- ___ Python tracker ___ ___ Python-bug

[issue19933] Round default argument for "ndigits"

2015-04-15 Thread Steve Dower
Changes by Steve Dower : -- resolution: -> fixed status: open -> closed versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___

[issue19933] Round default argument for "ndigits"

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3cc75b1000b by Steve Dower in branch 'default': Issue 19933: Provide default argument for ndigits in round. Patch by Vajrasky Kok. https://hg.python.org/cpython/rev/e3cc75b1000b -- nosy: +python-dev ___

[issue23217] help() function incorrectly captures comment preceding a nested function

2015-04-15 Thread Raúl Cumplido
Raúl Cumplido added the comment: I am not sure what the expected behavior is. Based on the code on pydoc.py we can find: def getdoc(object): """Get the doc string or comments for an object.""" result = inspect.getdoc(object) or inspect.getcomments(object) So if the doc string is not fou

[issue15625] Support u and w codes in memoryview

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Closing sounds good to me -- nosy: +steve.dower resolution: -> out of date status: open -> closed ___ Python tracker ___ _

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Ofer Schwarz added the comment: I'm working on this now (patch hopefully coming soon), and I've hit an interesting issue: PySequence methods take care of negative indexes by adding +len before calling the subclass method (s.t. -1 becomes len-1 etc.). This means that if the subclass raises an e

[issue15625] Support u and w codes in memoryview

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: The documentation already specifies that 'u' is deprecated and doesn't mention the 'w' code. I think we can close this issue. -- nosy: +wiggin15 ___ Python tracker __

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-15 Thread Joe Jevnik
Joe Jevnik added the comment: I can look into rewriting the framework to use multiprocessing; however, should we split this into a separate issue or block this one until that work is done. -- ___ Python tracker ___

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Ned Deily
Changes by Ned Deily : -- assignee: -> ned.deily components: +Build, Macintosh stage: -> needs patch versions: +Python 3.5 ___ Python tracker ___ __

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Matthias Klose
New submission from Matthias Klose: split out from http://bugs.python.org/issue22980#msg232065 please consider setting the SOABI for MacOSX. Afaics MacOSX is now the only major platform not setting these, at least including the SOABI. The idea is that it would be possible to ship "fat" wheels

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: I took care of the tarfile module. Added the following according to the first message: tarfile.CompressionError tarfile.HeaderError tarfile.ReadError tarfile.open The following were included in __all__ that were not explicitly mentioned in the first message but

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Post-review - new patch -- Added file: http://bugs.python.org/file39050/issue18128.patch ___ Python tracker ___ __

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

2015-04-15 Thread Matthias Klose
New submission from Matthias Klose: Currently there is only one platform directory for all linux architectures, there are two reasons to have a separate directory for each architecture: - the contents of the files in this directory differ (most prominent case are the RTLD_* constants on var

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Adding a test that only calls the function. -- Added file: http://bugs.python.org/file39048/issue4254-2.diff ___ Python tracker ___

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset df6c73f0e375 by doko in branch 'default': - #22980: fix typo in Lib/test/test_sysconfig.py triplet test https://hg.python.org/cpython/rev/df6c73f0e375 -- ___ Python tracker

[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-15 Thread Larry Hastings
New submission from Larry Hastings: Peter's working on converting socket to use Argument Clinic. He had a default that really should look like this: min(SOME_SOCKET_MODULE_CONSTANT, 128) "min" wasn't something we'd needed before. I thought about it and realized we could do a much better

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 11c4f3f936e7 by doko in branch 'default': - Issue #22980: Under Linux, GNU/KFreeBSD and the Hurd, C extensions now include https://hg.python.org/cpython/rev/11c4f3f936e7 -- ___ Python tracker

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Sorry, I got confused (which proves the point of the ticket :)) * the "need more than 3 values" error message wasn't wrong, just confusing. * Including "into starred target" in the message was incorrect, I removed it. * The message with "expected at least ..." (when

[issue16864] sqlite3.Cursor.lastrowid isn't populated when executing a SQL REPLACE statement

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Made some review comments. There also needs to be a documentation change since the docs currently say it is set for insert only. There should be a .. versionchanged directive. This may be small enough not to pass the what's new threshold, but I'd rather ad

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread Akshit Khurana
Akshit Khurana added the comment: Adding a patch for Python 3+ Some notes: * Adding a new password manager to handle this case * The new handler added in issue 19494 had couple of issues * test passes even if we use the old handler in added test * uses `request.host` instead of `request.ful

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread John Ehresman
John Ehresman added the comment: GenerateConsoleCtrlEvent has different limitations for CTRL_BREAK_EVENT and CTRL_C_EVENT according to MSDN; I was referring to the CTRL_C_EVENT limitations. Which python level signal handler will CTRL_BREAK_EVENT trigger? -- __

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread eryksun
eryksun added the comment: > it only works if the the target process id is 0 and then it > generates the signal in all processes that share the console. You can target a process group, which is a subset of the console's attached processes. That's why the console host, conhost.exe, routes dispa

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread R. David Murray
R. David Murray added the comment: This patch looks good to me, but I did not go through the argparse logic fully. Paul, can you review this and make sure itliteral_eval makes sense? There is a small concern about user code that provides a Mapping for choices having an attribute collision on

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: I'm adding patch without the update to Misc/NEWS. I'm not sure why, but the curses doc refers to LINES and COLS as "environment variables". In the doc change I referred to them as just "variables" and used the notation that works for linking to them, using :envva

[issue13940] imaplib: Mailbox names are not quoted

2015-04-15 Thread Maciej Szulik
Maciej Szulik added the comment: Joe is correct, according to the spec the names containing special chars (atom-specials) require names to be quoted (https://tools.ietf.org/html/rfc3501#section-5.1): 1)Any character which is one of the atom-specials (see the Formal Syntax) wil

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari : Added file: http://bugs.python.org/file39043/issue23949-3.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-04-15 Thread Larry Hastings
Larry Hastings added the comment: If * the diff looks clean * it compiles without any *new* (sigh) errors, and * it passes the unit test suite without any *new* (sigh) failures, then the Clinic conversion can generally be considered a success. -- __

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari : Added file: http://bugs.python.org/file39042/issue23949-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue23966] More clearly expose/explain native and cross-build target information

2015-04-15 Thread Nick Coghlan
New submission from Nick Coghlan: Discussion of issue 22980 made it clear to me that part of the problem with the cross-build support is that the difference between the build time information exposed in sysconfig and the live system information exposed in the platform module isn't clear. Debi

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: I fixed the tests (that's important!) and changed the latter message to specify it is referring to the starred target (the term "starred target" appears in the docs in simple_stmts.rst). Looks like the number in that message was wrong before! The test looked like

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Nick Coghlan
Nick Coghlan added the comment: Matthias's latest patch looks good to me - I'm filing a separate issue about the fact that the native and cross-platform build info isn't really exposed properly at the Python level, and is confusing in various ways. -- _

[issue17156] Tools/i18n/pygettext.py doesn't parse unicode string.

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Also fixes 19907? -- nosy: +flipmcf ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue19907] gettext - Non ascii chars in header

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: This might be fixed by issue17156, which would explain why I can't recreate it. https://github.com/python/cpython/commit/f4273cfd16fa502f0eb8a0a8fd1c537ec63e47db -- ___ Python tracker

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread Matt Long
Matt Long added the comment: Here's a patch for the proposal in my previous comment. As Barry mentioned, it wasn't as straightforward as I had hoped due to parts of the usage text being generated by the state of both self._name_parser_map and self._choices_actions. -- Added file: http

[issue19907] gettext - Non ascii chars in header

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: issue18128 is not related methinks. This ticket: POT-Creation-Date issue18128: PO-Revision-Date -- ___ Python tracker ___ __

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread R. David Murray
R. David Murray added the comment: I actually originally wanted to do just that (move the script helpers routine into the old support.py) but I was in the minority. test.support was turned into a package exactly so that script_helpers could become a sub-namespace. As I remember, it was Nick

[issue21642] "_ if 1else _" does not compile

2015-04-15 Thread R. David Murray
R. David Murray added the comment: My impression is that it was fixed the way it was because it makes the internal tokenizer match the what the tokenize module does. See also issue 3353. As for changing it in a point release, it turns something that was an error into something that isn't, so

  1   2   >