Martin Panter added the comment:

Oh I see, TarIter is listed underneath a comment saying “Exported Classes”, and 
main() is listed underneath “exported functions”. If they are indeed meant to 
be exported, they should probably also be documented. Otherwise, maybe we can 
just add another comment clarifying that they are internal.

In the latest patch, I think HeaderError should be added back to __all__; it is 
just its subclasses that are not documented. Also XHDTYPE is listed twice in 
the test case.

If it were up to me, I would add the TarInfo.type constants (REGTYPE, AREGTYPE, 
LNKTYPE, SYMTYPE, DIRTYPE, FIFOTYPE, CONTTYPE, CHRTYPE, BLKTYPE, 
GNUTYPE_SPARSE). But I’m not sure if others would agree.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23883>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to