[issue19356] Change argument _self in _io/textio.c

2013-10-22 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +brian.curtin, tim.golden versions: +Python 2.7, Python 3.4 ___ Python tracker ___ ___ Python-bug

[issue19358] Integrate "Argument Clinic" into CPython build

2013-10-22 Thread Larry Hastings
Larry Hastings added the comment: Drat! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19358] Integrate "Argument Clinic" into CPython build

2013-10-22 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: pitrou -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19357] Module does not get pulled from sys.modules during importlib testing

2013-10-22 Thread Eric Snow
Changes by Eric Snow : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19358] Integrate "Argument Clinic" into CPython build

2013-10-22 Thread Larry Hastings
New submission from Larry Hastings: Somebody needs to figure out how to best integrate Argument Clinic into the build. Antoine, I think you said it sounded like... "fun"? Maybe? Anyway, I'm hoping you're willing to take a stab at it. If not please assign the issue back to nobody, and sorry

[issue19357] Module does not get pulled from sys.modules during importlib testing

2013-10-22 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> pending ___ Python tracker ___ __

[issue19357] Module does not get pulled from sys.modules during importlib testing

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2a62cd8553b5 by Eric Snow in branch '3.3': [Issue #19357] Ensure module "loaded" during tests gets forgotten. http://hg.python.org/cpython/rev/2a62cd8553b5 New changeset 733be92448b0 by Eric Snow in branch 'default': [Issue #19357] Ensure module "lo

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Matej Cepl
Matej Cepl added the comment: On 22/10/13 20:43, Christian Heimes wrote: > Christian Heimes added the comment: > > What's the output of "uname -r" on your machine? 2.6.32-358.23.2.el6.i686 -- ___ Python tracker _

[issue19357] Module does not get pulled from sys.modules during importlib testing

2013-10-22 Thread Eric Snow
Changes by Eric Snow : -- versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue19357] Module does not get pulled from sys.modules during importlib testing

2013-10-22 Thread Eric Snow
New submission from Eric Snow: In Lib/test/test_importlib/import_/test_caching.py, UseCache.test_using_cache "uncaches" "module_to_use", which it really ought to be yanking "some_module". -- assignee: eric.snow components: Tests messages: 200997 nosy: brett.cannon, eric.snow priority: n

[issue18742] Abstract base class for hashlib

2013-10-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: Consider inheriting from abc.ABC rather than specifying metaclass=abc.ABCMeta -- nosy: +rhettinger ___ Python tracker ___ ___

[issue19332] Guard against changing dict during iteration

2013-10-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: The decision to not monitor adding or removing keys was intentional. It is just not worth the cost in either time or space. -- assignee: -> rhettinger ___ Python tracker

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Vajrasky Kok
Vajrasky Kok added the comment: Or if we really want to test these constants, we can use something like this: if hasattr(resource, 'RLIMIT_NICE'): self.assertIsInstance(resource.RLIMIT_NICE, int) Or if we want to be so strict: if hasattr(resource, 'RLIMIT_NICE'): self.assertTrue(-20 <=

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Vajrasky Kok
Vajrasky Kok added the comment: Do we really need to test these constants in unit test? Other constants such as RLIMIT_STACK, RLIMIT_DATA, etc are not being tested. Other consideration includes people built custom kernel without these constants, or maybe they have outdated glibc. Additionally

[issue19356] Change argument _self in _io/textio.c

2013-10-22 Thread Jeffrey Armstrong
Changes by Jeffrey Armstrong : -- type: -> compile error ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue19355] Initial modernization of OpenWatcom support

2013-10-22 Thread Jeffrey Armstrong
Changes by Jeffrey Armstrong : -- type: -> compile error ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue19356] Change argument _self in _io/textio.c

2013-10-22 Thread Jeffrey Armstrong
New submission from Jeffrey Armstrong: At Modules/_io/textio.c:285, one argument to _PyIncrementalNewlineDecoder_decode is named "_self." The name "_self," however is a keyword on older Microsoft C compilers and certain other compilers attempting to maintain compatibility with Microsoft. Ren

[issue19355] Initial modernization of OpenWatcom support

2013-10-22 Thread Jeffrey Armstrong
New submission from Jeffrey Armstrong: In an attempt to overhaul the existing Open-Watcom-specific portions of CPython, I encountered a number of issues related mostly to preprocessor directives surrounding support for the Open Watcom toolchain on Windows. Specifically, there were a number of

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: > antoine, quite right. I've updated is_global. > Nick, I've added lru_cache() to is_private and updated the docs (hope it's > right this time). Mmmh... I actually meant the reverse. IIUC, 100.64.0.0/10 isn't global (i.e. globally routable) and isn't private ei

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks Peter, just a couple more tweaks: - tests need to ensure the carrier private range is neither global *nor* private (it looks to me like they will still show up as private at this point) - looks like the docs for is_private still need to be restored (and men

[issue18742] Abstract base class for hashlib

2013-10-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: > > Have you had a chance to read http://www.python.org/dev/peps/pep-0452/ , too? Overall pep 452 looks good but one thing popped out at me: >>> import hashlib >>> from Crypto.Hash import MD5 >>> m = MD5.new() >>> isinstance(m,

[issue15207] mimetypes.read_windows_registry() uses the wrong regkey, creates wrong mappings

2013-10-22 Thread Tim Golden
Tim Golden added the comment: *cough* Somehow that didn't actually get pushed. Rebased against 2.7, 3.3 & 3.4 and pushed. -- assignee: -> tim.golden resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.2 __

[issue15207] mimetypes.read_windows_registry() uses the wrong regkey, creates wrong mappings

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset e8cead08c556 by Tim Golden in branch '2.7': Issue #15207: Fix mimetypes to read from correct area in Windows registry (Original patch by Dave Chambers) http://hg.python.org/cpython/rev/e8cead08c556 -- __

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread pmoody
pmoody added the comment: antoine, quite right. I've updated is_global. Nick, I've added lru_cache() to is_private and updated the docs (hope it's right this time). -- ___ Python tracker __

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 365fd677856f by Peter Moody in branch 'default': #17400: fix documentation, add cache to is_global and correctly handle 100.64.0.0/10 http://hg.python.org/cpython/rev/365fd677856f -- ___ Python tracker

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Changes by Stefan Krah : Added file: http://bugs.python.org/file32306/mbstowcs_l.c ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Here's a quick-and-dirty version of mbstowcs_l(). The difference in the benchmark to the plain mbstowcs() is 0.82s vs 0.55s. In the context of a Python function this is unlikely to be measurable. -- ___ Python tracker <

[issue17294] compile-flag for single-execution to return value instead of printing it

2013-10-22 Thread Georg Brandl
Georg Brandl added the comment: Terry, thanks for your explanation; I was trying to find some time to write something similar... -- ___ Python tracker ___ __

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: Patch with fix. I'm checking the kernel version manually. requires_linux_version() works only per test. I don't want to write a test case for each attribute ... -- components: +Tests keywords: +patch stage: -> patch review type: -> behavior version

[issue15207] mimetypes.read_windows_registry() uses the wrong regkey, creates wrong mappings

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 95b88273683c by Tim Golden in branch '3.3': Issue #15207: Fix mimetypes to read from correct area in Windows registry (Original patch by Dave Chambers) http://hg.python.org/cpython/rev/95b88273683c New changeset 12bf7fc1ba76 by Tim Golden in branch

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: What's the output of "uname -r" on your machine? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue19354] test_format fails on RHEL-6

2013-10-22 Thread Stefan Krah
New submission from Stefan Krah: Lifting this from #7442: "Very plain checkout of git and ./configure && make && make test leads to another failed test, but not this one (issue #19353). So either we do something wrong in all those Fedora patches, or this has been fixed since 3.3.2." If there wa

[issue19349] Not so correct exception message when running venv

2013-10-22 Thread Ned Deily
Changes by Ned Deily : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Christian, could you have a look? I think this was added in #19324. -- nosy: +christian.heimes, skrah ___ Python tracker ___ __

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: STINNER Victor wrote: > "So it should happen somewhere in PyUnicode_DecodeLocaleAndSize(). Perhaps we > can create _PyUnicode_DecodeLocaleAndSize() which would take an LC_CTYPE > parameter?" > > For this issue, it means that Python localeconv() will have to chan

[issue19294] test_asyncio fails intermittently on OS X 10.4

2013-10-22 Thread Ned Deily
Ned Deily added the comment: I agree. And there appear to have been no test_asyncio failures on the buildbot since the checkins -> closing. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue19279] UTF-7 to UTF-8 decoding crash

2013-10-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: serhiy.storchaka -> versions: -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker ___

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Matej Cepl
Matej Cepl added the comment: On 22/10/13 17:32, Stefan Krah wrote: > It looks like some other test in the test suite did not restore a changed > locale. If you're motivated enough, you could try if it still happens in > 3.4 and open a new issue (it's unrelated to this one). Very plain checkout

[issue19353] on RHEL6 simple build fails with test_linux_constants (test.test_resource.ResourceTest)

2013-10-22 Thread Matej Cepl
New submission from Matej Cepl: With pure clone of https://github.com/python/cpython.git (no patches applied whatsoever, and the last commit is https://github.com/python/cpython/commit/650406fe7373f31b595b381d4f2f02065607386a) and pure ./configure && make -j2 && make -j2 test I get one failed

[issue19294] test_asyncio fails intermittently on OS X 10.4

2013-10-22 Thread Guido van Rossum
Guido van Rossum added the comment: If the buildbot is still green, can you close this? I don't think it's worth trying to formulate and test a more precise theory about the root cause, given that it's most likely a platform bug anyway. -- ___ Pyth

[issue19345] Unclear phrasing in whatsnew/3.4.rst

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: > The PyThreadState.tick_counter field has been value: its value was > meaningless since Python 3.2 (“new GIL”). oops, "has been removed" :-) -- ___ Python tracker __

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: "So it should happen somewhere in PyUnicode_DecodeLocaleAndSize(). Perhaps we can create _PyUnicode_DecodeLocaleAndSize() which would take an LC_CTYPE parameter?" For this issue, it means that Python localeconv() will have to change the LC_CTYPE locale many t

[issue19345] Unclear phrasing in whatsnew/3.4.rst

2013-10-22 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Matej Cepl wrote: > santiago:optimized (el6) $ ./python -m test test_format > [1/1] test_format > 1 test OK. It looks like some other test in the test suite did not restore a changed locale. If you're motivated enough, you could try if it still happens in 3.4 and

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Victor, thanks for the comments. I also think we should set LC_CTYPE closer to the actual call to mbstowcs(), otherwise there are many API calls in between. So it should happen somewhere in PyUnicode_DecodeLocaleAndSize(). Perhaps we can create _PyUnicode_DecodeLo

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sorry for chiming in a bit late, but what's the rationale for including 100.64.0.0/10 in the "is_private" set, rather than *only* excluding it from the "is_global" set? The rationale for RFC 6598 is precisely that 100.64.0.0/10 is *not* private in the common

[issue19352] unittest loader barfs on symlinks

2013-10-22 Thread Michael Foord
Michael Foord added the comment: Good catch and fix Antoine. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue19352] unittest loader barfs on symlinks

2013-10-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: Attaching patch. -- keywords: +patch Added file: http://bugs.python.org/file32304/unittest_loader_symlinks.patch ___ Python tracker ___

[issue19352] unittest loader barfs on symlinks

2013-10-22 Thread Antoine Pitrou
New submission from Antoine Pitrou: unittest.loader has the following snippet: if realpath.lower() != fullpath_noext.lower(): module_dir = os.path.dirname(realpath) mod_name = os.path.splitext(os.path.basename(full_path))[0]

[issue19030] inspect.getmembers and inspect.classify_class_attrs mishandle descriptors

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64d94b21e731 by Ethan Furman in branch 'default': Issue #19030: fix new pydoc tests for --without-doc-strings http://hg.python.org/cpython/rev/64d94b21e731 -- ___ Python tracker

[issue19334] test_asyncio hanging for 1 hour (non-AIX version)

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: > I started "strace ./python -m test -vF test_asyncio" running under screen on > the RHEL6 buildbot (so it will keep running when I log out in a moment). Trace also child processes: add -f. And add maybe also timestamps: -tt. -- __

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: STINNER Victor wrote: > The following PostgreSQL issue looks to be the same than this Python issue: > http://www.postgresql.org/message-id/20100422015552.4b7e0754...@cvs.postgresql.org > > The fix changes temporarly the LC_CTYPE encoding: So does my patch. :) --

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Matej Cepl
Matej Cepl added the comment: What I did: 1) run the build (it is a building of Fedora Rawhide python3 package on RHEL), and see it failed in this test. 2) see below santiago:python3 (el6) $ cd Python-3.3.2/build/optimized/ santiago:optimized (el6) $ ./python -m test test_format [1/1] test_for

[issue19030] inspect.getmembers and inspect.classify_class_attrs mishandle descriptors

2013-10-22 Thread Ethan Furman
Ethan Furman added the comment: Actually, you @skipif clued me in as to what was happening with the other pydoc tests and their skipif clauses. Added appropriate skipifs to the new tests and mimicked the docstring in/exclusion. All tests now passing with and without docstrings, with and with

[issue18603] PyOS_mystricmp unused and no longer available

2013-10-22 Thread Benjamin Peterson
Benjamin Peterson added the comment: Someone would have to be trying fairly hard to use those functions on Windows because this is in the header: #ifdef MS_WINDOWS #define PyOS_strnicmp strnicmp #define PyOS_stricmp stricmp #else #define PyOS_strnicmp PyOS_mystrnicmp #define PyOS_stricmp PyOS_m

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: msg95988> Hi, the following works in 2.7 but not in 3.x: ... Sure it works because Python 2 pass the raw byte string, it does not try to decode it. But did you try to display the result in a terminal for example? Example with Python 2 in an UTF-8 terminal: $

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: Just clarifying how I plan to track this: as we start specific tasks, we'll create new issues and make this one depend on them. That seems better to me than creating a whole raft of issues up front that are then depending on each other. -- ___

[issue19351] python msi installers - silent mode

2013-10-22 Thread Christian Heimes
Changes by Christian Heimes : -- assignee: -> loewis components: +Windows nosy: +loewis type: -> behavior ___ Python tracker ___ ___

[issue19351] python msi installers - silent mode

2013-10-22 Thread Jason Bray
New submission from Jason Bray: Hello, I am working in an IT group, attempting to automate our management of python. This issue applies to both Python 3.4 and Python 2.7.5 and Python 2.7.4 On a Windows machine (both 7 and 8.1 have been tested) when python msi's are installed from the command l

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: Title: _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE Oh, I just realized that the issue is a LC_NUMERIC using an encoding A with a LC_CTYPE using an encoding B. It looks like the glibc does not support this setup, at least for the fi_FI loc

[issue18742] Abstract base class for hashlib

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: I have checked in some of the basic and non-controversal parts of the PEP (optimization, expose type object). The ABCs are still missing. In order to cope with keyed and non-keyed CHF I have added a common base class for both and separate ABCs for keyed and

[issue19030] inspect.getmembers and inspect.classify_class_attrs mishandle descriptors

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Ethan Furman wrote: > Stefan, do the other tests in PydocWithMetaClasses continue to work on your > FreeBSD 9.0 box without docstrings? Because they all fail on my Linux Ubuntu > 13.04 box. I tested on Debian, and the remaining tests seem to work (I did not bot

[issue19334] test_asyncio hanging for 1 hour (non-AIX version)

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: I started "strace ./python -m test -vF test_asyncio" running under screen on the RHEL6 buildbot (so it will keep running when I log out in a moment). If I don't report back the results in the next day or two, ping the issue to remind me to log back in and see if

[issue19350] macurl2path coverage

2013-10-22 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: Check PEP 453 again: http://www.python.org/dev/peps/pep-0453/#changes-to-virtual-environments Rather than only changing pyvenv, the API in the PEP is to add "with_pip" parameters to the venv module API, so that anyone building pyvenv style tools on top of venv

[issue19030] inspect.getmembers and inspect.classify_class_attrs mishandle descriptors

2013-10-22 Thread Ethan Furman
Ethan Furman added the comment: Stefan, do the other tests in PydocWithMetaClasses continue to work on your FreeBSD 9.0 box without docstrings? Because they all fail on my Linux Ubuntu 13.04 box. -- ___ Python tracker

[issue19335] codeop misclassifies incomplete code with 'nonlocal'

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: codeop compiles the whole pending statement every time, so that part shouldn't be needed (from the compiler's point of view, this input looks complete - there's nothing dangling, any more than there is for a normal syntax error like "name name"). As far as I can te

[issue19350] macurl2path coverage

2013-10-22 Thread Colin Williams
New submission from Colin Williams: Ported the tests built into the library requiring manual verification over to the testing framework. Those tests only provided 77% coverage, so I improved that up to 99%. Can't get the last line because it's only reachable on older model macs. --

[issue19331] Revise PEP 8 recommendation for class names

2013-10-22 Thread Paul Moore
Paul Moore added the comment: +1 on switching the wording in the overriding principle section to say "factory function to class". Although the fact that I made that mistake reflects my point that if I'm thinking of class->wrapper as an "internal change" then I'm not anticipating or supporting

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Vinay Sajip
Vinay Sajip added the comment: venv shouldn't need any changes. The pyvenvex.py [1] script I posted to distutils-sig installs setuptools and pip into venvs, and it can be used to update pyvenv (where AFAICT changes are only required to change where the pip to be installed comes from). [1] htt

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Matej Cepl wrote: > >>> import locale > >>> locale.localeconv() > {'p_cs_precedes': 127, 'n_sep_by_space': 127, 'n_sign_posn': 127, > 'n_cs_precedes': 127, 'grouping': [], 'positive_sign': '', 'mon_grouping': > [], 'p_sep_by_space': 127, 'mon_thousands_sep': '',

[issue19335] codeop misclassifies incomplete code with 'nonlocal'

2013-10-22 Thread R. David Murray
R. David Murray added the comment: A complete fix is going to require setting a flag that we have a pending non-local, and check that flag when the code input is complete to raise the SyntaxError at that point if the non-local hasn't been set. -- nosy: +r.david.murray

[issue19331] Revise PEP 8 recommendation for class names

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: Hmm, review link doesn't appear to be available, so just commenting here. For the "overriding principle" part, you can't switch from a class to a factory function (as that's a backwards incompatible change due to breaking subclassing and isinstance and issubcla

[issue18742] Abstract base class for hashlib

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27da6e790c41 by Christian Heimes in branch 'default': Issue #18742: Expose the internal hash type object for ABCs. http://hg.python.org/cpython/rev/27da6e790c41 -- ___ Python tracker

[issue18742] Abstract base class for hashlib

2013-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 72d7b2185771 by Christian Heimes in branch 'default': Issue #18742: Rework the internal hashlib construtor to pave the road for ABCs. http://hg.python.org/cpython/rev/72d7b2185771 -- nosy: +python-dev ___

[issue17276] HMAC: deprecate default hash

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: HMAC-MD5 is still fine for legacy support. I wouldn't use it in new program, though -- ___ Python tracker ___ ___

[issue17400] ipaddress should make it easy to identify rfc6598 addresses

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: The docs patch doesn't look quite right - Peter, did you mean to copy the "is_private" docs before modifying them? As far as caching goes, perhaps we can just drop functools.lru_cache into the relevant property implementations? @property @lru_cache()

[issue17276] HMAC: deprecate default hash

2013-10-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Having to add a parameter to hmac() in applications to port them to > Python 3.4 should not be so hard. And using MD5 is really a major > security issue, don't you think so? Some uses of md5 don't have anything to do with security. I'm -1 on removing the defau

[issue19335] codeop misclassifies incomplete code with 'nonlocal'

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: As a potential fix (albeit an ugly hack), try changing this part of codeop._maybe_compile: if not code1 and repr(err1) == repr(err2): raise err1 To something like: if not code1 and repr(err1) == repr(err2): if isinstance(err1, SyntaxErro

[issue19349] Not so correct exception message when running venv

2013-10-22 Thread Vajrasky Kok
New submission from Vajrasky Kok: In Lib/venv/__init__.py, line 348: raise ValueError('This script is only for use with Python 3.3') But I am running Python 3.4. Attached the patch to make it better. raise ValueError('This script is only for use with Python >= 3.3') If you feel it does not fe

[issue17276] HMAC: deprecate default hash

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: I would prefer to directly raise an exception in Python 3.4. Developers will not notice a warning, warning are hidden by default. How many developers run their tests using -Werror? Having to add a parameter to hmac() in applications to port them to Python 3.4

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Matej Cepl
Matej Cepl added the comment: Perhaps version of glibc might be interesting as well? glibc-2.12-1.107.el6_4.5.i686 -- ___ Python tracker ___ _

[issue19335] codeop misclassifies incomplete code with 'nonlocal'

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: The comment at the top of codeop explains the problem (and why Terry is interested in what the C code is doing, since it's clearly different): === Compile three times: as is, with \n, and with \n\n appended. If it compiles as is, it's complete. If i

[issue17276] HMAC: deprecate default hash

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: I've changed the deprecation warning to PendingDeprecationWarning. Please review my wording and grammar. -- Added file: http://bugs.python.org/file32299/17276-3.patch ___ Python tracker

[issue17294] compile-flag for single-execution to return value instead of printing it

2013-10-22 Thread Albert Zeyer
Albert Zeyer added the comment: Thanks a lot for the long and detailed response! I didn't meant to start a header war; I thought that my request was misunderstood and thus the header changes were by mistake. But I guess it is a good suggestion to leave that decision to a core dev. I still thi

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Matej Cepl
Matej Cepl added the comment: >>> import locale >>> locale.localeconv() {'p_cs_precedes': 127, 'n_sep_by_space': 127, 'n_sign_posn': 127, 'n_cs_precedes': 127, 'grouping': [], 'positive_sign': '', 'mon_grouping': [], 'p_sep_by_space': 127, 'mon_thousands_sep': '', 'currency_symbol': '', 'mon_d

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread STINNER Victor
STINNER Victor added the comment: This issue is very close to the issue #13706 which I solved with the new function PyUnicode_DecodeLocale(): see get_locale_info() in Python/formatter_unicode.c. We might copy/paste the code, or we should maybe add a private API to get locale information: get_

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Nick Coghlan
Changes by Nick Coghlan : -- nosy: +dstufft, loewis, ned.deily, vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue7442] _localemodule.c: str2uni() with different LC_NUMERIC and LC_CTYPE

2013-10-22 Thread Stefan Krah
Stefan Krah added the comment: Matej Cepl wrote: > To #200912: now, system locale is UTF-8 all the way: > santiago:python3 (el6) $ locale > LANG=en_US.utf8 > LC_CTYPE="en_US.utf8" > LC_NUMERIC=en_IE.utf8 > LC_TIME=en_IE.utf8 > LC_COLLATE="en_US.utf8" > LC_MONETARY=en_IE.utf8 > LC_MESSAGES="en_US

[issue19348] Building _testcapimodule as a builtin results in compile error

2013-10-22 Thread Alan Hourihane
New submission from Alan Hourihane: When building _testcapimodule.c as a builtin module, the build fails with this error because it doesn't take into account Py_BUILD_CORE from datetime.h. m68k-atari-mint-gcc -I. -IInclude -I/j/var/tmp/portage/dev-lang/python-2.7.5-r2/work/Python-2.7.5/Include

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Nick Coghlan
Nick Coghlan added the comment: One more task to track - updating to the latest upstream pip before beta 2. -- ___ Python tracker ___

[issue19325] _osx_support imports many modules

2013-10-22 Thread Ned Deily
Ned Deily added the comment: Yes, there are various tricks to be done. I have another solution in mind that should eliminate the use re altogether for most cases. (BTW, _osx_support was implemented to centralize functions in anticipation of the introduction of distutils2/packaging in Python

[issue19347] PEP 453 implementation tracking issue

2013-10-22 Thread Nick Coghlan
New submission from Nick Coghlan: This is the overall tracking issue for the implementation of PEP 453. The following subtasks will be created as separate issues: - update the Installing Python Modules documentation to reference www.pip-installer.org in Python 2.7, 3.3 and 3.4 (ncoghlan) - ini

[issue19346] Build fails when there are no shared extensions to be built

2013-10-22 Thread Alan Hourihane
New submission from Alan Hourihane: When building python with static extensions and therefore there are no shared extensions to be built the extension list can be NULL, and therefore 0 length. This results in this error running build running build_ext INFO: Can't locate Tcl/Tk libs and/or

[issue5815] locale.getdefaultlocale() missing corner case

2013-10-22 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19325] _osx_support imports many modules

2013-10-22 Thread Christian Heimes
Christian Heimes added the comment: For distutils function you can move the import of re inside the function body. It's not elegant but it does the trick w/o much slowdown or inconveniences. -- ___ Python tracker

[issue19325] _osx_support imports many modules

2013-10-22 Thread Esa Peuha
Esa Peuha added the comment: Actually Lib/_osx_support.py directly imports only five modules: os, re and sys at top level, and contextlib and tempfile in _read_output(). These last two aren't really needed at all, and there's no point even trying to avoid importing os and sys, so the only real

[issue19341] locale.getdefaultencoding() returns wrong locale and encoding for ca_ES@valencia

2013-10-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a duplicate of issue5815. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> locale.getdefaultlocale() missing corner case ___ Python tr

[issue19331] Revise PEP 8 recommendation for class names

2013-10-22 Thread Ethan Furman
Changes by Ethan Furman : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

  1   2   >