[issue18549] Dead code in socket_ntohl()

Serhiy Storchaka added the comment: Agree, it can be removed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18468] re.group() should never return a bytearray

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue18226] IDLE Unit test for FormatParagrah.py

Phil Webster added the comment: This patch moves the comment_header code to reformat_comment, adds tests for reformat_comment, and implements the fix that Todd mentioned in #18429. In addition, I changed the get_comment_header and get_indent regular expressions to only look for spaces and tabs

[issue18529] Use long dash

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue7982] extend captured_output to simulate different stdout.encoding

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue9495] argparse unittest tracebacks are confusing if an error is raised when not expected

Changes by Ezio Melotti : -- keywords: -easy nosy: +ezio.melotti stage: needs patch -> patch review versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker _

[issue18376] show the effective count of process when running the testsuite

Ezio Melotti added the comment: LGTM. This could go in 2.7 and 3.3 too IMHO. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-l

[issue5262] PythonLauncher considered harmfull

Ezio Melotti added the comment: FWIW more than once I tried to open a .py file on Windows just to see a black box flashing by and promptly disappear. I agree that opening the file in an editor (e.g. IDLE) is a better option, but I realize some users might prefer to launch a script when they d

[issue14853] test_file.py depends on sys.stdin being unseekable

Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.3, Python 3.4 ___ Python tracker

[issue14853] test_file.py depends on sys.stdin being unseekable

Roundup Robot added the comment: New changeset 17542d36effd by Ezio Melotti in branch '2.7': #14853: remove test that was making too many assumptions about stdin. Patch by Elena Oat. http://hg.python.org/cpython/rev/17542d36effd New changeset c5d847ee354a by Ezio Melotti in branch '3.3': #1485

[issue16937] -u (unbuffered I/O) command line option documentation mismatch for sys.stdin

Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: docs@python -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> enhancement ___ Python tracker

[issue16937] -u (unbuffered I/O) command line option documentation mismatch for sys.stdin

Roundup Robot added the comment: New changeset 4b33f74ab0f1 by Ezio Melotti in branch '3.3': #16937: document that stdin is always buffered, even when -u is used. Patch by Elena Oat. http://hg.python.org/cpython/rev/4b33f74ab0f1 New changeset 52f0aa0d552a by Ezio Melotti in branch 'default': #

[issue18524] BufferedReader.read1() documentation/implementation difference

Nikolaus Rath added the comment: On 07/24/2013 03:04 PM, Antoine Pitrou wrote: > However, 3.2 didn't get that improvement, sorry. See changeset 27bf3d0b8e5f > and issue #13393. > > -- > resolution: -> duplicate > status: open -> closed Duh. So much back and forth just to find it's alr

[issue18524] BufferedReader.read1() documentation/implementation difference

Changes by Antoine Pitrou : -- superseder: -> Improve BufferedReader.read1() ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18524] BufferedReader.read1() documentation/implementation difference

Antoine Pitrou added the comment: Ah, well. This is already fixed, then: Python 3.4.0a0 (default:ae769deb45b2, Jul 20 2013, 19:28:41) [GCC 4.7.3] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import io >>> raw = io.BytesIO(bytes(200)) >>> buffered = io.Buff

[issue18524] BufferedReader.read1() documentation/implementation difference

Nikolaus Rath added the comment: On 07/24/2013 02:51 PM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > Le mercredi 24 juillet 2013 à 21:45 +, Nikolaus Rath a écrit : >> The documentation is correct that read1(n) never returns more than n bytes. >> >> My complaint is that t

[issue18524] BufferedReader.read1() documentation/implementation difference

Antoine Pitrou added the comment: Le mercredi 24 juillet 2013 à 21:45 +, Nikolaus Rath a écrit : > The documentation is correct that read1(n) never returns more than n bytes. > > My complaint is that the actual bound is stricter than this, band > read1(n) will never return more than min(n, b

[issue18524] BufferedReader.read1() documentation/implementation difference

Antoine Pitrou added the comment: Le mercredi 24 juillet 2013 à 21:51 +, Antoine Pitrou a écrit : > - if the buffer is empty, 1 raw I/O call is issued and at most 1 byte is > returned Make that "at most n bytes are returned", of course. -- ___ Py

[issue18524] BufferedReader.read1() documentation/implementation difference

Nikolaus Rath added the comment: On 07/24/2013 02:28 PM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > Le mercredi 24 juillet 2013 à 18:24 +, Nikolaus Rath a écrit : >> There should be no problem reading 20 bytes with a single call to >> BytesIO.read(), yet the buffered re

[issue18524] BufferedReader.read1() documentation/implementation difference

Antoine Pitrou added the comment: Le mercredi 24 juillet 2013 à 18:24 +, Nikolaus Rath a écrit : > There should be no problem reading 20 bytes with a single call to > BytesIO.read(), yet the buffered reader returns only 10 bytes. Er. Your bug report seems to imply that read1(n) can return *m

[issue18552] obj2ast_object() doesn't check return value of PyArena_AddPyObject()

New submission from Christian Heimes: CID 1046712 (#1 of 1): Unchecked return value (CHECKED_RETURN) 3. check_return: Calling function "PyArena_AddPyObject(PyArena *, PyObject *)" without checking return value (as is done elsewhere 5 out of 6 times). 4. unchecked_value: No check of the return va

[issue18468] re.group() should never return a bytearray

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue18551] child_exec() doesn't check return value of fcntl()

New submission from Christian Heimes: http://hg.python.org/cpython/file/96d817f41c4c/Modules/_posixsubprocess.c#l384 CID 715330 (#2 of 2): Unchecked return value from library (CHECKED_RETURN) 17. check_return: Calling function "fcntl(c2pwrite, 2, old & 0xfffe)" without checking retu

[issue18489] IDLE Unit test for SearchEngine.py

Phil Webster added the comment: Added tests for the rest of the SearchEngine module. I used the mock tkMessageBox for testing the error display, but used the tkinter Text widget for other tests because mark_set and tag_add/remove haven't been added to the mock yet. -- Added file: http

[issue18550] internal_setblocking() doesn't check return value of fcntl()

New submission from Christian Heimes: http://hg.python.org/cpython/file/96d817f41c4c/Modules/socketmodule.c#l614 CID 715331 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) 5. check_return: Calling function "fcntl(s->sock_fd, 4, delay_flag)" without checking return value. This li

[issue18549] Dead code in socket_ntohl()

New submission from Christian Heimes: http://hg.python.org/cpython/file/96d817f41c4c/Modules/socketmodule.c#l4642 The code has two checks if (x == (unsigned long) -1 && PyErr_Occurred()). Coverity claims that the second time is dead code and I agree. It looks like an artifact from the time the

[issue18547] os.path.dirname() does not behave as expected for path without /:es

R. David Murray added the comment: Oh, it would definitely be a backward compatibility issue. Imagine code that does a dirname and branches like this: d = dirname(somepath) if d: else: Or to give a more concrete example: path = fn if dirname(fn) else os.path.join

[issue18548] In unittest doc change WidgetTestCase to SimpleWidgetTestCase in suite()

New submission from py.user: http://docs.python.org/3/library/unittest.html#organizing-test-code """ def suite(): suite = unittest.TestSuite() suite.addTest(WidgetTestCase('test_default_size')) suite.addTest(WidgetTestCase('test_resize')) return suite """ -- assignee: doc

[issue18524] BufferedReader.read1() documentation/implementation difference

Nikolaus Rath added the comment: On 07/24/2013 07:35 AM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > >> This means that read1() will only return up to n bytes if n is smaller >> than the buffer size, otherwise it will return at most >> bytes. > > Did you actually observe suc

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

R. David Murray added the comment: OK, yeah, this seems to be long standing, untested behavior. I will take a look at what should be done here. -- ___ Python tracker ___ __

[issue18541] LoggerAdapter example is counter-productive

Roundup Robot added the comment: New changeset 16c15d7d4480 by Vinay Sajip in branch '2.7': Issue #18541: simplified LoggerAdapter example. http://hg.python.org/cpython/rev/16c15d7d4480 New changeset adaecee37745 by Vinay Sajip in branch '3.3': Issue #18541: simplified LoggerAdapter example. htt

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

Matěj Stuchlík added the comment: >So this represents a change in behavior of the socket library on Fedora 18 vs >earlier versions? I don't believe so. This happens on my Fedora 18 system, my Debian box with Python 2.6.6, on Fedora 19 (https://bugzilla.redhat.com/show_bug.cgi?id=987340), anot

[issue18547] os.path.dirname() does not behave as expected for path without /:es

New submission from Jonas Eriksson: Only tested on marked python versions. Checked the code in hg (a5681f50bae2) and did not see anything related to this in the current development version. Essentially, what I see is this: >>> os.path.dirname("asdf") '' >>> os.path.dirname("./asdf") '.' >>> W

[issue18546] ssl.get_server_certificate like addition for cert chain

Derek Wilson added the comment: very cool - i had seen a couple of those patches and they look good. Most of what I asked for is implemented in supporting bits for those issues. Is their anything you could use some help on? I'm very interested in seeing better ssl support in python. -

[issue18078] threading.Condition to allow notify on a specific waiter

João Bernardo added the comment: > 1) It should check all predicates. OK. Maybe later there could be an option for customization? > 2) It should return a list of ready conditions. OK. > 3) It should *not* accept a list of conditions. The list option would be to simplify the "wait" method... Avo

[issue18078] threading.Condition to allow notify on a specific waiter

Richard Oudkerk added the comment: IMHO 1) It should check all predicates. 2) It should return a list of ready conditions. 3) It should *not* accept a list of conditions. 4) from_condition() should be removed. Also notify() should try again if releasing a waiter raises RuntimeError because it

[issue18546] ssl.get_server_certificate like addition for cert chain

Changes by Christian Heimes : -- assignee: -> christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18546] ssl.get_server_certificate like addition for cert chain

Christian Heimes added the comment: I'm already working on the issue and I have a couple of patches in my work queue, e.g. #18369, #18233, #18147, #16487 and #18293 -- nosy: +christian.heimes stage: -> needs patch superseder: -> SSLSocket.getpeercertchain() __

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

Nick Coghlan added the comment: Just noting for the record (since it appears it was never brought back to the comments): it is expected that programs that manipulate the AST may require updates before they will work on a new version of Python. Preserving AST backwards compatbility is too limit

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

Nick Coghlan added the comment: (That was the outcome of the suggested AST discussions on python-dev that were mentioned earlier) -- ___ Python tracker ___ _

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

R. David Murray added the comment: So this represents a change in behavior of the socket library on Fedora 18 vs earlier versions? Do any of the impalib tests fail? -- components: +email nosy: +barry, r.david.murray versions: +Python 3.4 ___ Python

[issue18543] urllib.parse.urlopen shouldn't ignore installed opener when called with any ca* argument

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18545] enum always runs member_type when use_args is True

Changes by Ethan Furman : -- assignee: -> ethan.furman nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue18546] ssl.get_server_certificate like addition for cert chain

New submission from Derek Wilson: the ssl.get_server_certificate function is very useful for just requesting a cert. It would also be very useful to have a parallel function, possibly ssl.get_server_cert_chain that does the same thing except but provides a tuple of PEM encoded certs comprising

[issue18541] LoggerAdapter example is counter-productive

Antoine Pitrou added the comment: > > But how is that necessary for the use case? Your LoggerAdapter- > > derived class could take the "existing class" as a constructor > > parameter (*), then inject the required info in its overriden > > process() method. > > If you can adapt an existing class

[issue18535] termios.tcgetattr should return namedtuple

R. David Murray added the comment: Anatoly: FYI "Do not hijack the issue" is not a collaborative conversation style in English. A more collaborative conversation style would be to leave out that part of the sentence, and just say that you think value interpretation should be a separate, later

[issue18524] BufferedReader.read1() documentation/implementation difference

Antoine Pitrou added the comment: > This means that read1() will only return up to n bytes if n is smaller > than the buffer size, otherwise it will return at most > bytes. Did you actually observe such behaviour? If so, this is a bug. -- ___ Python

[issue18533] Avoid error from repr() of recursive dictview

R. David Murray added the comment: I'm in favor of treating this a bugfix. It is a bug for repr to raise a recursion error, IMO. -- nosy: +r.david.murray ___ Python tracker ___

[issue18541] LoggerAdapter example is counter-productive

Vinay Sajip added the comment: > I think we should acknowledge that people often have difficulties > with the rather simple functionalities of the logging module, > not only the advanced ones. Perhaps some people do have difficulties, but that's always going to be the case no matter what you do

[issue18545] enum always runs member_type when use_args is True

New submission from Chris Lambacher: Starting at line 153 in enum.py there is: 153 if not use_args: 154 enum_member = __new__(enum_class) 155 original_value = value 156 else: 157 enum_member = __new__(enum_cla

[issue18524] BufferedReader.read1() documentation/implementation difference

R. David Murray added the comment: Unless I'm misunderstanding something, the current implementation does match the current documentation: if < n, returning bytes is returning "up to n". "Up to" means it could be "less than". So you are advocating a change in behavior...but I believe there

[issue18544] subprocess.Popen support for redirection of arbitrary file descriptors

New submission from Robert O'Callahan: Popen() ought to support redirection to/from more file descriptors than 0, 1, and 2 when spawning processes. A clear use case is here: http://stackoverflow.com/questions/6050187/write-to-file-descriptor-3-of-a-python-subprocess-popen-object Instead of mes

[issue18541] LoggerAdapter example is counter-productive

Antoine Pitrou added the comment: > That does not have a specific example, as it seems simple enough to > understand as stated. I think we should acknowledge that people often have difficulties with the rather simple functionalities of the logging module, not only the advanced ones. > The examp

[issue18541] LoggerAdapter example is counter-productive

Vinay Sajip added the comment: That's not quite right. The recommended way *is* to override the process() method. From the page you linked to: "If you need a different method, e.g. if you want to prepend or append the contextual information to the message string, you just need to subclass Log

[issue6627] threading.local() does not work with C-created threads

Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18078] threading.Condition to allow notify on a specific waiter

João Bernardo added the comment: > Charles-François's point about the algorithmic complexity is > legitimate, so I think he was actually waiting for you to amend > your patch ;) This doesn't seems to be the actual issue as it would require a big change for something that wasn't proven importan

[issue18078] threading.Condition to allow notify on a specific waiter

Antoine Pitrou added the comment: Charles-François's point about the algorithmic complexity is legitimate, so I think he was actually waiting for you to amend your patch ;) -- ___ Python tracker __

[issue18078] threading.Condition to allow notify on a specific waiter

João Bernardo added the comment: ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue18543] urllib.parse.urlopen shouldn't ignore installed opener when called with any ca* argument

New submission from Moritz Sichert: If you pass any of cafile, capath or cadefault to urllib.parse.urlopen it creates a new opener that contains the HTTPSHandler that was according to the ca* arguments. It then uses this new opener to execute the request. If you installed a custom opener with u

[issue18535] termios.tcgetattr should return namedtuple

anatoly techtonik added the comment: If you need a better use case for DictRecord, urlparse is another one. -- ___ Python tracker ___

[issue18535] termios.tcgetattr should return namedtuple

anatoly techtonik added the comment: Do not hijack the issue - value interpretation is the next step, which better keep out of scope for this improvement. termios is a C interface, which documents the meaning of TIOCGWINSZ and has defined names for structure entries, such as lflag. This issue

[issue4708] os.pipe should return inheritable descriptors (Windows)

STINNER Victor added the comment: Changing the default inheritance value of os.pipe() is not acceptable because it would break backward compatibility. Giving access to Windows extra parameter is nice, but we have to find a way to propose a portable API. That's what I'm trying to do with the PE

[issue10131] deepcopying an xml.dom.minidom.Document generates an invalid XML document

Changes by Bohuslav "Slavek" Kabrda : -- nosy: +bkabrda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue3453] PyType_Ready doesn't ensure that all bases are ready

Ronald Oussoren added the comment: I don't know if multiple inheritance is explicitly supported at the C level, but it is possible to create an extension type with multiple base classes in tp_bases. -- nosy: +ronaldoussoren ___ Python tracker

[issue2066] Adding new CNS11643, a *huge* charset, support in cjkcodecs

Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue18542] httpd memory consuption increasing continously due to mod_python

Ronald Oussoren added the comment: mod_python isn't part of the cpython std lib. As such, this isn't the right tracker to report problems with mod_python. You may have more success by asking the project itself (). -- nosy: +ronaldoussoren resolution: -> inva

[issue18542] httpd memory consuption increasing continously due to mod_python

New submission from Sumitinder: Mod_python is used in our application and continous load of mod_python result in increase in httpd memory usage i.e upto 1.6 Gb. Packets used: mod_python-3.2.8-3.1 httpd-2.2.3-43.el5.centos Centos 5.5 OS Is there any memory leak in mod_python which is resulting

[issue18541] LoggerAdapter example is counter-productive

New submission from Antoine Pitrou: The idiomatic way to use a LoggerAdapter is to override the process() method. However, the example in the cookbook (*) is some gobbledegook code overriding __getitem__ and __iter__ on a separate class. It's a pity that users are directed to use an insane and

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

New submission from Matěj Stuchlík: Traceback (most recent call last): File "", line 1, in File "/usr/lib64/python2.7/imaplib.py", line 163, in __init__ self.open(host, port) File "/usr/lib64/python2.7/imaplib.py", line 229, in open self.sock = socket.create_connection((host, port)

[issue18539] Arguments tooltip wrong if def contains fractional default value

New submission from ariel brunner: When defining a function with factional default arguments, the text replaces the correct values in the tooltip. Here's an example - >>> def f(a=0.5): pass >>> f( tooltip shows - "(a=0)", i.e. replaces the ".5" with . This was found to happen on IDL

[issue18539] Arguments tooltip wrong if def contains fractional default value

Changes by ariel brunner : -- versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue2943] Distutils should generate a better error message when the SDK is not installed

Matt Hickford added the comment: ( Upstreamed from Pip https://github.com/pypa/pip/issues/942 ) There are lot of Python users on Windows. If they succeed in installing a package manager (a struggle), this is typically their first experience with it $ pip install numpy blah blah blah

[issue791968] Arguments tooltip wrong if def contains tuple

ariel brunner added the comment: I will, sorry. I thought it's possible reopen an issue. Since all the relevant information is already contained here, and since the problem is with the fix to the issue, I figured it's best to reopen this one. -- ___

[issue18535] termios.tcgetattr should return namedtuple

Amaury Forgeot d'Arc added the comment: You need a better use case though. termios awful constant names ('TIOCGWINSZ') and values ('\x1b') won't become more easy with a nametuple. -- resolution: -> works for me status: open -> closed ___ Python trac