[issue11750] Mutualize win32 functions

Amaury Forgeot d'Arc added the comment: Two high-level remarks about the patch: - IMO there is no reason to put _windows.c in the PC directory. After all, there is no such distinction for posix-specific modules. - wxPython already has a submodule named _windows.py. I wonder if this will caus

[issue11750] Mutualize win32 functions

Changes by Santoso Wijaya : -- nosy: +santa4nt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11750] Mutualize win32 functions

Changes by Brian Curtin : -- keywords: +needs review stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11750] Mutualize win32 functions

Brian Curtin added the comment: Here's a patch replacing Modules/_multiprocessing/win32_functions.c and PC/_subprocess.c with a common PC/_windows.c. There's not much to the patch despite its size -- it just shuffles around the C code and does a few renames in the appropriate Python modules.

[issue8426] multiprocessing.Queue fails to get() very large objects

Terry J. Reedy added the comment: Please do not send html responses, as they result in a spurious 'unnamed' file being attached. Please do suggest a specific change. Should this be changed to a doc issue? -- ___ Python tracker

[issue8426] multiprocessing.Queue fails to get() very large objects

Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file21709/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue8426] multiprocessing.Queue fails to get() very large objects

Brian Cain added the comment: Please don't close the issue. Joining aside, the basic point ("But when size = 7279, the data submitted reaches 64k, so the writting thread blocks on the write syscall.") is not clear from the docs, right? IMO, it would be nice if I could ask my queue, "Just what

[issue11849] ElementTree memory leak

kaifeng added the comment: I applied your patch to Python 3.2, also I added a function call to 'malloc_trim' via ctypes, as you can see in issue11849_test2.py. In fact I have a daemon written in Python 2.5, parsing an XML of size 10+ MB every 5 minutes, after 16+ hours running, the program fi

[issue11870] test_3_join_in_forked_from_thread() of test_threading hangs 1 hour on "x86 Ubuntu Shared 3.x"

Changes by Antoine Pitrou : -- nosy: +gps ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

Ned Deily added the comment: Maybe that buildbot machine is just overloaded. If I understand the buildbot waterfall output correctly, it looks like there are often 4 simultaneous test runs happening on that machine, one each for 2.7, 3.1, 3.2 and 3.x. http://www.python.org/dev/buildbot/all/w

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

STINNER Victor added the comment: Timing on the x86 Tiger buildbot: "time ./python.exe -m test -v -u largefile test_mmap" gives approx 5 minutes. The buildbot is a Mac mini, Intel Core Duo 1.8 GHz, 2 GB of memory, Mac OS X 10.4.10, HD: 232 GB (182 GB available) WDC WD2500BEVT-00A23T0. /usr/s

[issue10042] total_ordering

Raymond Hettinger added the comment: > I am curious, however, as to how this could break existing code. > It seems like code that relies on a stack overflow is already > broken as it is. Probably so. I worry about changes in semantics but it might be harmless. -- __

[issue10042] total_ordering

Alexander Boyd added the comment: Ok. I did write that against Python 2, so I wasn't aware of __eq__ and __ne__. I'll keep that in mind. I am curious, however, as to how this could break existing code. It seems like code that relies on a stack overflow is already broken as it is. --

[issue10042] total_ordering

Raymond Hettinger added the comment: It may seem pointless, but it takes less than a minute to do it and it would be both faster and clearer to do it manually. There's a limit to how much implicit code generation can or should be done automatically. Also, I'm not too keen on the feature cr

[issue5162] multiprocessing cannot spawn child from a Windows service

Changes by Brian Curtin : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue10042] total_ordering stack overflow

Alexander Boyd added the comment: But it seems pointless to force someone to implement all of the rich comparison methods when they may want to do something as simple as this: class Foo: ... def __lt__(self, other): if not isinstance(other, Foo): return NotImplement

[issue10042] total_ordering stack overflow

Raymond Hettinger added the comment: I'm not sure that we really care about handling NotImplemented (practicality beats purity). At some point, if someone writing a class wants complete control over the rich comparison methods, then they're going to have to write those methods. -- a

[issue11828] startswith and endswith don't accept None as slice index

Jesús Cea Avión added the comment: Torsten, could you possibly publish branches too for 3.2 and default (3.3)? -- ___ Python tracker ___

[issue10042] total_ordering stack overflow

Alexander Boyd added the comment: This is not fixed. The accepted fix doesn't take NotImplemented into account, with the result that comparing two mutually-incomparable objects whose ordering operations were generated with total_ordering causes a stack overflow instead of the expected "TypeEr

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

STINNER Victor added the comment: We can use the following function to check if the filesystem does support sparse files: def support_sparse_file(directory): import tempfile with tempfile.NamedTemporaryFile(dir=directory) as tmpfile: # Create a file with a size of 1 byte but w

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

Ned Deily added the comment: That said, on my iMac (2.4 Ghz Intel Core 2 Duo): $ time ./python -m test -v -u largefile test_mmap [...] -- Ran 24 tests in 87.673s OK 1 test OK. real1m27.875s user0m0.186s sys 0m8.6

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

Ned Deily added the comment: Note that the various HFS variants, the default file system types on OS X, do not support sparse files at all. So any tests of large files require at some point that the system writes out all the data in the file. http://developer.apple.com/library/mac/#documentat

[issue11871] test_default_timeout() of test_threading.BarrierTests failure: BrokenBarrierError

New submission from STINNER Victor : While trying to reproduce issue #11870 using "gdb -args ./python Lib/test/regrtest.py -F -v --timeout=600 test_threading", I had the following error on Linux: -- test_default_timeout (test.test_threading.BarrierTests) ... [Thread 0x7

[issue11800] regrtest --timeout: apply the timeout on a function, not on the whole file

STINNER Victor added the comment: A timeout of 60 minutes looks to be fine. Today I debuged a thread+signal issue which gave me an headache, so I prefer to close this issue: only add create thread per file, and not a thread per function. -- resolution: -> wont fix status: open -> clo

[issue10888] os.stat(filepath).st_mode gives wrong 'executable permission' result

Martin v. Löwis added the comment: Jeroen: I'm tempted to close this issue with no change. The code, as it stands, models what Microsoft does in it's CRT (see crt/src/stat.c:__tdtoxmode). There is also a straight-forward motivation to this: this is the list of extensions that you can pass to

[issue10888] os.stat(filepath).st_mode gives wrong 'executable permission' result

Sijin Joseph added the comment: >From reading http://support.microsoft.com/kb/899147 it does look like the .dll >extension needs to have the "Read & Execute" permission in order to have code >from the .dll be executed. It's odd that there isn't documentation that's >easily searchable to confi

[issue11863] Enforce PEP 11 - remove support for legacy systems

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue11779] test_mmap timeout (1 hour) on "AMD64 Snow Leopard 3.x" buildbot

STINNER Victor added the comment: Hum, it does still fail with a timeout of 1 hour: --- [ 41/354] test_mmap Timeout (1:00:00)! Thread 0x7fff70439ca0: File "/Users/pythonbuildbot/buildarea/3.x.hansen-osx-x86/build/Lib/test/test_mmap.py", line 685 in

[issue11869] Include information about the bug tracker Rietveld code review tool

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue11870] test_3_join_in_forked_from_thread() of test_threading hangs 1 hour on "x86 Ubuntu Shared 3.x"

New submission from STINNER Victor : test_3_join_in_forked_from_thread() of test_threading failed on "x86 Ubuntu Shared 3.x" buildbot: --- [201/354] test_threading [41179 refs] [40407 refs] [40407 refs] [40407 refs] Timeout (1:00:00)! Thread 0x404218c0: File "/s

[issue11869] Include information about the bug tracker Rietveld code review tool

New submission from Ned Deily : As far as I can see, the developer's guide does not mention at all the new Rietveld code review tool integration with the Python bug tracker. The guide should describe how the tool is expected to be used both by core developers reviewing submitted patches and b

[issue11868] Minor word-choice improvement in devguide "lifecycle of a patch" opening paragraph

Ned Deily added the comment: Thanks for the improvement. Applied in changeset cc43ed7af5f2. -- nosy: +ned.deily resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11731] Simplify email API via 'policy' objects

Roundup Robot added the comment: New changeset 2f3fda9d3906 by R David Murray in branch 'default': #11731: simplify/enhance parser/generator API by introducing policy objects. http://hg.python.org/cpython/rev/2f3fda9d3906 -- nosy: +python-dev ___ Pyt

[issue10946] bdist doesn’t pass --skip-build on to subcommands

Éric Araujo added the comment: > Could you please at least describe the test that you mentioned (link > doesn't work). I still have a local copy \o/. Yannick’s patch looks like this: def test_skip_build(self): pkg_pth, dist = self.create_dist() # With the skip_build option

[issue828450] sdist generates bad MANIFEST on Windows

Éric Araujo added the comment: Thanks for the patch. Follow the “review” link above to find my review. +1 on making the smallest possible change. The paths inside the Filelist/Manifest objects can continue to use os.sep, we only care about write_file for this bug. Oh, and also read_file: c

[issue9319] imp.find_module('test/badsyntax_pep3120') causes segfault

Andreas Stührk added the comment: How about applying the workaround patch to Python 3.2? An unprecise error message is way better than a segfault. -- ___ Python tracker ___

[issue11826] Leak in atexitmodule

Amaury Forgeot d'Arc added the comment: It's the very first usage of PyModuleDef::m_free. Martin, do you agree with the path? -- nosy: +amaury.forgeotdarc, loewis ___ Python tracker ___

[issue11858] configparser.ExtendedInterpolation and section case

Łukasz Langa added the comment: Thanks for the catch. I'll add some tests and push it. -- ___ Python tracker ___ ___ Python-bugs-list

[issue11858] configparser.ExtendedInterpolation and section case

Changes by Łukasz Langa : -- assignee: -> lukasz.langa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo added the comment: The “remote hg repo” is supposed to be the URI of a clone (not of a changeset) of cpython (not distutils2), so the repos you added don’t work. Can you remove them and add a patch file instead? Thanks. The first changeset looks good; I don’t understand the seco

[issue11849] ElementTree memory leak

Charles-Francois Natali added the comment: > kaifeng added the comment: > > I added 'malloc_trim' to the test code and rerun the test with Python 2.5 / > 3.2 on CentOS 5.3.  The problem still exists. > Well, malloc_trim can fail, but how did you "add" it ? Did you use patch to apply the diff

[issue11785] email subpackages documentation problems

Éric Araujo added the comment: Sure, +1 on using the submodule name in the module or currentmodule directive. -- ___ Python tracker ___ _

[issue11868] Minor word-choice improvement in devguide "lifecycle of a patch" opening paragraph

New submission from Carl Meyer : The opening paragraph of the "lifecycle of a patch" devguide page contains a confusing parenthetical aside implying that an "svn-like" workflow would mean never *saving* anything to your working copy and using "hg diff" to generate a patch. This is obviously wr

[issue8407] expose signalfd(2) and sigprocmask(2) in the signal module

STINNER Victor added the comment: sigprocmask or (better) pthread_sigmask is required to fix #11859 bug. --- Python has a test for "broken pthread_sigmask". Extract of configure.in: AC_MSG_CHECKING(if PTHREAD_SCOPE_SYSTEM is supported) AC_CACHE_VAL(ac_cv_pthread_system_supported,

[issue8407] expose signalfd(2) and sigprocmask(2) in the signal module

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue11828] startswith and endswith don't accept None as slice index

Changes by Torsten Becker : Removed file: http://bugs.python.org/file21706/2b48fd451c85.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue11828] startswith and endswith don't accept None as slice index

Changes by Torsten Becker : -- hgrepos: +22 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11828] startswith and endswith don't accept None as slice index

Changes by Torsten Becker : Added file: http://bugs.python.org/file21706/2b48fd451c85.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11828] startswith and endswith don't accept None as slice index

Torsten Becker added the comment: I pushed my changes to a hg repository, they are in the two branches "startswith-slices-issue11828-2.7" and "startswith-slices-issue11828-3.1". -- hgrepos: +21 ___ Python tracker

[issue5612] whitespace folding in the email package could be better ; -)

R. David Murray added the comment: This now works correctly in 3.2/3.3 (see issue 11492). Note that the whitespace compression is too deeply embeded in the 2.7 email package for there to be any way to fix it there. -- resolution: -> duplicate stage: test needed -> committed/rejected

[issue1372770] email.Header should preserve original FWS

R. David Murray added the comment: As of the fix for issue 11492, the email package only uses continuation_ws when folding RFC2047 encoded words. So I consider this issue fixed. (I have, by the way, come around to the view that we should never be introducing or deleting whitespace except wh

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

STINNER Victor added the comment: The deadlock is fixed. Reopen the issue if you still see test_threadsignals hang on a buildbot. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue8769] Straightforward usage of email package fails to round-trip

R. David Murray added the comment: This is fixed in 3.2/3.3 by the fix for issue 11492. The suggested fix for 2.7 is more radical than I'm comfortable with for a point release. I'm open to argument on that, but in the meantime I'm closing the issue with 11492 as the superseder. -- r

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

Roundup Robot added the comment: New changeset 7d355c2ff3d4 by Victor Stinner in branch '2.7': (Merge 3.1) Issue #11768: The signal handler of the signal module only calls http://hg.python.org/cpython/rev/7d355c2ff3d4 New changeset ebd080593351 by Victor Stinner in branch '2.7': Issue #11768: s

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

Roundup Robot added the comment: New changeset 319f7af9ee5e by Victor Stinner in branch '3.1': Issue #11768: The signal handler of the signal module only calls http://hg.python.org/cpython/rev/319f7af9ee5e New changeset 28ab8c6ad8f9 by Victor Stinner in branch '3.2': (Merge 3.1) Issue #11768: T

[issue11492] email.header.Header doesn't fold headers correctly

Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11492] email.header.Header doesn't fold headers correctly

Roundup Robot added the comment: New changeset 51a551acb60d by R David Murray in branch '3.2': #11492: rewrite header folding algorithm. Less code, more passing tests. http://hg.python.org/cpython/rev/51a551acb60d New changeset fcd20a565b95 by R David Murray in branch 'default': Merge: #11492:

[issue11241] ctypes: subclassing an already subclassed ArrayType generates AttributeError

Meador Inge added the comment: > But what happens with a third level? That doesn't work. I have a test case for that, but the test case has a typo that caused it to pass. I will fix the test case and the code. Thanks. -- ___ Python tracker

[issue11828] startswith and endswith don't accept None as slice index

Changes by R. David Murray : -- priority: -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue11867] Make test_mailbox deterministic

Changes by R. David Murray : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11867] Make test_mailbox deterministic

New submission from R. David Murray : Attached is a patch to remove the last sleeps from test_mailbox. I believe this makes the test suite deterministic. It also shaves 4 seconds of fixed overhead off the test run time. -- components: Tests files: mailbox_fork_with_ipc.patch keywords

[issue11862] urlparse.ParseResult to have meaningful __str__

Senthil Kumaran added the comment: Tomasz, I think, you misunderstood the purpose of urlparse library. urlparse is for parsing the URL and into its components. The url could be a mailto:, svn+ssh or http,https. The requirement for parsing comes when you are designing systems which take up UR

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' : -- versions: +Python 3.3 -Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Ernst Sjöstrand : -- nosy: +Ernst.Sjöstrand ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11862] urlparse.ParseResult to have meaningful __str__

Tomasz Melcer added the comment: If __str__ is meant to be a user-understandable way of expressing an URL, the best way to do that is to show it the same way user sees it in usually. This is now done by .geturl() call. This way I wouldn't have to remember to serialize it in cases where I want

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

Antoine Pitrou added the comment: Well, since it is a bugfix, you should apply it to all versions. -- ___ Python tracker ___ ___ Pyth

[issue11866] race condition in threading._newname()

New submission from Peter Saveliev : The _newname() function has no locking. It is called from the new thread constructor. Such constructor is executed within parent thread. So, when several threads create new threads simultaneously, there can be race condition, leading to the same name for tw

[issue11861] 2to3 fails with a ParseError

Amaury Forgeot d'Arc added the comment: This file has a SyntaxError! A comma is certainly missing at the end of line 47 -- nosy: +amaury.forgeotdarc resolution: -> invalid status: open -> closed ___ Python tracker

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

Changes by STINNER Victor : -- title: test_signals() of test_threadsignals failure on Mac OS X -> signal_handler() is not reentrant: deadlock in Py_AddPendingCall() ___ Python tracker _

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

Changes by STINNER Victor : Added file: http://bugs.python.org/file21703/signal_versionadded.patch ___ Python tracker ___ ___ Python-bugs-list

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

STINNER Victor added the comment: Le lundi 18 avril 2011 à 10:40 +, STINNER Victor a écrit : > Attached patch should fix this issue: > > - signal_handler() and PyErr_SetInterrupt() only call Py_AddPendingCall() on > the first signal (if is_tripped is zero): it should fix the deadlock and

[issue11768] signal_handler() is not reentrant: deadlock in Py_AddPendingCall()

Changes by STINNER Victor : -- title: test_signals() of test_threadsignals failure on Mac OS X -> signal_handler() is not reentrant: deadlock in Py_AddPendingCall() ___ Python tracker _

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

STINNER Victor added the comment: > I don't think so, please re-read. Oh, I thought that Py_AddPendingCall() was used to store the pending signal. But no, it asks Python main loop to check which signal has been trigerred, and we can only do it once for all signals. Attached patch should fix

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

STINNER Victor added the comment: > pthread_sigmask() can be used to avoid reentrant call, > but it has no effect on the second case: "signal_handler() > called twice at the same time in two different threads". Same problem if we use sa_mask field of sigaction() (e.g. use sigfillset(&context

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

Antoine Pitrou added the comment: > Antoine: if I understand correctly your patch, if we have a pending > signal, all next signals will be simply ignored. I don't think so, please re-read. -- ___ Python tracker _

[issue11768] test_signals() of test_threadsignals failure on Mac OS X

STINNER Victor added the comment: It looks like pthread_mutex_lock() and pthread_mutex_unlock() are not reentrant on some platforms (in some implementations of the pthread API). Antoine: if I understand correctly your patch, if we have a pending signal, all next signals will be simply ignored

[issue11849] ElementTree memory leak

kaifeng added the comment: Found a minor defect of Python 3.2 / 3.3: line 1676 of xml/etree/ElementTree.py was: del self.target, self._parser # get rid of circular references should be: del self.target, self._target, self.parser, self._parser # get rid of circular references While it d

[issue11835] python (x64) ctypes incorrectly pass structures parameter

Changes by Christoph Gohlke : -- nosy: +cgohlke ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue11865] typo in Py_AddPendingCall document

Ezio Melotti added the comment: Fixed, thanks for the report! -- assignee: docs@python -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.1, Python 3.2, Python 3.3 ___ Py

[issue11865] typo in Py_AddPendingCall document

Roundup Robot added the comment: New changeset fc2def15ab11 by Ezio Melotti in branch '2.7': #11865: fix typo in init.rst. http://hg.python.org/cpython/rev/fc2def15ab11 New changeset 6e090d78857c by Ezio Melotti in branch '3.1': #11865: fix typo in init.rst. http://hg.python.org/cpython/rev/6e0