Éric Araujo <mer...@netwok.org> added the comment: Thanks for the patch. Follow the “review” link above to find my review.
+1 on making the smallest possible change. The paths inside the Filelist/Manifest objects can continue to use os.sep, we only care about write_file for this bug. Oh, and also read_file: can you add tests for MANIFEST reading? It will be a bit more complicated: write a MANIFEST file with /-separated paths, set os.sep to \\, check that sdist works. You should learn a lot about our tests helpers (mostly TempdirManager). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue828450> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
