Re: [VOTE] Release PyLucene 2.4.1.y

2009-03-12 Thread Andi Vajda
On Mar 12, 2009, at 16:32, Christian Heimes wrote: Andi Vajda wrote: That's the problem. If I change my env or edit setup.py and config.py exists already because I already did a build, it is not going to be re-generated if I do 'python setup.py install' even though it should since 'install' c

Re: [VOTE] Release PyLucene 2.4.1.y

2009-03-12 Thread Christian Heimes
Andi Vajda wrote: > That's the problem. If I change my env or edit setup.py and config.py > exists already because I already did a build, it is not going to be > re-generated if I do 'python setup.py install' even though it should > since 'install' calls 'build' (and people expect it to) yet 'build

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Mar 12, 2009, at 13:10, Christian Heimes wrote: Andi Vajda wrote: if not os.path.exists(self.jcc_config_file): create_config = 1 else: create_config = 0 for command in self.distribution.commands: if command.startswith(("build", "bdist")): create_config = 1 break if crea

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Mar 12, 2009, at 13:07, Michael McCandless wrote: Michael McCandless wrote: A OK; this is quite confusing. Everyone seems to find it so. I advise Mac users at PARC to just use the system Python (unless and until they really know what they are doing). I will now do the same

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Bill Janssen wrote: Michael McCandless wrote: Michael McCandless wrote: A OK; this is quite confusing. Everyone seems to find it so. I advise Mac users at PARC to just use the system Python (unless and until they really know what they are doing). I will now do the same to all M

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Bill Janssen
Michael McCandless wrote: > Michael McCandless wrote: > > >>> A OK; this is quite confusing. > >> > >> Everyone seems to find it so. I advise Mac users at PARC to just use > >> the system Python (unless and until they really know what they are > >> doing). > > > > I will now do the same to

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
jcc/jcc/config.py? Indeed it reflects my addition of -F/System/..., with this: LFLAGS=['-framework', 'JavaVM', '-F/System/Library/Frameworks', '- framework', 'Python'] But, weirdly, I don't then see that in the final linking step when running "make" in the pylucene dir. Here's the

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Christian Heimes
Michael McCandless wrote: > Weird, that was not what I was seeing. > > I think I cd'd to jcc, added -F into setup.py, "rm -r build", python > (coming from the right framework) setup.py build (confirmed -F worked), > sudo python setup.py install, cd .., make clean, make, and I didn't see > the -F f

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Andi Vajda wrote: On Mar 12, 2009, at 12:40, Michael McCandless > wrote: Andi Vajda wrote: On Thu, 12 Mar 2009, Michael McCandless wrote: Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run t

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Christian Heimes
Andi Vajda wrote: >> if not os.path.exists(self.jcc_config_file): >>create_config = 1 >> else: >>create_config = 0 >> >> for command in self.distribution.commands: >>if command.startswith(("build", "bdist")): >>create_config = 1 >>break >> >> if create_config: >>self

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Michael McCandless wrote: A OK; this is quite confusing. Everyone seems to find it so. I advise Mac users at PARC to just use the system Python (unless and until they really know what they are doing). I will now do the same to all Mac+Python people I know & meet ;) Though... It'd be

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Mar 12, 2009, at 12:40, Michael McCandless wrote: Andi Vajda wrote: On Thu, 12 Mar 2009, Michael McCandless wrote: Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run the tests successfull

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Bill Janssen wrote: Michael McCandless wrote: Bill Janssen wrote: Michael McCandless wrote: But why do I have two separate 2.5 Python installs, compiled w/ different options, in the first place? It's weird and I'd like to fix it, I think (outside of building PyLucene, for my own sanity

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Bill Janssen
Michael McCandless wrote: > Bill Janssen wrote: > > > Michael McCandless wrote: > > > >> But why do I have two separate 2.5 Python installs, compiled w/ > >> different options, in the first place? It's weird and I'd like to > >> fix > >> it, I think (outside of building PyLucene, for my own sa

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Andi Vajda wrote: On Thu, 12 Mar 2009, Michael McCandless wrote: Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run the tests successfully! Do not pollute your env with soft links. Use -F instead

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Bill Janssen wrote: Michael McCandless wrote: But why do I have two separate 2.5 Python installs, compiled w/ different options, in the first place? It's weird and I'd like to fix it, I think (outside of building PyLucene, for my own sanity). One (the one in /Library) is the Python.org

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Bill Janssen
Michael McCandless wrote: > But why do I have two separate 2.5 Python installs, compiled w/ > different options, in the first place? It's weird and I'd like to fix > it, I think (outside of building PyLucene, for my own sanity). One (the one in /Library) is the Python.org install, which I avoid

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Andi Vajda wrote: On Thu, 12 Mar 2009, Michael McCandless wrote: Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run the tests successfully! Do not pollute your env with soft links. Use -F instead

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Thu, 12 Mar 2009, Michael McCandless wrote: Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run the tests successfully! Do not pollute your env with soft links. Use -F instead. Really. Maybe it'

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Thu, 12 Mar 2009, Michael McCandless wrote: OK I was able to finally build (OS X 10.5.6) and run all tests successfully. I hit a few OS X issues that I think are my silliness/confused environment. I'll try to document them here, for future Google diggers, but note that I sort of desperatel

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Anyway, finally, a little bruised from the whole process, and wondering what other Python things on my Mac may now be broken... I was able to run the tests successfully! Maybe it's ambitious... but I'd really love a "for the impatient...", in INSTALL, like this: pushd jcc python setup.py

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
OK I was able to finally build (OS X 10.5.6) and run all tests successfully. I hit a few OS X issues that I think are my silliness/confused environment. I'll try to document them here, for future Google diggers, but note that I sort of desperately rushed though things trying to get it to work s

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Thu, 12 Mar 2009, Christian Heimes wrote: Andi Vajda wrote: In other words, you're fixing this with this patch by introducing another such inconvenience, both with a silent failure. It doesn't look like the trade off is worthwhile. This is not saying anything about the quality or clevernes

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Christian Heimes
Andi Vajda wrote: > In other words, you're fixing this with this patch by introducing > another such inconvenience, both with a silent failure. It doesn't look > like the trade off is worthwhile. > > This is not saying anything about the quality or cleverness of the patch > itself. It taught me so

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Andi Vajda
On Thu, 12 Mar 2009, Christian Heimes wrote: I've attached a patch that hooks into the build process. With the patch the config file is created right before the .py files are copied into the build directory. Thanks for the patch. A few comments: def run(self): if (not os.path.ex

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Christian Heimes
Christian Heimes wrote: [...] I forgot to include the changes in jcc/python.py. You have to rename SHARED to ENABLE_SHARED. Christian

Exception in wrapped method ignored

2009-03-12 Thread Christian Heimes
Dear Andi! Today I noticed an issue with exception handling during my work on PDFBox. I had a typo in a Python method that overwrites a Java method. Although the typo should have raised an exception, the exeption didn't show up. I conclude that JCC swallows exceptions that occur in native Python

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Christian Heimes
Andi Vajda wrote: > Does 'install' without 'build' invoke 'build' ? > If that's the case, then yeah, there is a problem and this should be > backed out. If not, then where is the problem ? 'install' without a > prior 'build' would make no sense, no ? Yes, it does. Every step in the installation pr

Re: [VOTE] Release PyLucene 2.4.1

2009-03-12 Thread Michael McCandless
Andi, one small thing: when you upload a new RC, you should remove the old ones just to reduce chances for confusion... Mike Andi Vajda wrote: On Wed, 11 Mar 2009, Aric Coady wrote: On Mar 11, 2009, at 10:06 AM, Andi Vajda wrote: With the recent release of Java Lucene 2.4.1, it's high t