Re: webhelpers.paginate fails on explicit mapper

2010-11-06 Thread Ben Bangert
On Nov 6, 2010, at 1:14 PM, Marius Gedminas wrote: > FWIW this looks like http://pylonshq.com/project/pylonshq/ticket/675 > > Was that the wrong place to report a webhelpers bug? Yes, there's an issue tracker for it on bitbucket with the project here: https://bitbucket.org/bbangert/webhelpers/is

Re: webhelpers.paginate fails on explicit mapper

2010-11-06 Thread Marius Gedminas
On Sep 20, 11:14 pm, Christoph Haas wrote: > Thanks for the fix, Mike. I'll try to keep a closer eye on paginate > issues in the future. :) FWIW this looks like http://pylonshq.com/project/pylonshq/ticket/675 Was that the wrong place to report a webhelpers bug? -- Marius Gedminas -- You recei

Re: webhelpers.paginate fails on explicit mapper

2010-09-20 Thread Christoph Haas
Thanks for the fix, Mike. I'll try to keep a closer eye on paginate issues in the future. :) Christoph Am 18.09.2010 20:04, schrieb Mike Orr: > On Sat, Sep 18, 2010 at 4:52 AM, Christoph Haas > wrote: >> Hi, Max… >> >> I'm in charge of the paginate code. Just didn't pay close attention to >> t

Re: webhelpers.paginate fails on explicit mapper

2010-09-18 Thread Mike Orr
On Sat, Sep 18, 2010 at 4:52 AM, Christoph Haas wrote: > Hi, Max… > > I'm in charge of the paginate code. Just didn't pay close attention to > the pylons-devel mailing list for a while. So excuse the late reply. I just implemented it in WebHelpers-dev. Although it sounds like he has an old applic

Re: webhelpers.paginate fails on explicit mapper

2010-09-18 Thread Christoph Haas
Hi, Max… I'm in charge of the paginate code. Just didn't pay close attention to the pylons-devel mailing list for a while. So excuse the late reply. Am 01.07.2010 14:44, schrieb Max Sinelnikov: > I'm working on a pylons project and found a problem with > webhelpers.paginate.Page._pagerlink. I'm u

Re: webhelpers.paginate fails on explicit mapper

2009-04-29 Thread Clemens Hermann
Mike, thanks for your explanations. > Anyway, I'd be more in favor of getting the navigator out of Paginate, > so that it's not doing this url_for backdoor. I like the easy way paginate allows to produce a navigator. Why not just add an additional keyword - say url - to the Page class and alter

Re: webhelpers.paginate fails on explicit mapper

2009-04-29 Thread Mike Orr
On Wed, Apr 29, 2009 at 12:36 AM, Clemens Hermann wrote: >> You could put a paginate subclass under >> webhelpers.pylons, which would keep the Pylons-specific code separate >> from the generic code. > > currently there is no dependency on pylons but on routes (or did I > miss a nested dependency?

Re: webhelpers.paginate fails on explicit mapper

2009-04-29 Thread Clemens Hermann
Mike, Christoph , > I still have to analyze Christoph's patches, but I do want to say, I > want to get away from magic as much as we can. I totally agree. The magic that currently exists in pylons at some places was/is the single most difficult thing for me when trying to understand what's going

Re: webhelpers.paginate fails on explicit mapper

2009-04-28 Thread Mike Orr
On Tue, Apr 28, 2009 at 1:56 AM, Clemens Hermann wrote: > > Christoph , > >> >  p.pager(controller='ctrl', action='act') >> >> If I understand the explicit stuff correctly then this should be the right >> way to use it. Right? > > depends on what you want to do :). > My patch frees you from provi

Re: webhelpers.paginate fails on explicit mapper

2009-04-28 Thread Clemens Hermann
Christoph , > > p.pager(controller='ctrl', action='act') > > If I understand the explicit stuff correctly then this should be the right > way to use it. Right? depends on what you want to do :). My patch frees you from providing the controller/action explicitly as they can be pulled out of a re

Re: webhelpers.paginate fails on explicit mapper

2009-04-27 Thread Christoph Haas
Moin, Am Montag, 27. April 2009 18:47:38 schrieb Clemens Hermann: > I modified the patch slightly to get rid of the AttributeError here: > http://paste.pocoo.org/show/114528/. Great, thanks. The patch is working perfectly. > However, as you do no longer have a default controller/action you'll >

Re: webhelpers.paginate fails on explicit mapper

2009-04-27 Thread Clemens Hermann
Mike, > I think I ran into this problem and worked around it by making my > template at a higher level that avoids pagelink. paginate.Page and paginate.Page.pager accept arbitrary additional keyword arguments. These get passed to url_for. Hence you can use them to provide the controller/action f

Re: webhelpers.paginate fails on explicit mapper

2009-04-27 Thread Clemens Hermann
Moin Christoph, > > if routes.Mapper is configured with explicit=True (as recommended) > > then webhelpers.paginate.Page._pagerlink fails. > > Thanks, I didn't even notice that. I can reproduce the problem. > > > This patch fixes the issue:http://paste.pocoo.org/show/112812/ > > Not for me yet. >