[pve-devel] [PATCH storage] Fix #2346: rbd: storage shows wrong %-usage

2019-09-02 Thread Alwin Antreich
d' now has the data after replication for the pool. The new calculation will be used only if all OSDs are running with the on-disk format introduced by Ceph 14.2.2. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[pve-devel] [PATCH storage v2] Fix #2346: rbd storage shows wrong %-usage

2019-09-03 Thread Alwin Antreich
d' now has the data after replication for the pool. The new calculation will be used only if all OSDs are running with the on-disk format introduced by Ceph 14.2.2. Signed-off-by: Alwin Antreich --- v1 -> v2: checks now if key is defined and not for just truth PVE/Storage/RBDPlugin.pm |

[pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-07 Thread Alwin Antreich
Machine states that were created on snapshots with memory could not be restored on rollback. The state volume was not activated so KVM couldn't load the state. This patch moves the path generation into vm_start and de-/activates the state volume. Signed-off-by: Alwin Antreich ---

Re: [pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-08 Thread Alwin Antreich
On Tue, Oct 08, 2019 at 08:36:57AM +0200, Fabian Grünbichler wrote: > On October 7, 2019 2:41 pm, Alwin Antreich wrote: > > Machine states that were created on snapshots with memory could not be > > restored on rollback. The state volume was not activated so KVM couldn'

Re: [pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-08 Thread Alwin Antreich
On Tue, Oct 08, 2019 at 12:31:06PM +0200, Fabian Grünbichler wrote: > On October 8, 2019 11:25 am, Alwin Antreich wrote: > > On Tue, Oct 08, 2019 at 08:36:57AM +0200, Fabian Grünbichler wrote: > >> On October 7, 2019 2:41 pm, Alwin Antreich wrote: > >> > Machi

[pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-10 Thread Alwin Antreich
turn disallows the use of path based statefiles when used with the '--stateuri' option on 'qm start'. Only 'tcp', 'unix' and our storage based URIs can be used now. Signed-off-by: Alwin Antreich --- PVE/QemuConfig.pm | 3 +-- PVE/QemuServer.pm | 8 +---

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > On 10/10/19 3:58 PM, Alwin Antreich wrote: > > Machine states that were created on snapshots with memory could not be > > restored on rollback. The state volume was not activated so KVM couldn't > > loa

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > On 10/11/19 12:02 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > >> On 10/10/19 3:58 PM, Alwin Antreich wrote: > >>> Machine states that were cr

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-14 Thread Alwin Antreich
On Mon, Oct 14, 2019 at 11:44:59AM +0200, Thomas Lamprecht wrote: > On 10/11/19 1:45 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > >> On 10/11/19 12:02 PM, Alwin Antreich wrote: > >>> On Fri, Oct 11, 2019 at 07:1

[pve-devel] [PATCH qemu-server v3] Fix #2171: VM statefile was not activated

2019-10-17 Thread Alwin Antreich
$conf->{vmstate} so config_to_command can activate, generate and assign the path to '-loadstate'. Any file/device based statefile will be added directly to -loadstate. Signed-off-by: Alwin Antreich --- Note: V1 -> V2: re-use resume code for rollback, incorporate

[pve-devel] [PATCH docs 08/11] pveceph: Reorganize TOC for new sections

2019-11-04 Thread Alwin Antreich
-off-by: Alwin Antreich --- pveceph.adoc | 79 ++-- 1 file changed, 45 insertions(+), 34 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 9806401..2972a68 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -234,11 +234,8 @@ configuration file

[pve-devel] [PATCH docs 10/11] Fix #1958: pveceph: add section Ceph maintenance

2019-11-04 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 54 1 file changed, 54 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 087c4d0..127e3bb 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -331,6 +331,7 @@ network. In a Ceph cluster

[pve-devel] [PATCH docs 00/11] pveceph: update doc

2019-11-04 Thread Alwin Antreich
In patch 11 I have added an attribute to asciidoc-pve.conf to replace Ceph's codename. I hope this is the right location for this. Review and suggestions are very welcome. Thanks. :) Alwin Antreich (11): pveceph: old style commands to subcommands pveceph: add section - Destroying Ceph

[pve-devel] [PATCH docs 09/11] pveceph: rename CephFS subtitles

2019-11-04 Thread Alwin Antreich
to reflect the same active voice style as the other subtitles in pveceph Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 2972a68..087c4d0 100644 --- a/pveceph.adoc +++ b/pveceph.adoc

[pve-devel] [PATCH docs 07/11] pveceph: switch note for Creating Ceph Manager

2019-11-04 Thread Alwin Antreich
to be more consistent with other sections, the note for creating the Ceph Manager was moved below the command. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index a4f2e4e..9806401 100644 --- a

[pve-devel] [PATCH docs 01/11] pveceph: old style commands to subcommands

2019-11-04 Thread Alwin Antreich
Replace remaining old style single commands with current subcommands Signed-off-by: Alwin Antreich --- pveceph.adoc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index ebf9ef7..cfb86a8 100644 --- a/pveceph.adoc +++ b/pveceph.adoc

[pve-devel] [PATCH docs 11/11] pveceph: add attribute ceph_codename

2019-11-04 Thread Alwin Antreich
To change the codename for Ceph in one place, the patch adds the asciidoc attribute 'ceph_codename'. Replaces the outdated references to luminous and the http -> https on the links in pveceph.adoc. Signed-off-by: Alwin Antreich --- pveceph.adoc

[pve-devel] [PATCH docs v2 00/10] pveceph: update doc

2019-11-06 Thread Alwin Antreich
mands" Review and suggestions are very welcome. Thanks. :) Alwin Antreich (10): pveceph: add section - Destroying Ceph OSDs pveceph: add section - Destroying Ceph Monitor pveceph: add Ceph Monitor screenshot pveceph: add section - Destroying Ceph Manager pveceph: add section - Destroyi

[pve-devel] [PATCH docs v2 09/10] Fix #1958: pveceph: add section Ceph maintenance

2019-11-06 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 55 1 file changed, 55 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 66ea111..0d62943 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -331,6 +331,7 @@ network. It is recommended

[pve-devel] [PATCH docs v2 08/10] pveceph: correct CephFS subtitle

2019-11-06 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index e97e2e6..66ea111 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -659,8 +659,8 @@ refer to the ceph documentation. footnote:[Configuring

[pve-devel] [PATCH docs v2 07/10] pveceph: Reorganize TOC for new sections

2019-11-06 Thread Alwin Antreich
-off-by: Alwin Antreich --- pveceph.adoc | 95 +--- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index dbfe909..e97e2e6 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -212,8 +212,8 @@ This sets up an `apt

[pve-devel] [PATCH docs v2 06/10] pveceph: switch note for Creating Ceph Manager

2019-11-06 Thread Alwin Antreich
to be more consistent with other sections, the note for creating the Ceph Manager was moved below the command. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 5933cc8..dbfe909 100644 --- a

[pve-devel] [PATCH docs v2 10/10] pveceph: add attribute ceph_codename

2019-11-06 Thread Alwin Antreich
To change the codename for Ceph in one place, the patch adds the asciidoc attribute 'ceph_codename'. Replaces the outdated references to luminous and the http -> https on the links in pveceph.adoc. Signed-off-by: Alwin Antreich --- pveceph.adoc

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

2019-11-06 Thread Alwin Antreich
On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > qm.adoc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 9ee4460..c0fe892 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -856,6 +856,8 @@ Select the folder to

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

2019-11-06 Thread Alwin Antreich
On Wed, Nov 06, 2019 at 03:45:26PM +0100, Aaron Lauterer wrote: > Hmm, What about: > > Currently this feature does not work reliably. > > > On 11/6/19 3:29 PM, Alwin Antreich wrote: > > On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > > &

[pve-devel] [PATCH docs] Fix: pveceph: broken ref anchor pveceph_mgr_create

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index ef257ac..99c610a 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -286,7 +286,7 @@ monitor the cluster. Since the Ceph luminous release at least

[pve-devel] [PATCH docs] Fix: pveceph: spelling in section Trim/Discard

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 99c610a..122f063 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -762,9 +762,9 @@ Trim/Discard It is a good measure to run

[pve-devel] [PATCH manager] ceph: Create symlink on standalone MGR creation

2019-12-03 Thread Alwin Antreich
Ceph MGR fails to start when installed on a node without existing symlink to /etc/pve/ceph.conf. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/MGR.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Ceph/MGR.pm b/PVE/API2/Ceph/MGR.pm index d3d86c0d..ffae7495 100644 --- a/PVE/API2

[pve-devel] [PATCH proxmox-ve] Update kernel links for install CD (rescue boot)

2019-12-03 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- Note: Thanks to Stoiko, he build an ISO to test the patch. This works with LVM based installs, but fails currently for ZFS with "Compression algorithm inherit not supported. Unable to find bootdisk automatically" debian/postinst |

Re: [pve-devel] [PATCH manager] API: OSD: Fix #2496 Check OSD Network

2019-12-13 Thread Alwin Antreich
Some comments inline. On Fri, Dec 13, 2019 at 03:56:42PM +0100, Aaron Lauterer wrote: > It's possible to have a situation where the cluster network (used for > inter-OSD traffic) is not configured on a node. The OSD can still be > created but can't communicate. > > This check will abort the creat

Re: [pve-devel] [PATCH ceph 1/2] fix Ceph version string handling

2020-01-09 Thread Alwin Antreich
Hello Martin, On Thu, Jan 09, 2020 at 02:23:07PM +0100, Martin Verges wrote: > Hello Thomas, > > 1. we provide 14.2.5, the latest stable release available (we have upcoming > > 14.2.6 already on track) > > > > Good to know, does not seem to be a knowledge that some proxmox users have > nor was i

[pve-devel] [PATCH container] Fix: fsck: rbd volume not mapped

2020-01-13 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 98e2c6e..9dee68d 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -247,7 +247,7 @@ __PACKAGE__->register_met

[pve-devel] [PATCH container v2] Fix: fsck: rbd volume not mapped

2020-01-17 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- V1 -> V2: run unmap only if it has a storage id. src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 98e2c6e..ec071c5 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct

[pve-devel] [PATCH container v2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
kup files more compact, easier to read (hopefully) * less code changes for container restores Thanks for any comment or suggestion in advance. [0] https://facebook.github.io/zstd/ __pve-container__ Alwin Antreich (1): Fix: #2124 add zstd support src/PVE/LXC/Create.pm | 1 + 1 f

[pve-devel] [PATCH container v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- v1 -> v2: less code changes for container restores src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index c13f30d..65d5068 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create

[pve-devel] [PATCH storage v2 3/3] Fix: #2124 storage: add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 10 +++--- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bf12634..51c8bc9 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -514,7 +514,7 @@ sub

[pve-devel] [PATCH storage v2 1/3] compact regex for backup file filter

2020-01-31 Thread Alwin Antreich
this, more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 2 +- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 0bd103e

[pve-devel] [PATCH guest-common v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..a661552 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc

[pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Adds the zstd to the compression selection for backup on the GUI and the .zst extension to the backup file filter. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 6 -- www/manager6/form/CompressionSelector.js | 3 ++- 2 files changed, 6 insertions(+), 3

[pve-devel] [PATCH storage v2 2/3] storage: merge archive format/compressor

2020-01-31 Thread Alwin Antreich
detection into a separate function to reduce code duplication and allow for easier modification. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 78 -- 1 file changed, 57 insertions(+), 21 deletions(-) diff --git a/PVE/Storage.pm b/PVE

[pve-devel] [PATCH qemu-server v2 2/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ff7dcab..8af1cb6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7217,7 +7217,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH manager v2 2/2] Fix #2124: Add zstd pkg as install dependency

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index bcc6bb6e..497395da 100644 --- a/debian/control +++ b/debian/control @@ -60,6 +60,7 @@ Depends: apt-transport-https | apt (>= 1.5~), logrot

[pve-devel] [PATCH qemu-server v2 1/2] restore: replace archive regex

2020-01-31 Thread Alwin Antreich
to reduce the code duplication, as archive_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index

Re: [pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-02-04 Thread Alwin Antreich
On Mon, Feb 03, 2020 at 05:51:38PM +0100, Stefan Reiter wrote: > On 1/31/20 5:00 PM, Alwin Antreich wrote: > > Adds the zstd to the compression selection for backup on the GUI and the > > .zst extension to the backup file filter. > > > > Signed-off-by: Alwin Antre

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2020-02-05 Thread Alwin Antreich
On Thu, Nov 14, 2019 at 03:01:37PM +0100, Thomas Lamprecht wrote: > On 11/14/19 6:30 AM, Dietmar Maurer wrote: > >> The main reason for this is to identify backups residing on an old backup > >> store like an archive. > >> > >> But I am open. Would you prefer having a manifest included in the ar

[pve-devel] [PATCH docs] pveceph: reword memory precondition

2020-02-17 Thread Alwin Antreich
and add the memory target for OSDs, included since Luminous. As well as distinguish the memory usage between the OSD backends. Signed-off-by: Alwin Antreich --- pveceph.adoc | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index

[pve-devel] [PATCH manager 2/3] Fix: ceph: mon_address not considered by new MON

2020-03-11 Thread Alwin Antreich
- public_network is in the ceph.conf * with a single network, take the first available IP * on multiple networks, walk through the list orderly and start on the first network where an IP is found Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/MON.pm | 9 +++-- 1 file changed, 3

[pve-devel] [PATCH manager 3/3] Fix #2422: allow multiple Ceph public networks

2020-03-11 Thread Alwin Antreich
Multiple public networks can be defined in the ceph.conf. The networks need to be routed to each other. On first service start the Ceph MON will register itself with one of the IPs configured locally, matching one of the public networks defined in the ceph.conf. Signed-off-by: Alwin Antreich

[pve-devel] [PATCH manager 1/3] ceph: remove unused variable assignment

2020-03-11 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Ceph/Services.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm index c17008cf..7015cafe 100644 --- a/PVE/Ceph/Services.pm +++ b/PVE/Ceph/Services.pm @@ -63,7 +63,6 @@ sub get_cluster_service { sub

Re: [pve-devel] [PATCH qemu-server 1/2] Disable memory hotplugging for custom NUMA topologies

2020-03-19 Thread Alwin Antreich
here, since it otherwise fails early with "total > memory for NUMA nodes must be equal to vm static memory". > > With this change the error message reflects what is actually happening > and doesn't allow VMs with exactly 1GB of RAM either. > > Signed-off-by: Stef

Re: [pve-devel] [PATCH qemu-server 2/2] Die on misaligned memory for hotplugging

2020-03-19 Thread Alwin Antreich
On Wed, Mar 18, 2020 at 04:18:45PM +0100, Stefan Reiter wrote: > ...instead of booting with an invalid config once and then silently > changing the memory size for consequent VM starts. > > Signed-off-by: Stefan Reiter > --- Tested-by: Alwin Antreich > > This confused

Re: [pve-devel] Patch about Intel processors flaw

2018-01-05 Thread Alwin Antreich
Hello Gilberto, On Thu, Jan 04, 2018 at 03:36:36PM -0200, Gilberto Nunes wrote: > Hi list > > Is there any patch to PVE Kernel about Intel processors flaw?? Please, follow up on the thread on our forum. https://forum.proxmox.com/threads/fuckwit-kaiser-kpti.39025/ > > > --- > Gilberto Ferreira > >

[pve-devel] [PATCH storage 3/3] Fix typo in sub s/krdb_feature_disable/krbd_feature_disable

2018-02-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index ef9fc4a..83c1924 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -101,7 +101,7

[pve-devel] [PATCH storage 2/3] krbd: remove 'exclusive-lock' from blacklist, kernel-4.13

2018-02-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 804dded..ef9fc4a 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -109,7 +109,7 @@ my

[pve-devel] [PATCH storage 1/3] Fix #1574: could not disable krbd-incompatible image features

2018-02-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2ca14ef..804dded 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm

[pve-devel] [PATCH storage v2] Fix #1574: could not disable krbd-incompatible image features

2018-03-01 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2ca14ef..06e0a0a 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm

Re: [pve-devel] NACK: [PATCH storage 2/3] krbd: remove 'exclusive-lock' from blacklist, kernel-4.13

2018-03-01 Thread Alwin Antreich
On Thu, Mar 01, 2018 at 10:59:15AM +0100, Fabian Grünbichler wrote: > this is problematic because it potentially hides bugs in our application > logic, with currently no benefit. > > with exclusive-locks disabled, mapping on multiple hosts is possible, > but mounting the same image is not (e.g., wh

[pve-devel] [PATCH storage 2/2 v2] Fix typo in sub s/krdb_feature_disable/krbd_feature_disable

2018-03-02 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 06e0a0a..9e0e720 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -101,7 +101,7

[pve-devel] [PATCH storage 1/2 v2] Fix #1574: could not disable krbd-incompatible image features

2018-03-02 Thread Alwin Antreich
To prevent an error when disabling features of a rbd image with already disabled flags. This aborted the CT/VM cloning halfway through with a leftover rbd image, but no vmid.conf to it. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 17 ++--- 1 file changed, 14

Re: [pve-devel] NACK: [PATCH storage 2/3] krbd: remove 'exclusive-lock' from blacklist, kernel-4.13

2018-03-05 Thread Alwin Antreich
On Thu, Mar 01, 2018 at 04:23:32PM +0100, Alwin Antreich wrote: > On Thu, Mar 01, 2018 at 10:59:15AM +0100, Fabian Grünbichler wrote: > > this is problematic because it potentially hides bugs in our application > > logic, with currently no benefit. > > > > with exclusive

[pve-devel] [PATCH container 2/2] Remove obsolete read from storage.cfg in vm_start api call

2018-03-09 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC/Status.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index 976f264..b98dc24 100644 --- a/src/PVE/API2/LXC/Status.pm +++ b/src/PVE/API2/LXC/Status.pm @@ -185,8 +185,6

[pve-devel] [PATCH container 1/2] Fix #1547: on migration abort, the CT starts again

2018-03-09 Thread Alwin Antreich
When a migration fails, the final_cleanup phase now starts the container on the source node again, if it was a migration in restart_mode and the CT was running. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC/Status.pm | 8 +--- src/PVE/LXC.pm | 14 ++ src/PVE

[pve-devel] [PATCH container] Fix pct skiplock

2018-03-13 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch keeps the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- src/PVE/LXC.pm| 9 - src/lxc

[pve-devel] [PATCH container v2] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: after discussion with Fabian, I removed

[pve-devel] [PATCH container v3] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: after discussion with Fabian, I removed

[pve-devel] [PATCH container v4] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: this version changes the path of the

[pve-devel] [PATCH container v5] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: made changes by Dietmar's comments

[pve-devel] [PATCH container 2/2] Addition to #1544, implement delete lock in lxc api path

2018-03-16 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- note: not sure, if there needs to be some extra handling for deleting the lock src/PVE/LXC/Config.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 7b27be1..08139df 100644 --- a/src/PVE/LXC/Config.pm

[pve-devel] [PATCH container 1/2] Fix #1544: add skiplock to lxc api path

2018-03-16 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC/Config.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 2b622b3..2d69049 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Config.pm @@ -80,6

[pve-devel] [PATCH librados2-perl] Split method pve_rados_connect

2018-03-30 Thread Alwin Antreich
To be able to connect through librados2 without a config file, the method pve_rados_connect is split up into pve_rados_connect and pve_rados_conf_read_file. Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 9 - RADOS.xs | 26 +- 2 files changed, 29

Re: [pve-devel] [PATCH librados2-perl] Split method pve_rados_connect

2018-04-04 Thread Alwin Antreich
On Tue, Apr 03, 2018 at 02:13:18PM +0200, Dietmar Maurer wrote: > comments inline > > > On March 30, 2018 at 12:25 PM Alwin Antreich wrote: > > > > > > To be able to connect through librados2 without a config file, the > > method pve_rados_connect is

Re: [pve-devel] [PATCH librados2-perl] Split method pve_rados_connect

2018-04-04 Thread Alwin Antreich
On Tue, Apr 03, 2018 at 10:25:53AM +0200, Thomas Lamprecht wrote: > > Am 03/30/2018 um 12:25 PM schrieb Alwin Antreich: > > To be able to connect through librados2 without a config file, the > > method pve_rados_connect is split up into pve_rados_connect and > >

[pve-devel] [PATCH v2 librados2-perl 2/3] Split method pve_rados_connect

2018-04-04 Thread Alwin Antreich
To be able to connect through librados2 without a config file, the method pve_rados_connect is split up into pve_rados_connect and pve_rados_conf_read_file. Signed-off-by: Alwin Antreich --- changes from v1 -> v2: - die if the supplied ceph config in %params does not exist - removed the FI

[pve-devel] [PATCH v2 librados2-perl 1/3] white space cleanup

2018-04-04 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- note: seems that, this one is need for the following patches to apply PVE/RADOS.pm | 12 ++-- RADOS.xs | 32 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index aa6a102

[pve-devel] [PATCH v2 librados2-perl 3/3] allow to specify the userid with rados_create

2018-04-04 Thread Alwin Antreich
This allows to connect to a cluster with a different user, besides admin Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 4 +++- RADOS.xs | 13 ++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index 2ed92b7..d53f655 100644 --- a/PVE

Re: [pve-devel] [PATCH v2 librados2-perl 1/3] white space cleanup

2018-04-05 Thread Alwin Antreich
ial > space (in patches the first character in a line is special: '-' means > remove, > '+' means add line, ' ' (space) means this line stays the same). > > So you patch, as is, cannot work! > > Am 04/04/2018 um 05:37 PM schrieb Alwin Antreich: >

[pve-devel] [PATCH v2 librados2-perl 1/3] white space cleanup

2018-04-05 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 12 ++-- RADOS.xs | 32 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index aa6a102..aff8141 100644 --- a/PVE/RADOS.pm +++ b/PVE/RADOS.pm @@ -43,7 +43,7

[pve-devel] [PATCH v2 librados2-perl 0/3] resend of last series

2018-04-05 Thread Alwin Antreich
I am resending the last series, as my vim removed trailing whitespace after I annotated the patch (added v2), before sending it with git. I hope the patches apply now. :) Alwin Antreich (3): white space cleanup Split method pve_rados_connect allow to specify the userid with rados_create

[pve-devel] [PATCH v2 librados2-perl 3/3] allow to specify the userid with rados_create

2018-04-05 Thread Alwin Antreich
This allows to connect to a cluster with a different user, besides admin Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 4 +++- RADOS.xs | 13 ++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index 2ed92b7..d53f655 100644 --- a/PVE

[pve-devel] [PATCH v2 librados2-perl 2/3] Split method pve_rados_connect

2018-04-05 Thread Alwin Antreich
To be able to connect through librados2 without a config file, the method pve_rados_connect is split up into pve_rados_connect and pve_rados_conf_read_file. Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 11 +++ RADOS.xs | 26 +- 2 files changed, 32

[pve-devel] [PATCH v2 storage 2/2] Refactor of method build_cmd and path

2018-04-09 Thread Alwin Antreich
Method build_cmd and path use similar code to generate the ceph command line or qemu config parameters. They now use the private method ceph_connect_option for parameter generation. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 113

[pve-devel] [PATCH v2 storage 0/2] show storage-utilization per pool

2018-04-09 Thread Alwin Antreich
age status calculates a percent_used for ceph clusters prior Kraken, in releases >= Kraken the percent_used is provided by ceph. The GUI, while not using the percent_used, will show correct values, with the exception when a recovery is running. The CLI uses the percent_used. Alwin Antreich (2): Fi

[pve-devel] [PATCH v2 storage 1/2] Fix #1542: show storage utilization per pool

2018-04-09 Thread Alwin Antreich
- get the percent_used value for a ceph pool and calculate it where ceph doesn't supply it (pre kraken) - use librados2-perl for pool status - add librados2-perl as build-depends and depends in debian/control Signed-off-by: Alwin Antreich --- PVE/CLI/pvesm.pm | 1 +

[pve-devel] [PATCH v3 storage 1/2] Fix #1542: show storage utilization per pool

2018-04-11 Thread Alwin Antreich
- get the percent_used value for a ceph pool and calculate it where ceph doesn't supply it (pre kraken) - use librados2-perl for pool status - add librados2-perl as build-depends and depends in debian/control Signed-off-by: Alwin Antreich --- PVE/CLI/pvesm.pm | 1 +

[pve-devel] [PATCH v3 storage 0/2] show storage-utilization per pool

2018-04-11 Thread Alwin Antreich
Changes from v2 -> v3: - added comments to the status method for better understanding the calculation - had whitespace issues (again :/) Alwin Antreich (2): Fix #1542: show storage utilization per pool Refactor of method build_cmd and path PVE/CLI/pvesm.pm | 1 + PVE/Storage

[pve-devel] [PATCH v3 storage 2/2] Refactor of method build_cmd and path

2018-04-11 Thread Alwin Antreich
Method build_cmd and path use similar code to generate the ceph command line or qemu config parameters. They now use the private method ceph_connect_option for parameter generation. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 113

[pve-devel] [PATCH v4 storage 2/2] Refactor of method build_cmd and path

2018-04-13 Thread Alwin Antreich
Method build_cmd and path use similar code to generate the ceph command line or qemu config parameters. They now use the private method ceph_connect_option for parameter generation. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 113

[pve-devel] [PATCH v4 storage 1/2] Fix #1542: show storage utilization per pool

2018-04-13 Thread Alwin Antreich
- get storage utilization per pool - use librados2-perl for pool status - add librados2-perl as build-depends and depends in debian/control Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 3 +- PVE/Storage/RBDPlugin.pm | 72

[pve-devel] [PATCH v4 storage 0/2] show storage utilization per pool

2018-04-13 Thread Alwin Antreich
right %-usage. Alwin Antreich (2): Fix #1542: show storage utilization per pool Refactor of method build_cmd and path PVE/Storage.pm | 3 +- PVE/Storage/RBDPlugin.pm | 119 --- debian/control | 2 + 3 files changed, 63 insertions

[pve-devel] [PATCH manager 1/1] Cephfs storage wizard

2018-04-20 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 68 ++ 3 files changed, 79 insertions

[pve-devel] [PATCH storage 1/1] Cephfs storage plugin

2018-04-20 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 2 +- PVE/API2/Storage/Status.pm | 2 +- PVE

[pve-devel] [RFC storage/manager 0/2] Cephfs storage plugin

2018-04-20 Thread Alwin Antreich
monhost 192.168.1.2:6789 path /mnt/pve/cephfs0 content iso,backup,images,vztmpl,rootdir subdir /blubb fuse 0 username admin Comments and tests are very welcome. ;) Alwin Antreich (1): Cephfs storage plugin PVE/API2/Storage/Config.pm | 2 +- PVE

Re: [pve-devel] [PATCH storage 1/1] Cephfs storage plugin

2018-04-20 Thread Alwin Antreich
Hi, On Fri, Apr 20, 2018 at 03:42:22PM +0200, Alexandre DERUMIER wrote: > Hi, > > + > +sub plugindata { > +return { > +content => [ { images => 1, rootdir => 1, vztmpl => 1, iso => 1, > backup => 1}, > + { images => 1 }], > +format => [ { raw => 1, qcow2 =

[pve-devel] [PATCH storage] Fix #1750: set monhost split to old behavior

2018-05-04 Thread Alwin Antreich
The path method of the RBDPlugin got a list with comma separated monhosts, but it needs the list with semi-colon for qemu. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage

[pve-devel] [PATCH v2 manager] Cephfs storage wizard

2018-05-17 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3 files changed, 82 insertions

[pve-devel] [RFC v2 storage/manager 0/2] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
cp -r linux kernel source from tempfs # -> cephfs real0m23.522s user0m0.744s sys 0m3.292s # -> /root/ (SSD MX100) real0m3.318s user0m0.502s sys 0m2.770s # -> rbd mapped ext4 (SM863a) real0m3.313s user0m0.441s sys 0m2.826s Alwin Antreich (1): Cephfs storage plugi

[pve-devel] [PATCH v2 storage] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 2 +- PVE/API2/Storage/Status.pm | 2 +- PVE

[pve-devel] [PATCH v2 storage] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 2 +- PVE/Storage.pm | 2 + PVE/Storage

Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

2018-05-28 Thread Alwin Antreich
On Mon, May 28, 2018 at 05:36:50PM +0200, Alexandre Derumier wrote: > Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror. > > Call qga guest-fstrim if qga is available > --- > PVE/API2/Qemu.pm | 8 > PVE/QemuMigrate.pm | 5 + > 2 files changed, 13 insertions

Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

2018-05-29 Thread Alwin Antreich
On Mon, May 28, 2018 at 08:49:29PM +0200, Alexandre DERUMIER wrote: > >>If I understood it right, then the fstrim is called on every migrate with a > >>running guest agent. While, I guess the command is called also if you don't > >>have discard in the vm config activated and might only produce a

  1   2   3   4   >