On Thu, Apr 05, 2018 at 08:14:05AM +0200, Thomas Lamprecht wrote: > Still doesn't applies.... > > I recreated your patch with s/\s+$//g and compared, all the empty "stay > lines" > (i.e., lines from context which are not touched by the patch) miss their > initial > space (in patches the first character in a line is special: '-' means > remove, > '+' means add line, ' ' (space) means this line stays the same). > > So you patch, as is, cannot work! > > Am 04/04/2018 um 05:37 PM schrieb Alwin Antreich: > > Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> > > --- > > note: seems that, this one is need for the following patches to apply > > FYI: It's only needed if you had it in your git tree, else it wouldn't be > needed, > git can operate just fine on trailing whitespaces in otherwise empty lines. > (although it complains when applying the mail, but still does the work) > > If you insist that you, in fact, did not had any commit, changing those > trailing > whitespaces, in your history the only other reason I could immagine is that > your mail got scrambled by your MTA (unlikely if you use git send-email) or > by you when doing a last minute correction during sending (never do this, > I know everyone including myself does sometimes - being 100% sure it was > correct, but fact is: this action is heavily cursed and in >80% of the cases > you will end up with a patch which won't apply or has a new bug) > > In your case it's highly probably your MTA stripping away trailing spaces > (bad MTA!) as it's just to consistent in your patch... > > Other patches apply just fine, and I use a pretty vanilla setup which worked > for a few years good, so I guess/hope that it is not a fault here with me. > :) > Strange, I tried it with a fresh clone and it applied localy fine. I send my patches with git send-email. But what I didn't check is, if it applies from the pve-devel list. I will check. :-)
_______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
