If USB3 is enabled for a USB port of host type spice add a USB3
controller and use it.
To not break live migration this is only enabled for qemu 4.1 and
higher.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 4 ++--
PVE/QemuServer/USB.pm | 22 --
2 files changed
In a discussion with Stefan we came to the conclusion / realization that
all the checks for $kvmver and $machine may not be necessary.
This patch is most likely not correct the way it is now. More feedback
is welcome :)
On 8/28/19 4:26 PM, Aaron Lauterer wrote:
If USB3 is enabled for a USB
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/USBEdit.js | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index 8fc95c99..20c30fe6 100644
--- a/www/manager6/qemu/USBEdit.js
+++ b/www/manager6/qemu
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer/USB.pm | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
index a2097b9..05c78cf 100644
--- a/PVE/QemuServer/USB.pm
+++ b/PVE/QemuServer/USB.pm
@@ -87,9 +87,12 @@ sub
The check relied on the fact, that spice usb devices could not be usb3
in the past.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6e3b19e..0a0fda7 100644
--- a/PVE/QemuServer.pm
t; v2:
* no qemu version checks
* fix local resource check on migration
* add GUI support
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-August/038672.html
Aaron Lauterer (2):
Add USB3 support to Spice USB redirection
Fix local resources check for USB3 Spice devices
Add USB3 support fo
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/HardwareView.js | 4 ++--
www/manager6/qemu/PCIEdit.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 606c66e5..28384d37 100644
--- a/www
ports here is probably a bad idea and we need
to create a new `pve-q35-4.1.cfg` file? But this would mean that
the other changes could only be available once we ship Qemu 4.1?
Aaron Lauterer (1):
Add support for up to 10 PCI(e) devices
qemu-server:
PVE/QemuServer.pm | 2 +-
PVE
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 2 +-
PVE/QemuServer/PCI.pm | 18 +
pve-q35-4.0.cfg | 60 +++
3 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6e3b19e
On 9/2/19 1:57 PM, Thomas Lamprecht wrote:
On 8/30/19 9:40 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer/USB.pm | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
index a2097b9..05c78cf
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/HardwareView.js | 4 ++--
www/manager6/qemu/PCIEdit.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 606c66e5..cad29cc6 100644
--- a/www
are created on demand. This helps to keep live migration possible
without adding a new pve-q35*.cfg file.
For the windows 7 like guests additional addresses are reserved as well.
Signed-off-by: Aaron Lauterer
---
I decided to move the creation of the device string for the additional
root ports to
com/pipermail/pve-devel/2019-September/038743.html
Aaron Lauterer (2):
Add support for up to 16 PCI(e) devices
qemu-server:
PVE/QemuServer.pm | 8 +++--
PVE/QemuServer/PCI.pm | 70 +++
2 files changed, 76 insertions(+), 2 deletions(-)
pve-manager:
On 9/6/19 2:45 PM, Dominik Csapak wrote:
looks mostly ok, one (important) comment inline
# win7 is picky about pcie assignments
hostpci0bus0 => { bus => "pcie.0", addr => 16 },
hostpci1bus0 => { bus => "pcie.0", addr => 17 },
hostpci2bus0 => { bus => "pcie.0", addr =>
set.
Signed-off-by: Aaron Lauterer
---
The proposed[0] /^spice(,)?$/ regex does not match the `usb3=1` part and
fails. I opted for the simpler regex that checks if `spice` is that the
beginning.
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038749.html
PVE/QemuServer.pm | 2
GUI support
Aaron Lauterer (3):
(qemu-server) Add USB3 capablities to Spice USB devices
(qemu-server) Fix local resource check of Spice USB devices
(pve-manager) Enable USB3 for Spice USB passthrough
qemu-server:
PVE/QemuServer.pm | 4 ++--
PVE/QemuServer/USB.pm | 10 +++---
2 files
Instead of having two times the check if the USB3 setting needs to be
added to the config string it is now checked at one place only.
If USB3 is checked for a non USB3 device it will be attached to the USB2
root hub of the xhci controller.
Signed-off-by: Aaron Lauterer
---
@Thomas: I hope I
machine type was set to
Q35 an ehci controller was present and the VM was able to boot.
With this patch the behaviour is changing and the bus is set to xhci if
USB3 is set for the Spice USB device and the VM is running under Qemu
v4.1.
Signed-off-by: Aaron Lauterer
---
I use the
Polished phrasing
Signed-off-by: Aaron Lauterer
---
howto-improve-pve-docs.adoc | 42 +
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc
index c0d277e..940e050 100644
--- a/howto-improve
Polished the phrasing, aligned different names for a USB flash drive,
renamed OS X to macOS, changed primary recommendation for Windows to
Rufus, removed mention of os forensics.
Rufus now supports `dd` mode and is a much smaller download than
etcher.
Signed-off-by: Aaron Lauterer
---
pve
Polished phrasing, added mentions of the EULA and summary page in the
installer, unified style of cli commands.
Signed-off-by: Aaron Lauterer
---
pve-installation.adoc | 278 --
1 file changed, 134 insertions(+), 144 deletions(-)
diff --git a/pve
Polished phrasing
Signed-off-by: Aaron Lauterer
---
getting-help.adoc | 42 --
1 file changed, 20 insertions(+), 22 deletions(-)
diff --git a/getting-help.adoc b/getting-help.adoc
index 850d7a3..49d9085 100644
--- a/getting-help.adoc
+++ b/getting
Polished phrasing
Signed-off-by: Aaron Lauterer
---
sysadmin.adoc | 40 +++-
1 file changed, 15 insertions(+), 25 deletions(-)
diff --git a/sysadmin.adoc b/sysadmin.adoc
index e045610..9592c4a 100644
--- a/sysadmin.adoc
+++ b/sysadmin.adoc
@@ -5,31 +5,21
e are not yet happy with few things there.
Aaron Lauterer (9):
Rewrite Getting Help
Rewrite Improve PVE Docs
Rewrite Translation
Rewrite Installation
Rewrite System Requirements
Rewrite Install from USB flash drive
Rewrite Sysadmin
Rewrite Package Repositories
Rewrite System Sof
Polished phrasing
Signed-off-by: Aaron Lauterer
---
translation.adoc | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/translation.adoc b/translation.adoc
index ff99296..21dd1eb 100644
--- a/translation.adoc
+++ b/translation.adoc
Polished phrasing and restructured the requirements list a little bit
Signed-off-by: Aaron Lauterer
---
pve-system-requirements.adoc | 69 +++-
1 file changed, 36 insertions(+), 33 deletions(-)
diff --git a/pve-system-requirements.adoc b/pve-system
Polished phrasing and aligned cli command styling
Signed-off-by: Aaron Lauterer
---
system-software-updates.adoc | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/system-software-updates.adoc b/system-software-updates.adoc
index 04c17f3..bd5ff30
Polished phrasing, aligned cli command styling and line width
Signed-off-by: Aaron Lauterer
---
pve-package-repos.adoc | 154 +
1 file changed, 79 insertions(+), 75 deletions(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 06d1b2f
On 9/10/19 10:46 AM, Thomas Lamprecht wrote:
On 06.09.19 15:26, Aaron Lauterer wrote:
To not change current behaviour and thus breaking live migration USB3
for a Spice USB device requires Qemu v4.1.
The old behavior was that even though technically it was possible to
the set `usb3=1` setting
On 9/10/19 11:03 AM, Thomas Lamprecht wrote:
On 06.09.19 15:26, Aaron Lauterer wrote:
The check relied on the fact that in a regular use case a usb device of
type spice would not have any other settings like `usb3=1`. An exact
match worked fine for this.
This patch changes the behaviour and
machine type was set to
Q35 an ehci controller was present and the VM was able to boot.
With this patch the behaviour is changing and the bus is set to xhci if
USB3 is set for the Spice USB device and the VM is running under Qemu
v4.1.
Signed-off-by: Aaron Lauterer
---
I created the new
set.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 78ccf8c..05f0ab5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2925,7 +2925,7 @@ sub check_local_resources
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer/USB.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
index a2097b9..2c09490 100644
--- a/PVE/QemuServer/USB.pm
+++ b/PVE/QemuServer/USB.pm
@@ -86,7 +86,7 @@ sub get_usb_devices
ith a following comma. Thanks Thomas for pointing out how to
make it future proof
v2 -> v3:
* don't modify current behavior
* fix local resource check
* fix and cleanup GUI code
v1 -> v2:
* no qemu version checks
* fix local resource check on migration
* add GUI support
Aaron Laute
Instead of having two times the check if the USB3 setting needs to be
added to the config string it is now checked at one place only.
If USB3 is checked for a non USB3 device it will be attached to the USB2
root hub of the xhci controller.
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 66 +++
2 files changed, 67 insertions(+)
create mode 100644 www/manager6/form/SpiceEnhancementSelector.js
diff --git a/www/manager6/Makefile
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js| 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6a489e7e..139200c3 100644
--- a/www/manager6/Utils.js
+++ b
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 7ee7cd40..82e25c79 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -14,7 +14,7 @@ JSSRC
enabled if qxl/spice display selected
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/SystemEdit.js | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
index 846baa73..15ae9a73 100644
--- a
about/appreciate feedback for:
* the phrasing in the options panel
* right now with this implementation the System tab in the VM creation
wizard looks a bit unbalanced.
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038799.html
Aaron Lauterer (4):
Cleanup: align backslashes in
On 9/16/19 2:44 PM, Stefan Reiter wrote:
Tried my hand at a proper code review, I like the patches in general.
On 9/13/19 3:16 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js
On 9/16/19 2:44 PM, Stefan Reiter wrote:
On 9/13/19 3:16 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js | 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6
On 9/16/19 2:56 PM, Christian Ebner wrote:
On September 16, 2019 2:44 PM Stefan Reiter wrote:
+render_spice_enhancements: function(value) {
+ if (!value) {
+ return Proxmox.Utils.disabledText;
+ }
+ var props = PVE.Parser.parsePropertyString(value);
+
ome sort titled "SPICE"?
Yeah, the next version of this series will contain a different layout of
that panel that should make it clearer.
On 9/13/19 3:16 PM, Aaron Lauterer wrote:
enabled if qxl/spice display selected
Signed-off-by: Aaron Lauterer
---
www/manager
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js| 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6a489e7e..a9adb382 100644
--- a/www/manager6/Utils.js
+++ b
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 7ee7cd40..82e25c79 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -14,7 +14,7 @@ JSSRC
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 72 +++
2 files changed, 73 insertions(+)
create mode 100644 www/manager6/form/SpiceEnhancementSelector.js
diff --git a/www/manager6/Makefile
For a cleaner UI the SCSI Controller (pveScsiHwSelector) is moved to the
left column below the VGA selector. The new Spice enhancements
components is placed in the right column and enabled if qxl/spice is
selected in the VGA selector.
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu
-> v2:
* code cleanup / improvement
* rearranged the System panel in the VM creation wizard for a cleaner
and easier to understand UI
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038799.html
Aaron Lauterer (4):
Cleanup: align backslashes in manager6 Makefile
spice:
Signed-off-by: Aaron Lauterer
---
PVE/CLI/qmrestore.pm | 18 +-
PVE/QMPClient.pm | 38 +++---
PVE/QemuConfig.pm| 2 +-
PVE/QemuServer/Memory.pm | 2 +-
PVE/VZDump/QemuServer.pm | 2 +-
5 files changed, 31 insertions(+), 31
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/QemuBiosEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/qemu/QemuBiosEdit.js
b/www/manager6/qemu/QemuBiosEdit.js
index a0fad159..7283df74 100644
--- a/www/manager6/qemu/QemuBiosEdit.js
+++ b/www/manager6/qemu
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/DisplayEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js
index e5af00aa..8c54b7a7 100644
--- a/www/manager6/qemu/DisplayEdit.js
+++ b/www/manager6/qemu/DisplayEdit.js
I found two spots where documentation is available but the help button
was missing.
Aaron Lauterer (2):
Add online help to VM display settings
Add online help to VM bios settings
www/manager6/qemu/DisplayEdit.js | 1 +
www/manager6/qemu/QemuBiosEdit.js | 1 +
2 files changed, 2 insertions
On 9/18/19 12:11 PM, Dominik Csapak wrote:
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 72 +++
2 files changed, 73 insertions(+)
create
On 9/18/19 12:12 PM, Dominik Csapak wrote:
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js | 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6
Signed-off-by: Aaron Lauterer
---
button/Button.js | 4 ++--
data/DiffStore.js | 4 ++--
data/reader/JsonObject.js | 14 +++---
mixin/CBind.js| 14 +++---
node/TimeView.js | 14 +++---
panel/RRDChart.js | 14
recht wrote:
On 9/23/19 7:51 AM, Thomas Lamprecht wrote:
On 9/11/19 2:43 PM, Aaron Lauterer wrote:
This patch series enables USB3 for the passthrough / redirection of USB
devices via the Spice client.
v3 -> v4:
* cleanup of redundant if condition
* avoiding cyclic module dependency from U
:23 PM, Aaron Lauterer wrote:
I did some short tests with the latest commits and there is the following
problem:
Adding a USB3 device or port will result in such an error msg:
Parameter verification failed. (400)
usb1: invalid format - duplicate key in comma-separated list property
The fields relation is
not visible, also it looks like a checkbox misses "Spice enhancements"
as it's really not clear that this should be some sort of "option group
heading"
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
For a cleaner UI the SCSI Controller (pveScsiHwSelector
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/USBEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index 8cad8fc5..f41c3d21 100644
--- a/www/manager6/qemu/USBEdit.js
+++ b/www/manager6/qemu/USBEdit.js
support of the selected
device / port.
Signed-off-by: Aaron Lauterer
---
What started out to fix the problem discussed in the previous patch
series [0] turned into a refactoring of the controller.
I hope I got the regexes right.
Since we do not disable the USB3 checkbox anymore I am not sure why
Signed-off-by: Aaron Lauterer
---
www/manager6/form/USBSelector.js | 10 --
1 file changed, 10 deletions(-)
diff --git a/www/manager6/form/USBSelector.js b/www/manager6/form/USBSelector.js
index ed35bde0..82b59722 100644
--- a/www/manager6/form/USBSelector.js
+++ b/www/manager6/form
devices and leave the decision to the user if USB3 should be
enabled or not.
Signed-off-by: Aaron Lauterer
---
I don't want to call this v2 as we do things very differently than in
the previous patch [0] that dealt with this.
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/0
Signed-off-by: Aaron Lauterer
---
Put the hint in one line because AFAIU our tooling cannot handle
multiline gettext calls.
www/manager6/qemu/QemuBiosEdit.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/qemu/QemuBiosEdit.js
b/www/manager6/qemu
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 60 +++
2 files changed, 61 insertions(+)
create mode 100644 www/manager6/form/SpiceEnhancementSelector.js
diff --git a/www/manager6/Makefile
Signed-off-by: Aaron Lauterer
---
qm.adoc | 56
1 file changed, 56 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 0a1dfa6..583a248 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -819,6 +819,62 @@ start after those where the parameter is set
for a cleaner
and easier to understand UI
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038799.html
pve-docs: Aaron Lauterer (1):
qm.adoc | 56
1 file changed, 56 insertions(+)
pve-manager: Aaron Lauterer (2):
ui: add
Signed-off-by: Aaron Lauterer
---
removing the check if values is true and changing the parameters in
parsePropertyString to `parsePropertyString(values || {})` as suggested
in [0] does not work.
parsePropertyString expects a string. Passing anything except a string
containing a `key=value
Signed-off-by: Aaron Lauterer
---
There was no explanation of what SPICE is or a link to the project.
qm.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index 5f79547..e55fa50 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -636,7 +636,8 @@ necessary
Signed-off-by: Aaron Lauterer
---
qm.adoc | 63 +
1 file changed, 63 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 0a1dfa6..6eada34 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -819,6 +819,69 @@ start after those where the parameter is set
Signed-off-by: Aaron Lauterer
---
As suggested by Thomas in [0] I removed the gettext around the feature
names to have the same feature names accross all translations. This
should help if people start searching for a problem with them.
Removed the check if values is falsy because
Signed-off-by: Aaron Lauterer
---
As suggested by Thomas in [0] I removed the gettext around the feature
names to have the same feature names accross all translations. This
should help if people start searching for a problem with them.
The check if the hint to set SPICE in display is using a
a cleaner
and easier to understand UI
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038799.html
[1]:
https://git.proxmox.com/?p=pve-manager.git;a=commit;h=a017d8aaa1c7338745b0be55bc1d8d386cdc2b74
docs: Aaron Lauterer (1):
qm.
On 10/7/19 4:06 PM, Thomas Lamprecht wrote:
On 10/7/19 3:23 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
qm.adoc | 63 +
1 file changed, 63 insertions(+)
applied, thanks! Did a small fixup (4th order headings do
Thanks for finding that!
I'm looking into it.
On 10/7/19 7:53 PM, Gilberto Nunes wrote:
Never mind I forget to enable qemu agent in the VM...
Thanks
---
Gilberto Nunes Ferreira
(47) 3025-5907
(47) 99676-7530 - Whatsapp / Telegram
Skype: gilberto.nunes36
Em seg, 7 de out de 2019 às
the spice vdagent it
seems sensible to use that also for the foldersharing device by moving
it in front of the other spice devices.
[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-October/039441.html
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 10 +-
1 file changed, 5
The spice-webdavd daemon is part of the Spice project, not something we
develop here at Proxmox.
Also as Thomas already pointed out, Windows XP is very old and end of
life -> It's very much possible that it just doesn't work on Windows XP.
The error you are getting sounds like it :/
I never
On 10/10/19 12:21 PM, Dominik Csapak wrote:
On 10/10/19 11:54 AM, Thomas Lamprecht wrote:
To make it more clear that PVE does not somehow magically injects a
QHA into the VM, but that this can be set if one has installed the
QGA in the VM themself.
good idea to make it clearer, but i think t
Nicely written.
I have some suggestions inline:
* splitting long sentences
* adding more info as to what is valid for the size in
special_small_blocks (taken from the zfs man page)
* rewrote the last paragraph a bit
On 10/22/19 12:33 PM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
Some suggestions inline.
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Signed-off-by: Alwin Antreich
---
pveceph.adoc | 31 +
images/screenshot/gui-ceph-osd-destroy.png | Bin 0 -> 146184 bytes
2 files changed, 31 insertions(+)
create mode 10
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Signed-off-by: Alwin Antreich
---
pveceph.adoc | 19 ++
.../screenshot/gui-ceph-monitor-destroy.png | Bin 0 -> 154084 bytes
2 files changed, 19 insertions(+)
create mode 100644 images/screensh
On 11/5/19 10:40 AM, Aaron Lauterer wrote:
To remove an OSD via the GUI first select the {PVE} node in the tree
view. Select the **Ceph -> OSD** panel and select the OSD to destroy.
Next click the **OUT** button. Once the OSD's status changed from `in`
to `out` click the **STOP*
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Signed-off-by: Alwin Antreich
---
pveceph.adoc | 20 ++
.../screenshot/gui-ceph-manager-destroy.png | Bin 0 -> 153596 bytes
2 files changed, 20 insertions(+)
create mode 100644 images/screensh
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Signed-off-by: Alwin Antreich
---
pveceph.adoc | 21 +++
images/screenshot/gui-ceph-pools-destroy.png | Bin 0 -> 141532 bytes
2 files changed, 21 insertions(+)
create mode 100644 images/screensho
In general wouldn't it be better to change the headlines to active
voice? Create Monitors instead of Creating Monitors?
More suggestions inline.
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Put the previous added sections into subsection for a better outline of
the TOC.
With the rearrangement of
On 11/4/19 2:52 PM, Alwin Antreich wrote:
Signed-off-by: Alwin Antreich
---
pveceph.adoc | 54
1 file changed, 54 insertions(+)
diff --git a/pveceph.adoc b/pveceph.adoc
index 087c4d0..127e3bb 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
Spice foldersharing needs the webdavd daemon installed inside the guest.
This patch adds a hint to remind the user to install it in the VM.
Signed-off-by: Aaron Lauterer
---
www/manager6/form/SpiceEnhancementSelector.js | 13 +
1 file changed, 13 insertions(+)
diff --git a/www
Signed-off-by: Aaron Lauterer
---
qm.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 9ee4460..c0fe892 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -856,6 +856,8 @@ Select the folder to share and then enable the checkbox.
NOTE: Folder sharing currently only works in
Hmm, What about:
Currently this feature does not work reliably.
On 11/6/19 3:29 PM, Alwin Antreich wrote:
On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
qm.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qm.adoc b/qm.adoc
Signed-off-by: Aaron Lauterer
---
v1 -> v2: added Currently
qm.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 9ee4460..35d7d57 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -856,6 +856,8 @@ Select the folder to share and then enable the checkbox.
NOTE: Fol
Show storages configured for the target node and not for the current one
because they can be different.
Duplicated the `complete_storage` sub and extended it to extract the
targetnode from the parameters to pass it into the storage_check_enabled
function.
Signed-off-by: Aaron Lauterer
---
PVE
Show storages configured for the target node and not for the current one
because they can be different.
Duplicated the `complete_storage` sub and extended it to extract the
targetnode from the parameters to pass it into the storage_check_enabled
function.
Signed-off-by: Aaron Lauterer
---
v1
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
the functionality.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm| 10
On 11/19/19 4:13 PM, Thomas Lamprecht wrote:
On 11/19/19 4:01 PM, Aaron Lauterer wrote:
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
the functionality.
Signed-off-by: Aaron Lauterer
---
v1 -> v2: change `my $max_outputs` f
Some hints from my side inline.
Rephrasing some passages trying to make it easier to read and understand.
Did some sentence splitting an smaller corrections as well.
Please check if the rephrased sections are still correct from a
technical POV.
On 11/15/19 9:51 AM, Wolfgang Link wrote:
Imp
general overhaul of the documentation, improving phrasing, move open
source info
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
feedback from thomas[0]:
* moved open source hint to mailing list for devs
* added suggestions
* regarding spaces around dashes (--): our current technical writ
mail/pve-devel/2019-September/038938.html
Aaron Lauterer (10):
Overhaul Getting Help
Overhaul How To Improve Docs
Overhaul Translation
Overhaul Installation
Overhaul System Requirements
Overhaul Install from USB flash drive
Overhaul Sysadmin
Overhaul Package Repositories
OVerhau
general overhauling, improve phrasing
Signed-off-by: Aaron Lauterer
---
howto-improve-pve-docs.adoc | 38 +
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc
index c0d277e..d96bb03 100644
improve phrasing
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied suggestion from oguz [0]
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038952.html
translation.adoc | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --gi
1 - 100 of 345 matches
Mail list logo
