Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Andreas Steinel
On Wed, Jun 3, 2020 at 11:34 AM Andreas Steinel wrote: > Hopefully, we'll see the storage plugin framework happening in the future, > so that only additive changes are required in order to support new plugins. > This would hugely improve third-party-support and solve the problem of > integrating

Re: [pve-devel] [PATCH v5 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-08 Thread Aaron Lauterer
On 6/5/20 8:39 PM, Thomas Lamprecht wrote: On 5/6/20 11:57 AM, Aaron Lauterer wrote: [...] diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm index 68a3de89..77dac1b1 100644 --- a/PVE/API2/VZDump.pm +++ b/PVE/API2/VZDump.pm @@ -69,19 +69,26 @@ __PACKAGE__->register_method ({ retu

Re: [pve-devel] [PATCH v5 qemu-server] vzdump: move include logic for volumes to method

2020-06-08 Thread Aaron Lauterer
On 6/5/20 8:43 PM, Thomas Lamprecht wrote: On 5/6/20 11:57 AM, Aaron Lauterer wrote: Move the logic which volumes are included in the backup job to its own method and adapt the VZDump code accordingly. This makes it possible to develop other features around backup jobs. Signed-off-by: Aaron

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 12:19 PM, Michael Rasmussen wrote: > On Mon, 8 Jun 2020 11:16:29 +0200 > Andreas Steinel wrote: > >> [2] >> https://forum.proxmox.com/threads/frage-zfs-over-nfs.70734/post-318459 >> > And for those who does not understand German? > Well, if you want to understand German I suggest: htt

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 2:31 PM, Michael Rasmussen wrote: > On Mon, 8 Jun 2020 14:25:16 +0200 > Thomas Lamprecht wrote: >> FYI, there's the source code of the plugin loading here: >> https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage.pm;h=07a4f5300f5a7e21b635fb3927dd26f799d89439;hb=HEAD#l64 >> >> A

[pve-devel] [PATCH v3 manager 2/2] vzdump: test: add first tests to the guest include logic

2020-06-08 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v2 -> v3: * define pool in separate hash instead of in the return value * changed the adding and processing of tests as suggested by Thomas [0] v1 -> v2: adapt handling of return values, closer to what is used in production code. [0] https://pve.proxmox.com/pi

[pve-devel] [PATCH v3 manager 1/2] vzdump: make guest include logic testable

2020-06-08 Thread Aaron Lauterer
As a first step to make the whole guest include logic more testable the part from the API endpoint has been moved to its own method with as little changes as possible. Everything concerning `all` and `exclude` logic is still in the PVE::VZDump->exec_backup() method. Signed-off-by: Aaron Lauterer

Re: [pve-devel] [PATCH v5 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 1:55 PM, Aaron Lauterer wrote: >> >> $vmids = [ grep { !$excludehash->{$_} } sort keys $vmlist->{ids}->%* ]; >> >> but no hard feeling here. > > I agree on the early sorting, but I am not sure about that oneliner. It's not > as easy to comprehend what's going on for someone who isn't us

[pve-devel] applied-series: Re: [PATCH v3 manager 1/2] vzdump: make guest include logic testable

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 3:00 PM, Aaron Lauterer wrote: > As a first step to make the whole guest include logic more testable the > part from the API endpoint has been moved to its own method with as > little changes as possible. > > Everything concerning `all` and `exclude` logic is still in the > PVE::VZDump->

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Michael Rasmussen
On Mon, 8 Jun 2020 11:16:29 +0200 Andreas Steinel wrote: > [2] > https://forum.proxmox.com/threads/frage-zfs-over-nfs.70734/post-318459 > And for those who does not understand German? -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael rasmussen cc https://pgp.key-server.

Re: [pve-devel] [PATCH proxmox-widget-toolkit] networkedit: display mtu for ovsbond too

2020-06-08 Thread Thomas Lamprecht
On 6/7/20 1:30 PM, Alexandre Derumier wrote: > --- > node/NetworkEdit.js | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > Change looks OK, but I made the repo pass our new eslint JavaScript linter config and moved sources into a src/ directory to separate pack

[pve-devel] applied: Re: [PATCH pve-common] Inotify: write_network_interfaces : always autostart bond slaves interfaces

2020-06-08 Thread Thomas Lamprecht
On 6/7/20 1:39 PM, Alexandre Derumier wrote: > Currently, bond slaves are mostly working without autostart, > because bond slaves scripts from ifupdown1 && also ifupdown2 > have some kind of hacks to start the slaves. > > But if users want to do some tuning on the ifaces, they are not applied. >

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Michael Rasmussen
On Mon, 8 Jun 2020 14:25:16 +0200 Thomas Lamprecht wrote: > > FYI, there's the source code of the plugin loading here: > https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage.pm;h=07a4f5300f5a7e21b635fb3927dd26f799d89439;hb=HEAD#l64 > > An example plugin could be the one from linbit >

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-08 Thread Michael Rasmussen
On Mon, 8 Jun 2020 15:00:11 +0200 Thomas Lamprecht wrote: > > You can effectively provide a full custom plugin, so it has not more > limitations than any existing one. What extra functionality regarding > interface ABI would the FreeNAS Plugin require? > I seem to have read somewhere that a cus

Re: [pve-devel] [PATCH proxmox-widget-toolkit] networkedit: display mtu for ovsbond too

2020-06-08 Thread Alexandre DERUMIER
>>Change looks OK, but I made the repo pass our new eslint JavaScript linter >>config >>and moved sources into a src/ directory to separate packaging from source >>better, >>so this would need to be rebased. As it's just a small change I replicated >>here >>myself and pushed that out - thanks! >