by avoiding auto-vivification of $self->{online_local_volumes} via
iteration. most code paths don't care whether it's undef or a reference
to an empty list, but this caused the (already) fixed bug of calling
nbd_stop without having started an NBD server in the first place.
Signed-off-by: Fabian Gr
On 30.04.20 08:59, Fabian Grünbichler wrote:
On April 29, 2020 11:58 am, Fabian Ebner wrote:
The update_pct_config call leads to a write_config call and so the
configuration file was created before it was intended to be created.
When the CFS is updated in between the write_config call and the
P
For those not even having the attention span to read 4 short and
straight forward written sentences..
Co-authored-by: Aaron Lauterer
Signed-off-by: Thomas Lamprecht
---
pve-installation-media.adoc | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/pve-insta
On 4/30/20 8:41 AM, Thomas Lamprecht wrote:
On 4/30/20 8:35 AM, Fabian Grünbichler wrote:
On April 29, 2020 4:24 pm, Thomas Lamprecht wrote:
Signed-off-by: Thomas Lamprecht
---
This was rather quickly assembled to fix an obvious issue, some in depth look
at this would be nice, @Fabi or @Fabia
On 4/30/20 10:04 AM, Mira Limbeck wrote:
> On 4/30/20 8:41 AM, Thomas Lamprecht wrote:
>> On 4/30/20 8:35 AM, Fabian Grünbichler wrote:
>>> On April 29, 2020 4:24 pm, Thomas Lamprecht wrote:
Signed-off-by: Thomas Lamprecht
---
This was rather quickly assembled to fix an obvious
On 4/30/20 10:13 AM, Thomas Lamprecht wrote:
On 4/30/20 10:04 AM, Mira Limbeck wrote:
On 4/30/20 8:41 AM, Thomas Lamprecht wrote:
On 4/30/20 8:35 AM, Fabian Grünbichler wrote:
On April 29, 2020 4:24 pm, Thomas Lamprecht wrote:
Signed-off-by: Thomas Lamprecht
---
This was rather quickly asse
similar to the recent changes for pve-guest-common - we start each API
call with a cfs_update, but while we were waiting for the flock another
R-M-W cycle might have happened, so we need to refresh after obtaining
the lock.
Signed-off-by: Fabian Grünbichler
---
Notes:
there's only a single A
by moving the write_config calls from vmconfig_*_pending to their
call sites. The single other call site for update_pct_config in
update_vm is also adapted. The first write_config call in
vmconfig_hotplug_pending was redundant as the code between it and
the second write_config call shouldn't be abl
Hi,
seams the problem still exists in current version
(pve-manager/6.1-8/806edfe1 (running kernel: 5.3.18-3-pve))
Did you have time to check this again?
thx
Harald
Am 26.11.2019 um 15:22 schrieb Harald Leithner:
> Hi,
>
> good to know and thx for the fix. I think the same is true for creating
When the IPFilter setting is enabled and the container has DHCP
configured on an interface no 'arp-ip-src' filter should be added for
this interface as we don't have an IP address.
Previously '--arp-ip-src dhcp' was passed to ebtables which led to an error.
Signed-off-by: Mira Limbeck
---
src/P
On 4/30/20 12:00 PM, Mira Limbeck wrote:
When the IPFilter setting is enabled and the container has DHCP
configured on an interface no 'arp-ip-src' filter should be added for
this interface as we don't have an IP address.
Previously '--arp-ip-src dhcp' was passed to ebtables which led to an erro
When the IPFilter setting is enabled and the container has DHCP
configured on an interface no 'arp-ip-src' filter should be added as we
don't have an IP address.
Previously '--arp-ip-src dhcp' was passed to ebtables which led to an error.
Signed-off-by: Mira Limbeck
---
v2:
- changed regex to a
we really only want to rescan the disk size of the disks we actually
need, and that are only the local disks (for which we have to allocate
the correct size on the target)
also we want to always skip the efidisk, since we get the wanted
size after the loop, and this produced a confusing log line
(
Signed-off-by: Fabian Ebner
---
www/manager6/window/Migrate.js | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 9fc66a9b..20e057ad 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/
The size of VM state files and the size of unused disks not
referenced by any snapshot is not saved in the VM configuration,
so it's not available here either.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Migrate.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/m
so the current disk locations can be preserved even if
there are multiple local disks. And users don't have to
manually select the current storage if there is only one
local disk.
Signed-off-by: Fabian Ebner
---
Not too happy about the "use current layout" text. Maybe
somebody has a better idea.
Let's make this one an RFC ;)
The problem is that offline migration with target storage might not
always work depending on supported export/import formats. Then users
might start an offline migration, which then fails after a few disks
have already been copied.
If we had a check for the export/
explaining the main Requirements and limitations, as well as the
most important sync options
Signed-off-by: Dominik Csapak
---
pveum.adoc | 47 +++
1 file changed, 47 insertions(+)
diff --git a/pveum.adoc b/pveum.adoc
index c89d4b8..5881fa9 100644
---
with link to the LDAP Syncing section of the documentation
Signed-off-by: Dominik Csapak
---
www/manager6/dc/SyncWindow.js | 8
1 file changed, 8 insertions(+)
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index e85e5b88..9355c551 100644
--- a/www/manager6/
one comment inline
On 4/30/20 12:59 PM, Fabian Ebner wrote:
The size of VM state files and the size of unused disks not
referenced by any snapshot is not saved in the VM configuration,
so it's not available here either.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Migrate.js | 2 +-
On 4/30/20 1:15 PM, Fabian Ebner wrote:
Let's make this one an RFC ;)
The problem is that offline migration with target storage might not
always work depending on supported export/import formats. Then users
might start an offline migration, which then fails after a few disks
have already be
My suggestions inline.
On Thu, Apr 30, 2020 at 01:14:27PM +0200, Dominik Csapak wrote:
> explaining the main Requirements and limitations, as well as the
> most important sync options
>
> Signed-off-by: Dominik Csapak
> ---
> pveum.adoc | 47 +++
> 1
explaining the main Requirements and limitations, as well as the
most important sync options
Signed-off-by: Dominik Csapak
---
changes from v1:
* incorporated suggestions from Alwin, thanks :)
* re-worded the sentence about limitations to specify the character
limitations of user.cfg
pveum.ado
Sorry, I didn't get to read v1 in time. Some nits regarding grammar,
reading flow and such inline:
Other than those:
Reviewed-By: Aaron Lauterer
On 4/30/20 2:27 PM, Dominik Csapak wrote:
explaining the main Requirements and limitations, as well as the
most important sync options
Signed-off-b
On 4/29/20 5:30 PM, Andreas Steinel wrote:
> Signed-off-by: Andreas Steinel
> ---
> pvesm.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pvesm.adoc b/pvesm.adoc
> index 5340c3d..b76ce87 100644
> --- a/pvesm.adoc
> +++ b/pvesm.adoc
> @@ -84,8 +84,8 @@ data to di
username can include some special characters, so we have
to escape them
Signed-off-by: Dominik Csapak
---
window/TaskViewer.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/window/TaskViewer.js b/window/TaskViewer.js
index 347542e..bbbf716 100644
--- a/window/TaskViewer.
username can include some special characters, so we have
to escape them
Signed-off-by: Dominik Csapak
---
www/manager6/Workspace.js | 2 +-
www/manager6/dc/ACLView.js | 2 +-
www/manager6/dc/GroupView.js | 1 +
www/manager6/dc/Log.js | 2 ++
www/manager6/dc/Per
replaces the random hacks where we do some hail-mary mkdir in a
writer or the like, to ensure that the directory structure exists and
we can write safely.
more central and safer would be pmxcfs itself, but to late in the
release cycle to do that now.
Chicken out if pmxcfs is not mounted, we don't
28 matches
Mail list logo
