On 4/30/20 1:15 PM, Fabian Ebner wrote:
Let's make this one an RFC ;)
The problem is that offline migration with target storage might not
always work depending on supported export/import formats. Then users
might start an offline migration, which then fails after a few disks
have already been copied.
If we had a check for the export/import formats before starting
migration, it would improve. But currently the erroring out happens on a
per disk basis inside storage_migrate.
So I'm not sure anymore if this is an improvement. If not, and if patch
#3 is fine, I'll send a v2 without this one.
if we cannot produce a warning/error beforehand, i would abstain
from allowing it in the gui (for now)
we had a similar issue with local disks, which is the
reason most of this panel exists in the first place
having the user wait for an error late into the migration
is really not nice and frustrating for the user
but for 3/3 i wanted to send a very similar patch myself,
so that one is ack'ed by me
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
